[FilterScript] Deathmatch Event [Simple and Automatic].
#1

Hello,

Intro
It's been very long since I last made any releases, therefore I thought I should take a few minutes to make something simple and easy and release, just for the sake of it. This is not a very huge release or something, it's a simple Deathmatch event, it works pretty simple and the process is automated, which means all you (the admin) have to do is start the event with a command and rest is up to the system.



Features
  • Simple and automated.
  • join by simply typing /join.
  • Dm event Map provided within the script.
  • Map created for event virtual world only.
  • Saves and loads player weapons & locations. (saves when they join and loads when the leave).
  • Prizes for the winner.
  • Event done in another virtual world to avoid conflicts.
  • Optimized as much as possible with multiple tests.


Installation
  • Dependencies
    - a_samp (SA:MP Team)
    - zcmd (by zeex?)
    - YSI/y_iterate (foreach)
    - streamer (incognito)
  • Installation
    - Download the filterscript from github repo.
    - Download the required dependencies (if you don't have them already).
    - Place the .inc files into /pawno/include/ folder.
    - Open your IDE (pawn, sublime notepad++ etc) and compile the filterscript.pwn.
    - Open server.cfg and add dm_event to filterscripts.
    - Start the server..
    - Go ig and type /adminevent
  • Note
    I do not force you to keep any credits (even tho i havent added any in script), feel free to use it anyhow you want

Media
  • Credits
    - Samp Team for <a_samp>
    - Y_Less for YSI.
    - Incognito for streamer.
    - Zeex for zcmd.
    - Me for some effort
    - Zeth for testing.


  • Download
    - github repo
    https://github.com/iiLearner/dm_event
For any bugs create an issue on github, kbyethnx.
Reply
#2

1- dont combine usage of spaces and tabs

2- what is this :
Code:
public OnPlayerConnect(playerid)
{
    RemoveBuildingForEvent(playerid);
    return 1;
}
3- wont ur ranom spawns sometimes place players stacked upon each other? I mean it is random after all yeah?
Reply
#3

I started using vscode very recently that might be cause I combined spaces and tabs.
CTRL+f "RemoveBuildingForEvent".
Could rarely happen yet I don't see it as big deal.
Reply
#4

Everything else seems good - but the naming convention? Nah...

https://github.com/iiLearner/dm_even...nt.pwn#L7-#L23

(From line number 7 to 23)

m_color? what is it supposed to mean?

dmIsOpen, dmcount, dmEventJoinable, isinDMEvent - That should follow one strict pattern or should be an array.

--

https://github.com/iiLearner/dm_even...pwn#L245-#L250

"PlayerName" - is that a variable or a function?

--

What is this release? I wasn't expecting this.
Reply
#5

All the names make sense to me, but yeah except for m_color cause i just called it like that.
About PlayerName question, what makes you think its a variable?
Reply
#6

Quote:
Originally Posted by iLearner
View Post
All the names make sense to me, but yeah except for m_color cause i just called it like that.
About PlayerName question, what makes you think its a variable?
1) I'm sorry - but you're releasing a filterscript and letting the user guess what it means? Not trying to be rude but that needs to be changed.

2) Because of your naming convention and how VAGUE you name your functions, make it be GetPlayerNameEx or something like it.
Reply
#7

You could be right or maybe not, I'd like to hear some other people before changing the code, if you're right, I'll do it without any hesitation.
Reply
#8

really nice. +REP
Reply
#9

One word: Mediocre.
Reply
#10

Quote:
Originally Posted by xMoBi
View Post
One word: Mediocre.
If you're going to flaw a script mention flaws.

I still think you should handle position setting differently
Reply
#11

well i tried it and i really like it
this is good release
Reply
#12

Good job, keep it up.
Reply
#13

Good Job!

Do you accept pull requests? I wanna optimize your code a bit.
Reply
#14

Sure.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)