SA-MP Forums Archive
[FilterScript] Deathmatch Event [Simple and Automatic]. - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Filterscripts (https://sampforum.blast.hk/forumdisplay.php?fid=17)
+--- Thread: [FilterScript] Deathmatch Event [Simple and Automatic]. (/showthread.php?tid=658829)



Deathmatch Event [Simple and Automatic]. - iLearner - 13.09.2018

Hello,

Intro
It's been very long since I last made any releases, therefore I thought I should take a few minutes to make something simple and easy and release, just for the sake of it. This is not a very huge release or something, it's a simple Deathmatch event, it works pretty simple and the process is automated, which means all you (the admin) have to do is start the event with a command and rest is up to the system.



Features


Installation

Media
For any bugs create an issue on github, kbyethnx.


Re: Deathmatch Event [Simple and Automatic]. - RogueDrifter - 13.09.2018

1- dont combine usage of spaces and tabs

2- what is this :
Code:
public OnPlayerConnect(playerid)
{
    RemoveBuildingForEvent(playerid);
    return 1;
}
3- wont ur ranom spawns sometimes place players stacked upon each other? I mean it is random after all yeah?


Re: Deathmatch Event [Simple and Automatic]. - iLearner - 13.09.2018

I started using vscode very recently that might be cause I combined spaces and tabs.
CTRL+f "RemoveBuildingForEvent".
Could rarely happen yet I don't see it as big deal.


Re: Deathmatch Event [Simple and Automatic]. - Logic_ - 13.09.2018

Everything else seems good - but the naming convention? Nah...

https://github.com/iiLearner/dm_even...nt.pwn#L7-#L23

(From line number 7 to 23)

m_color? what is it supposed to mean?

dmIsOpen, dmcount, dmEventJoinable, isinDMEvent - That should follow one strict pattern or should be an array.

--

https://github.com/iiLearner/dm_even...pwn#L245-#L250

"PlayerName" - is that a variable or a function?

--

What is this release? I wasn't expecting this.


Re: Deathmatch Event [Simple and Automatic]. - iLearner - 13.09.2018

All the names make sense to me, but yeah except for m_color cause i just called it like that.
About PlayerName question, what makes you think its a variable?


Re: Deathmatch Event [Simple and Automatic]. - Logic_ - 13.09.2018

Quote:
Originally Posted by iLearner
View Post
All the names make sense to me, but yeah except for m_color cause i just called it like that.
About PlayerName question, what makes you think its a variable?
1) I'm sorry - but you're releasing a filterscript and letting the user guess what it means? Not trying to be rude but that needs to be changed.

2) Because of your naming convention and how VAGUE you name your functions, make it be GetPlayerNameEx or something like it.


Re: Deathmatch Event [Simple and Automatic]. - iLearner - 13.09.2018

You could be right or maybe not, I'd like to hear some other people before changing the code, if you're right, I'll do it without any hesitation.


Re: Deathmatch Event [Simple and Automatic]. - ZigGamerx - 13.09.2018

really nice. +REP


Re: Deathmatch Event [Simple and Automatic]. - xMoBi - 13.09.2018

One word: Mediocre.


Re: Deathmatch Event [Simple and Automatic]. - RogueDrifter - 13.09.2018

Quote:
Originally Posted by xMoBi
View Post
One word: Mediocre.
If you're going to flaw a script mention flaws.

I still think you should handle position setting differently


Re: Deathmatch Event [Simple and Automatic]. - CaptainBoi - 13.09.2018

well i tried it and i really like it
this is good release


Re: Deathmatch Event [Simple and Automatic]. - solstice_ - 13.09.2018

Good job, keep it up.


Re: Deathmatch Event [Simple and Automatic]. - AmirSavand - 15.09.2018

Good Job!

Do you accept pull requests? I wanna optimize your code a bit.


Re: Deathmatch Event [Simple and Automatic]. - iLearner - 15.09.2018

Sure.