Why isn't this command working? /park
#1

I've written up this command and it's not working, I think it's to do with the formatting. Could someone explain to me why this isn't working?

Код:
if(strcmp(cmd, "/park", true) == 0)
	{
	    new name[MAX_PLAYERS];
		new Float:x,Float:y,Float:z;
		new Float:a;
		new carid;
		new getcarid;
		if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
		else { return 1; }
		getcarid = GetPlayerVehicleID(playerid);
		GetPlayerName(playerid, name, sizeof (name));
		GetVehiclePos(carid, x, y, z);
		//GetPlayerFacingAngle(playerid, a);
		GetVehicleZAngle(carid, a);
		if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
		{
			if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 & PlayerInfo[playerid][pPcarkey3])
			{
				SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
				return 1;
			}
			if(getcarid == carid)
			{
				CarInfo[carid][cLocationx] = x;
				CarInfo[carid][cLocationy] = y;
				CarInfo[carid][cLocationz] = z;
				CarInfo[carid][cAngle] = a;
				format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
				GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
				OnPropUpdate();
				OnPlayerUpdate(playerid);
				DestroyVehicle(carid);
				CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
				TogglePlayerControllable(playerid, 1);
				return 1;
			}
		}
	}
Reply
#2

whats the problem? what it shows when you compile it?
Reply
#3

No errors, it just doesn't work in game.
Reply
#4

did you define anything?
when i compile it and it shows error
Reply
#5

huh strange many FS Is not working in game these days
Reply
#6

Quote:
Originally Posted by jejemonerz123
Посмотреть сообщение
huh strange many FS Is not working in game these days
This isn't a filterscript. Everything is defined, like I said, I think there's something wrong with the formatting. I just need someone to help
Reply
#7

does it save the x y z at all?
Reply
#8

Try moving to the very top of your callback (public OnPlayerCommandText, NOT above it, but very first command under it)

OR...

Move it to the very bottom to make it as the last command. Sometimes other functions will interfere with it.
Reply
#9

Remember GetPlayerVehicleID(playerid) will return only the vehicleid in the server and not its model id. If you want that then its okay.
otherwise use this - GetVehicleModel(GetPlayerVehicleID(playerid))

Try this:

Код:
if(strcmp(cmd, "/park", true) == 0)
	{
	    new name[MAX_PLAYERS];
		new Float:x,Float:y,Float:z;
		new Float:a;
		new carid;
		new getcarid;
		if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
		else if(GetVehicleVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
		else { return 1; }
		getcarid = GetPlayerVehicleID(playerid);
		GetPlayerName(playerid, name, sizeof (name));
		GetVehiclePos(carid, x, y, z);
		//GetPlayerFacingAngle(playerid, a);
		GetVehicleZAngle(carid, a);
		if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
		{
			if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 && PlayerInfo[playerid][pPcarkey3] == 999)
			{
				SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
				return 1;
			}
			if(getcarid == carid)
			{
				CarInfo[carid][cLocationx] = x;
				CarInfo[carid][cLocationy] = y;
				CarInfo[carid][cLocationz] = z;
				CarInfo[carid][cAngle] = a;
				format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
				GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
				OnPropUpdate();
				OnPlayerUpdate(playerid);
				DestroyVehicle(carid);
				CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
				TogglePlayerControllable(playerid, 1);
				return 1;
			}
		}
	}
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)