SA-MP Forums Archive
Why isn't this command working? /park - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: Why isn't this command working? /park (/showthread.php?tid=230717)


Why isn't this command working? /park - Mr. Despair - 24.02.2011

I've written up this command and it's not working, I think it's to do with the formatting. Could someone explain to me why this isn't working?

Код:
if(strcmp(cmd, "/park", true) == 0)
	{
	    new name[MAX_PLAYERS];
		new Float:x,Float:y,Float:z;
		new Float:a;
		new carid;
		new getcarid;
		if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
		else { return 1; }
		getcarid = GetPlayerVehicleID(playerid);
		GetPlayerName(playerid, name, sizeof (name));
		GetVehiclePos(carid, x, y, z);
		//GetPlayerFacingAngle(playerid, a);
		GetVehicleZAngle(carid, a);
		if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
		{
			if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 & PlayerInfo[playerid][pPcarkey3])
			{
				SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
				return 1;
			}
			if(getcarid == carid)
			{
				CarInfo[carid][cLocationx] = x;
				CarInfo[carid][cLocationy] = y;
				CarInfo[carid][cLocationz] = z;
				CarInfo[carid][cAngle] = a;
				format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
				GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
				OnPropUpdate();
				OnPlayerUpdate(playerid);
				DestroyVehicle(carid);
				CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
				TogglePlayerControllable(playerid, 1);
				return 1;
			}
		}
	}


Re: Why isn't this command working? /park - Ironboy - 24.02.2011

whats the problem? what it shows when you compile it?

Re: Why isn't this command working? /park - Mr. Despair - 24.02.2011

No errors, it just doesn't work in game.

Re: Why isn't this command working? /park - Ironboy - 24.02.2011

did you define anything?
when i compile it and it shows error

Re: Why isn't this command working? /park - jejemonerz123 - 24.02.2011

huh strange many FS Is not working in game these days

Re: Why isn't this command working? /park - Mr. Despair - 24.02.2011

Quote:
Originally Posted by jejemonerz123
Посмотреть сообщение
huh strange many FS Is not working in game these days
This isn't a filterscript. Everything is defined, like I said, I think there's something wrong with the formatting. I just need someone to help

Re: Why isn't this command working? /park - Abreezy - 24.02.2011

does it save the x y z at all?

Re: Why isn't this command working? /park - grand.Theft.Otto - 24.02.2011

Try moving to the very top of your callback (public OnPlayerCommandText, NOT above it, but very first command under it)

OR...

Move it to the very bottom to make it as the last command. Sometimes other functions will interfere with it.

Re: Why isn't this command working? /park - deather - 24.02.2011

Remember GetPlayerVehicleID(playerid) will return only the vehicleid in the server and not its model id. If you want that then its okay.
otherwise use this - GetVehicleModel(GetPlayerVehicleID(playerid))

Try this:

Код:
if(strcmp(cmd, "/park", true) == 0)
	{
	    new name[MAX_PLAYERS];
		new Float:x,Float:y,Float:z;
		new Float:a;
		new carid;
		new getcarid;
		if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
		else if(GetVehicleVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
		else { return 1; }
		getcarid = GetPlayerVehicleID(playerid);
		GetPlayerName(playerid, name, sizeof (name));
		GetVehiclePos(carid, x, y, z);
		//GetPlayerFacingAngle(playerid, a);
		GetVehicleZAngle(carid, a);
		if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
		{
			if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 && PlayerInfo[playerid][pPcarkey3] == 999)
			{
				SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
				return 1;
			}
			if(getcarid == carid)
			{
				CarInfo[carid][cLocationx] = x;
				CarInfo[carid][cLocationy] = y;
				CarInfo[carid][cLocationz] = z;
				CarInfo[carid][cAngle] = a;
				format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
				GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
				OnPropUpdate();
				OnPlayerUpdate(playerid);
				DestroyVehicle(carid);
				CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
				TogglePlayerControllable(playerid, 1);
				return 1;
			}
		}
	}