[Type-R]

Hello, i was curious if this callback is called when a player disconnects if he is viewing the menu?? I could not find that on the wiki. Thank you.

[jwh]

First thing I would do is test if it gets called. But even with that, I wouldn't count on it. Imagine it doesn't get called and you really need to do something important in OnPlayerExitedMenu.

If you want to make sure it gets called, call it in OnPlayerDisconnect(). Simple, in OnPlayerDisconnect, just call OnPlayerExitedMenu...

Код:

public OnPlayerExitedMenu(playerid)
{
    return 1;
}

public OnPlayerDisconnect(playerid, reason)
{
	OnPlayerExitedMenu(playerid);
	return 1;
}

Also, make sure to add a check in OnPlayerExitedMenu to make sure it doesn't get called twice. For example...Make sure the menu is open before doing the "cleanup".

[Shinja]

If it's called twice then just remove this addition at OnPlayerDisconnect ^

[jwh]

^ And what if packet loss occurs and the server does not receive the packet that runs OnPlayerExitedMenu? causing OnPlayerExitedMenu to never run and something important in that function needs to run when a player disconnects? Better be safe then write code based on luck.

[SickAttack]

Quote:

Originally Posted by jwh ^ And what if packet loss occurs and the server does not receive the packet that runs OnPlayerExitedMenu? causing OnPlayerExitedMenu to never run and something important in that function needs to run when a player disconnects? Better be safe then write code based on luck.

What are you talking about? The callback only handles the ID of the player, which OnPlayerDisconnect always gets right.

[jwh]

Quote:

Originally Posted by SickAttack What are you talking about? The callback only handles the ID of the player, which OnPlayerDisconnect always gets right.

According to https://sampwiki.blast.hk/wiki/OnPlayerExitedMenu
Called when a player exits a menu. (Only when a player exits a menu)

When a packet loss occurs, that callback is never called. Server might see the menu as open, even though it was closed client sided (p.s. "not even sure the server tracks opened menus making it possible to send repeated "exitmenu" packets. to be safe, make sure that callback is not called when a menu is not open"). OnPlayerExitedMenu does not get called when a player disconnects. It's like saying OnPlayerExitVehicle is called when a player disconnects.

[SickAttack]

Quote:

Originally Posted by jwh According to https://sampwiki.blast.hk/wiki/OnPlayerExitedMenu Called when a player exits a menu. (Only when a player exits a menu) When a packet loss occurs, that callback is never called. Server might see the menu as open, even though it was closed client sided (p.s. "not even sure the server tracks opened menus making it possible to send repeated "exitmenu" packets. to be safe, make sure that callback is not called when a menu is not open"). OnPlayerExitedMenu does not get called when a player disconnects. It's like saying OnPlayerExitVehicle is called when a player disconnects.

There is no problem at all in calling it under OnPlayerDisconnect. He probably just wants to reset some variables or stuff like that.

[jwh]

Quote:

Originally Posted by SickAttack There is no problem at all in calling it under OnPlayerDisconnect. He probably just wants to reset some variables or stuff like that.

I suggested him to call it in OnPlayerDisconnect :P

[Type-R]

I get a warning though now:

Код:

C:\Users\boksi\Desktop\SAMP reikalai\FunZoneLT\filterscripts\ADMINAS.pwn(6568) : warning 213: tag mismatch
C:\Users\boksi\Desktop\SAMP reikalai\FunZoneLT\filterscripts\ADMINAS.pwn(6571) : warning 213: tag mismatch

for lines:

Код:

if(examplemenu[playerid] != -1)

and:

Код:

examplemenu[playerid] = -1;

Maybe i cant make them equal something, when its Menu:examplemenu I think it works, but gives me warnings..

[Shinja]

How you are declaring examplemenu?