1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
How fast should be loading 600 houses?
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#1

15.04.2016, 13:54
( Последний раз редактировалось BloodyRP; 15.04.2016 в 20:16. )
Hello for everyone.
At the start I need to say u that my english is so poor and I'm sorry about that, but I rly need your help.
If I have 661 houses on gamemode and that all work with mysql r39-5 how much seconds that should get to load all info?
[More info]:
first house load in 23.14.31
Код:
[23:14:31] [DEBUG] cache_get_row_int - row: 0, field_idx: 0, connection: 1
[23:14:31] [DEBUG] CMySQLResult::GetRowData - row: '0', field: '0', data: "1"
and last house end in 23.15.19
Код:
[23:15:19] [DEBUG] cache_get_row_int - row: 660, field_idx: 15, connection: 1
[23:15:19] [DEBUG] CMySQLResult::GetRowData - row: '660', field: '15', data: "0"
So I want to ask a good pro coders. Is it normal to 48 secs load all information and save in variables? If not - what I need to do for fixing this? Thanks for every help.

Код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses");


        forward LoadHouses();
public LoadHouses()
{
	new time = GetTickCount();
	for(new b; b != 660; ++b)
	{
	    House[b][hID] = cache_get_row_int(b, 0);
	    House[b][hEnterX] = cache_get_row_float(b, 1);
	    House[b][hEnterY] = cache_get_row_float(b, 2);
	    House[b][hEnterZ] = cache_get_row_float(b, 3);
	    House[b][hExitX] = cache_get_row_float(b, 4);
	    House[b][hExitY] = cache_get_row_float(b, 5);
	    House[b][hExitZ] = cache_get_row_float(b, 6);
	    House[b][hCarX] = cache_get_row_float(b, 7);
	    House[b][hCarY] = cache_get_row_float(b, 8);
	    House[b][hCarZ] = cache_get_row_float(b, 9);
	    House[b][hCarC] = cache_get_row_float(b, 10);
	    cache_get_row(b, 11, House[b][hOwner]);
	    House[b][hCost] = cache_get_row_int(b, 12);
	    House[b][hInt] = cache_get_row_int(b, 13);
	    House[b][hVW] = cache_get_row_int(b, 14);
	    House[b][hLock] = cache_get_row_int(b, 15);
	}
    printf("%d ms",GetTickCount()-time);
}
How to make that faster?
Find
Reply
saffierr
High-roller
*****
Posts: 1,147
Threads: 109
Joined: Jul 2013
Reputation: 0
#2

15.04.2016, 13:55
40 seconds are incredibly much...
Find
Reply
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#3

15.04.2016, 13:56
Quote:
Originally Posted by saffierr
Посмотреть сообщение
40 seconds are incredibly much...
so whats wrong in my code? how to do that faster?
Find
Reply
Konstantinos
Spam Machine
*****
Posts: 11,827
Threads: 33
Joined: Dec 2011
Reputation: 0
#4

15.04.2016, 14:41
If you have 661 houses, the size of House array shouldn't be 800 but 670-675 and if needed more, changing the slot and restart the server wouldn't be a problem.

Anyway, as for your queries. Use cache_get_row/cache_get_row_* functions instead because retrieving the field's name requires more time that just a number.

I still recommended using threaded queries (mysql_pquery is used for more than 1 connection) though.

Last, more of a question. You do have an hID in your table so why you use "b" and start indexes from 1 when 0 can be used too?
Find
Reply
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#5

15.04.2016, 15:01
( Последний раз редактировалось BloodyRP; 15.04.2016 в 16:36. )
Quote:
Originally Posted by Konstantinos
Посмотреть сообщение
If you have 661 houses, the size of House array shouldn't be 800 but 670-675 and if needed more, changing the slot and restart the server wouldn't be a problem.

Anyway, as for your queries. Use cache_get_row/cache_get_row_* functions instead because retrieving the field's name requires more time that just a number.

I still recommended using threaded queries (mysql_pquery is used for more than 1 connection) though.

Last, more of a question. You do have an hID in your table so why you use "b" and start indexes from 1 when 0 can be used too?
Thank you, changed to 670 size.

I tryed like u said, now I have:
Код:
                        House[b][hID] = cache_get_row_int(h, 0);
			House[b][hEnterX] = cache_get_row_float(h,1);
			House[b][hEnterY] = cache_get_row_float(h,2);
			House[b][hEnterZ] = cache_get_row_float(h,3);
			House[b][hExitX] = cache_get_row_float(h,4);
			House[b][hExitY] = cache_get_row_float(h,5);
			House[b][hExitZ] = cache_get_row_float(h,6);
			House[b][hCarX] = cache_get_row_float(h,7);
			House[b][hCarY] = cache_get_row_float(h,8);
			House[b][hCarZ] = cache_get_row_float(h,9);
			House[b][hCarZ] = cache_get_row_float(h,10);
			cache_get_row(h,11,House[b][hOwner]);
			House[b][hCost] = cache_get_row_int(h,12);
			House[b][hInt] = cache_get_row_int(h,13);
			House[b][hVW] = cache_get_row_int(h,14);
			House[b][hLock] = cache_get_row_int(h,15);
and I still have 47 seconds to load all info into variables;
first house:
Код:
[17:59:48] [DEBUG] cache_get_row_int - row: 0, field_idx: 0, connection: 1
[17:59:48] [DEBUG] CMySQLResult::GetRowData - row: '0', field: '0', data: "1"
last house:
Код:
[18:00:35] [DEBUG] cache_get_row_int - row: 660, field_idx: 15, connection: 1
[18:00:35] [DEBUG] CMySQLResult::GetRowData - row: '660', field: '15', data: "0"
Find
Reply
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#6

15.04.2016, 15:47
( Последний раз редактировалось BloodyRP; 15.04.2016 в 16:36. )
I tryed to do that with pquery:
Код:
server = mysql_connect("", "", "", "",3306,true,5);
so u see that 5 connections I have. (Dont know how much is good option)
then load like this:
Код:
for(new i = 0; i < 661; i++) mysql_pquery(server, "SELECT * FROM houses", "LoadHouses","d",i);
and public:

Код:
forward LoadHouses(inter);
public LoadHouses(inter)
{
	new b = inter+1;
        House[b][hID] = cache_get_row_int(inter, 0);
	House[b][hEnterX] = cache_get_row_float(inter,1);
	House[b][hEnterY] = cache_get_row_float(inter,2);
	House[b][hEnterZ] = cache_get_row_float(inter,3);
	House[b][hExitX] = cache_get_row_float(inter,4);
	House[b][hExitY] = cache_get_row_float(inter,5);
	House[b][hExitZ] = cache_get_row_float(inter,6);
	House[b][hCarX] = cache_get_row_float(inter,7);
	House[b][hCarY] = cache_get_row_float(inter,8);
	House[b][hCarZ] = cache_get_row_float(inter,9);
	House[b][hCarZ] = cache_get_row_float(inter,10);
	cache_get_row(inter,11,House[b][hOwner]);
	House[b][hCost] = cache_get_row_int(inter,12);
	House[b][hInt] = cache_get_row_int(inter,13);
	House[b][hVW] = cache_get_row_int(inter,14);
	House[b][hLock] = cache_get_row_int(inter,15);
}
and this still needs ~45 seconds to load all info. How to fix this ?! oh god..
Find
Reply
Konstantinos
Spam Machine
*****
Posts: 11,827
Threads: 33
Joined: Dec 2011
Reputation: 0
#7

15.04.2016, 15:49
It takes so much because you load 660 times the already loaded data. Do not use loop, the query itself selects ALL the data from the table.

EDIT: That's how it should be assuming hID is set to AUTO_INCREMENT.
pawn Код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses","");
pawn Код:
forward LoadHouses();
public LoadHouses()
{
    new rows = clamp(cache_get_row_count(server), 0, sizeof House - 1);
    for(new b; b != rows; ++b)
    {
        House[b][hID] = cache_get_row_int(b, 0);
        House[b][hEnterX] = cache_get_row_float(b, 1);
        House[b][hEnterY] = cache_get_row_float(b, 2);
        House[b][hEnterZ] = cache_get_row_float(b, 3);
        House[b][hExitX] = cache_get_row_float(b, 4);
        House[b][hExitY] = cache_get_row_float(b, 5);
        House[b][hExitZ] = cache_get_row_float(b, 6);
        House[b][hCarX] = cache_get_row_float(b, 7);
        House[b][hCarY] = cache_get_row_float(b, 8);
        House[b][hCarZ] = cache_get_row_float(b, 9);
        House[b][hCarZ] = cache_get_row_float(b, 10);
        cache_get_row(b, 11, House[b][hOwner]);
        House[b][hCost] = cache_get_row_int(b, 12);
        House[b][hInt] = cache_get_row_int(b, 13);
        House[b][hVW] = cache_get_row_int(b, 14);
        House[b][hLock] = cache_get_row_int(b, 15);
        House[b][hKlass] = cache_get_row_int(b, 16);
    }
}
Find
Reply
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#8

15.04.2016, 15:52
Quote:
Originally Posted by Konstantinos
Посмотреть сообщение
It takes so much because you load 660 times the already loaded data. Do not use loop, the query itself selects ALL the data from the table.

EDIT: That's how it should be assuming hID is set to AUTO_INCREMENT.
pawn Код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses","");
pawn Код:
forward LoadHouses();
public LoadHouses()
{
    new rows = clamp(cache_get_row_count(server), 0, sizeof House - 1);
    for(new b; b != rows; ++b)
    {
        House[b][hID] = cache_get_row_int(b, 0);
        House[b][hEnterX] = cache_get_row_float(b, 1);
        House[b][hEnterY] = cache_get_row_float(b, 2);
        House[b][hEnterZ] = cache_get_row_float(b, 3);
        House[b][hExitX] = cache_get_row_float(b, 4);
        House[b][hExitY] = cache_get_row_float(b, 5);
        House[b][hExitZ] = cache_get_row_float(b, 6);
        House[b][hCarX] = cache_get_row_float(b, 7);
        House[b][hCarY] = cache_get_row_float(b, 8);
        House[b][hCarZ] = cache_get_row_float(b, 9);
        House[b][hCarZ] = cache_get_row_float(b, 10);
        cache_get_row(b, 11, House[b][hOwner]);
        House[b][hCost] = cache_get_row_int(b, 12);
        House[b][hInt] = cache_get_row_int(b, 13);
        House[b][hVW] = cache_get_row_int(b, 14);
        House[b][hLock] = cache_get_row_int(b, 15);
        House[b][hKlass] = cache_get_row_int(b, 16);
    }
}
with Pquery, not tquery like u said it still getting 47 seconds to load all houses
with Tquery right the same: 47-48 seconds.

Cant understand this sheeeit
Find
Reply
AmigaBlizzard
Huge Clucker
****
Posts: 319
Threads: 7
Joined: Jul 2012
Reputation: 0
#9

15.04.2016, 19:55
Do you still use this:
PHP код:
for(new i = 0; i < 661; i++) mysql_pquery(server, "SELECT * FROM houses", "LoadHouses","d",i); 
Or this:
PHP код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses",""); 
If you still use the first (a loop to load the entire table 662 times), then yes, 47 seconds is normal. Because you're loading 662 houses 662 times, that would be 438244 houses to load.

For the second, this should be loaded within one second as you only send 1 query instead of 662 queries.
The query already loads ALL houses from the table at once, there is no need to loop through each house separately and send a query for each house.
Find
Reply
BloodyRP
Big Clucker
***
Posts: 78
Threads: 7
Joined: May 2013
Reputation: 0
#10

15.04.2016, 19:59
Quote:
Originally Posted by AmigaBlizzard
Посмотреть сообщение
Do you still use this:
PHP код:
for(new i = 0; i < 661; i++) mysql_pquery(server, "SELECT * FROM houses", "LoadHouses","d",i); 
Or this:
PHP код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses",""); 
If you still use the first (a loop to load the entire table 662 times), then yes, 47 seconds is normal. Because you're loading 662 houses 662 times, that would be 438244 houses to load.

For the second, this should be loaded within one second as you only send 1 query instead of 662 queries.
The query already loads ALL houses from the table at once, there is no need to loop through each house separately and send a query for each house.
yeah. I load already second type.
Like:
Код:
mysql_tquery(server, "SELECT * FROM houses", "LoadHouses");
and:

Код:
forward LoadHouses();
public LoadHouses()
{
	new time = GetTickCount();
	for(new b; b != 660; ++b)
	{
	    House[b][hID] = cache_get_row_int(b, 0);
	    House[b][hEnterX] = cache_get_row_float(b, 1);
	    House[b][hEnterY] = cache_get_row_float(b, 2);
	    House[b][hEnterZ] = cache_get_row_float(b, 3);
	    House[b][hExitX] = cache_get_row_float(b, 4);
	    House[b][hExitY] = cache_get_row_float(b, 5);
	    House[b][hExitZ] = cache_get_row_float(b, 6);
	    House[b][hCarX] = cache_get_row_float(b, 7);
	    House[b][hCarY] = cache_get_row_float(b, 8);
	    House[b][hCarZ] = cache_get_row_float(b, 9);
	    House[b][hCarC] = cache_get_row_float(b, 10);
	    cache_get_row(b, 11, House[b][hOwner]);
	    House[b][hCost] = cache_get_row_int(b, 12);
	    House[b][hInt] = cache_get_row_int(b, 13);
	    House[b][hVW] = cache_get_row_int(b, 14);
	    House[b][hLock] = cache_get_row_int(b, 15);
	}
    printf("%d ms",GetTickCount()-time);
}]
this need ~45k ms = 45 seconds to load.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 2 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help