Quote:
Originally Posted by willbedie
PHP код:
cache_get_row_count(rows);
if(cache_num_rows() == 0)
{
mysql_format(Database, DB_Query, sizeof(DB_Query), "INSERT INTO `clans` (`ClanName`, `Leader`, `Official`) VALUES ('%e', '%e', '0')", clanname, GetName(playerid));
mysql_tquery(Database, DB_Query);
format(string, sizeof(string), "[SERVER]: You have created a unofficial clan named %s.", clanname);
SendClientMessage(playerid, COLOR_RED, string);
format(string, sizeof(string), "Clan Name: %s, Official: No", clanname);
SendClientMessage(playerid, COLOR_RED, string);
UserStats[playerid][Clan] = 1;
}
else
{
SendClientMessage(playerid, COLOR_RED, "[SERVER]: That clan name is already registered by someone else.");
}
|
1) No active cache. You did not execute any query and just try to get the amount of rows out of nowhere.
2) If any error occurs for whatever reason, it will not insert to database but you will notify the player that his clan was created successfully.
Quote:
Originally Posted by willbedie
PHP код:
CMD:createclan(cmdid, playerid, params[])
{
....
SaveClans();
return 1;
}
PHP код:
stock SaveClans()
{
for (new i = 1; i < MAX_CLANS; i ++)
{
SaveClan(i);
}
return 1;
}
stock SaveClan(id)
{
new query[800];
mysql_format(Database, query, sizeof(query), "UPDATE `clans` SET `ClanName` = '%e', `ClanColor` = '%e', `ClanSpawn` = '%e', `Leader` = '%e', `Official` = '%e', `Rank1` = '%e', `Rank2' = %e', `Rank3` = '%e', `Rank4` = '%e', `Rank5` = '%e' WHERE ClanID = '%i'",
ClanInfo[id][ClanName], ClanInfo[id][ClanColor], ClanInfo[id][ClanSpawn], ClanInfo[id][Leader], ClanInfo[id][Official], ClanInfo[id][Rank1], ClanInfo[id][Rank2], ClanInfo[id][Rank3], ClanInfo[id][Rank4], ClanInfo[id][Rank5], ClanInfo[id][ClanID]);
mysql_tquery(Database, query);
return 1;
}
|
Absolutely no reason for this.
1) You update every clan whenever a clan is created. What do other clans have to do with the one being created? Nothing at all.
2) Your loop starts from value 1. Why? Arrays start from index 0. This is utterly something very old scripts used and most new members do the same nowadays.
3) Your INSERT query is there to set any value you want. Executing an UPDATE query afterwards is meaningless.
4) Why do you have another table `ClanID`? The first column of the table `clans` should have been the `clanid`.
5) Again, in LoadClans. Why do you call cache functions when no active cache? It must be either AFTER mysql_query or in a callback set by mysql_tquery/mysql_pquery. Not before, not in random places. Also `clanid` will always be 0 and it won't retrieve all the rows but the first from the database. You need a loop there.
