Samp clans won't save / load - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Samp clans won't save / load (/showthread.php?tid=658091)

---

Samp clans won't save / load - solstice_ - 22.08.2018

Hello, i created a clan system with a few commands and a few functions but they won't save and load.

Here is the /createclan command:

So when a player creates a clan /createclan it's going to be official, an lead admin has to set it to official

here is the command: /setofficial

Now when i type this nothing updates to the database, here are the functions:

Just to let you know,

i put LoadClans(); OnGameModeInIt
i put SaveClans(); OnGameModeExit

---

Re: Samp clans won't save / load - victory88 - 23.08.2018

What does it say in the mysql log?
https://sampwiki.blast.hk/wiki/MySQL/R33#mysql_log

Also do not rely on OnGameModeExit

---

Re: Samp clans won't save / load - solstice_ - 23.08.2018

Can't send u the logs rn im on my phone, where do i put SaveClans(); tho?

---

Re: Samp clans won't save / load - Sew_Sumi - 23.08.2018

You should've kept this to the other thread as this will be much related to the issue you're facing in there.

SaveClans should be fired every 5-10 minutes or something, but more likely only when a new clan has been made, or a player from a clan does something that changes what the contents of the clan DB would have.

E.g. if they completed a mission, a DM, or deposited money into a clan safe, or such.


So in this sense, that function, should only be fired if the clan is created, leadership is changed, color is changed, or the rank names are messed with.



What is in the DB, what you are saving to the DB, and what's coming back out.

I'd hazard a guess that you've not got oddly formatted cells, which may make it look like it's not saving, as the output that's coming out is incorrect and stopping your setup working.

This can also occur on the creation of the initial clan, and even though you may not be seeing it, the result will, and it will come out garbled.




Try using printf and print everywhere. Output the results you are getting, and saving, to the log or the screen so you can see them.

Even change the variables in the rank command and see what it's actually able to hold. Instead of '0', a string should be able to be null, and I'd chuck in words, and numbers to see what comes back when you reload it, or output those to the log.

---

Re: Samp clans won't save / load - Calisthenics - 23.08.2018

1) No active cache. You did not execute any query and just try to get the amount of rows out of nowhere.
2) If any error occurs for whatever reason, it will not insert to database but you will notify the player that his clan was created successfully.

Absolutely no reason for this.
1) You update every clan whenever a clan is created. What do other clans have to do with the one being created? Nothing at all.
2) Your loop starts from value 1. Why? Arrays start from index 0. This is utterly something very old scripts used and most new members do the same nowadays.
3) Your INSERT query is there to set any value you want. Executing an UPDATE query afterwards is meaningless.
4) Why do you have another table `ClanID`? The first column of the table `clans` should have been the `clanid`.
5) Again, in LoadClans. Why do you call cache functions when no active cache? It must be either AFTER mysql_query or in a callback set by mysql_tquery/mysql_pquery. Not before, not in random places. Also `clanid` will always be 0 and it won't retrieve all the rows but the first from the database. You need a loop there.

---

Re: Samp clans won't save / load - solstice_ - 23.08.2018

Here are mysql logs:

---

Re: Samp clans won't save / load - Sew_Sumi - 23.08.2018

checking that log over could help you out...


You've mixed up your ' and ` on Rank 2 before it...

You're using ` ` and all of a sudden, rank 2 has an '.

---

Re: Samp clans won't save / load - solstice_ - 23.08.2018

omfg lol i didn't even notice that.. it happens everytime

---

Re: Samp clans won't save / load - Sew_Sumi - 23.08.2018

Just check where exactly it is, it's reporting rank 3, but it's in rank 2.

---

Re: Samp clans won't save / load - solstice_ - 23.08.2018

Yeah it's in rank 2 i've fixed it, but is there something wrong with LoadClans too?


because when i /createclan in-game it creates and the data inserts into mysql database but whenever i start the gamemode it says no clans were loaded from the database even tho there are tons of clans in the database.

---