[FilterScript] Singleplayer intro to Multiplayer
#6

Looked at the code and you really made this hard on yourself and made this pretty damn sloppy.

1.) Excessive TD's are very wasteful.

Code:
new Text:IntroText1[2];
new Text:IntroText2[2];                                                        
new Text:IntroText3[31];                                                       
new Text:IntroText4[38];                                                     
new Text:IntroText5[37];                                                        
new Text:IntroText6[34];                                                       
new Text:IntroText7[34];                                                       
new Text:IntroText8[31];                                                      
new Text:IntroText9[30];                                                      
new Text:IntroText10[3];
2.) You should have used object model textdraws.

3.) This is really funny when people do this obviously the player is connected if OnPlayerConnect() is called.

public OnPlayerConnect(playerid) {

pIntro[playerid] = 1; // We set player intro state 1 (1 will start to show player intro)
UpdatePlayerIntro(playerid); // We start player intro check

return 1; }

Code:
//============================================================================ > UpdatePlayerIntro

public UpdatePlayerIntro(playerid) {
	if(!IsPlayerConnected(playerid)) { return 1; }
Now I can see what you did that IN CASE a timer is still running but that isn't the way to do it because another player could connect and the timer would still trigger. You need to use KillTimer() in OnPlayerDisconnect(). There is almost never a need to use IsPlayerConnected(playerid) and if you do it should be for a good reason.

Other than that it does what it is supposed to do but isn't much more than a novelty in it's current state due to those excessive TD's which doesn't make it particularly viable for any real use.
Reply


Messages In This Thread
Singleplayer intro to Multiplayer - by lukica - 09.01.2017, 18:19
Re: Singleplayer intro to Multiplayer - by XBrianX - 09.01.2017, 18:26
Re: Singleplayer intro to Multiplayer - by Micko123 - 09.01.2017, 18:35
Re: Singleplayer intro to Multiplayer - by NV1D3ATD - 09.01.2017, 19:49
Re: Singleplayer intro to Multiplayer - by RyderX - 09.01.2017, 20:04
Re: Singleplayer intro to Multiplayer - by Pottus - 09.01.2017, 20:57
Respuesta: Singleplayer intro to Multiplayer - by Gles - 09.01.2017, 22:49
Re: Singleplayer intro to Multiplayer - by Freaksken - 10.01.2017, 05:41
Re: Singleplayer intro to Multiplayer - by cdoubleoper - 10.01.2017, 06:25
Re: Singleplayer intro to Multiplayer - by coool - 10.01.2017, 09:47
Re: Singleplayer intro to Multiplayer - by B4dSh33p - 10.01.2017, 10:03
Re: Singleplayer intro to Multiplayer - by QuaTTrO - 10.01.2017, 10:19
Re: Singleplayer intro to Multiplayer - by XBrianX - 10.01.2017, 10:53
Re: Singleplayer intro to Multiplayer - by lukica - 10.01.2017, 11:25
Re: Singleplayer intro to Multiplayer - by lukica - 10.01.2017, 11:27
Re: Singleplayer intro to Multiplayer - by DeitY - 10.01.2017, 16:37
Re: Singleplayer intro to Multiplayer - by Pr0GreSiVe - 11.01.2017, 00:32
Re: Singleplayer intro to Multiplayer - by SyS - 11.01.2017, 00:50
Re: Singleplayer intro to Multiplayer - by Ivan_Ino - 11.01.2017, 01:52
Re: Singleplayer intro to Multiplayer - by henkas - 11.01.2017, 11:01
Re: Singleplayer intro to Multiplayer - by darkhunter332 - 11.01.2017, 14:38
Re: Singleplayer intro to Multiplayer - by IllidanS4 - 11.01.2017, 15:55
Re: Singleplayer intro to Multiplayer - by NaS - 11.01.2017, 16:56
Re: Singleplayer intro to Multiplayer - by Rigel - 25.02.2017, 09:30
Re: Singleplayer intro to Multiplayer - by ElMaestro123 - 26.02.2017, 10:44
Respuesta: Singleplayer intro to Multiplayer - by OTACON - 06.03.2017, 09:57
Re: Singleplayer intro to Multiplayer - by vegaltasendai - 10.08.2017, 15:23
Re: Singleplayer intro to Multiplayer - by Astralis - 11.08.2017, 14:52
Re: Singleplayer intro to Multiplayer - by EmpireSk - 25.12.2017, 00:29
Re: Singleplayer intro to Multiplayer - by Daniielk - 25.12.2017, 02:19
Re: Singleplayer intro to Multiplayer - by RogueDrifter - 25.12.2017, 02:44
Re: Singleplayer intro to Multiplayer - by rfr - 25.12.2017, 08:55
Re: Singleplayer intro to Multiplayer - by Mitic0 - 22.07.2018, 01:38
Re: Singleplayer intro to Multiplayer - by Alexis17 - 06.10.2018, 06:18
Re: Singleplayer intro to Multiplayer - by Skinnz - 25.11.2018, 10:34
Re: Singleplayer intro to Multiplayer - by tandytanz - 01.01.2019, 19:27
Re: Singleplayer intro to Multiplayer - by N0FeaR - 01.01.2019, 22:38
Re: Singleplayer intro to Multiplayer - by Wherethescripters - 13.01.2019, 06:02

Forum Jump:


Users browsing this thread: 3 Guest(s)