[Gammix]

Quote:

Originally Posted by ****** They should! Currently most of those will crash as they don't even check if the player is VALID, let alone connected: pawn Code: GetPlayerDialogID(-1); // Crash Dialog_TotalPages(INVALID_PLAYER_ID); // Crash // etc...

Why would anyone even perform that function on id -1.
AND, i personally think people have habit to perform such checks like IsPlayerConnected, or maybe a range check... So i didn't bothered to add that! Though now it is done in R4.

All the functions having Dialog_ as prefix are internal functions, i don't recommend people to use them!

Quote:

Originally Posted by ****** pawn Code: stock Dialog_TotalPages(playerid) {         if((gPlayerTotalModels[playerid] >= MODELS_PER_PAGE) && (gPlayerTotalModels[playerid] % MODELS_PER_PAGE) == 0)         {                 return (gPlayerTotalModels[playerid] / MODELS_PER_PAGE);         }         else return (gPlayerTotalModels[playerid] / MODELS_PER_PAGE) + 1; } That is much more simply expressed as: pawn Code: stock Dialog_TotalPages(playerid) {         return ceildiv(gPlayerTotalModels[playerid], MODELS_PER_PAGE); } ceildiv Obviously with adequate connection checks.

Thats nice & short.

Quote:

Originally Posted by ****** Why are "Dialog_CreateGlobalTD()" and "Dialog_CreateGlobalButtonsTD()" stock and global? They shouldn't be stock because they are always used (they aren't API functions), and they shouldn't be global because they are purely internal (again, they aren't API functions).

Ok, that can be an alternative.
Why they shouldn't be global, i don't think so you need player textdraws for just a static display.

Quote:

Originally Posted by ****** Also, there are much better ways to hook the init functions now - both in terms of being script type agnostic, and using more modern ALS methods (applicable for your other callbacks too).

I don't know those new methods, And their benifits?


R4 - 10th April, 2015

• Add player connection check within the external functions
• Add double click feature for selecting models directly
• More shorter code!

Please download the latest version.