[FilterScript] I Feel i became better in scripting now :)
#7

It looks good, but again, the indentation really should be better (so you can remove the #pragma tabsize 0 too).
Also, ZCMD is much faster and easier to use then DCMD. When you use ZCMD you also don't have to use the '#pragma unused params'. Dnd there is SSCANF2 too, which is also better then the first SSCANF.
I also noticed you used 'strtok' in OnPlayerCommandText without doing something with it futher.
1- You shouldn't use STROK
2- When you use SSCANF(2), STRTOK isn't needed anymore.
And as last, DINI is very outdated and slow. You'd better use something as DJSON (also made by DraconBlue. Works almost the same as DINI) and Y_INI (which is harder to use then DJSON. I'd recommend you to use DJSON).
And I see this script is using the 'scriptfiles' folder, with more directories. In your .rar download you should include these folders: When a beginner is using this, his server will crash because the most beginners don't know about the scriptfiles.

Did you perhaps use some kind of (outdated) tutorial to make this?
Reply


Messages In This Thread

Forum Jump:


Users browsing this thread: 1 Guest(s)