[FilterScript] I Feel i became better in scripting now :)

[FilterScript] I Feel i became better in scripting now :) - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Filterscripts (https://sampforum.blast.hk/forumdisplay.php?fid=17)
+--- Thread: [FilterScript] I Feel i became better in scripting now :) (/showthread.php?tid=329867)

I Feel i became better in scripting now :) - [GF]Logic - 30.03.2012

Second Filter Script by me Eddy i wish you like it and please +Rep me if you like it

Information:

1- Login & Register System

2- CMDS : { setvip for rcon admin , viplocker for vip members }

3- things different { viplocker is used in a dialog and not at a certain place it can be used any where }

4- This [FS] is scripted using DCMD

Download :

Solid File
Paste Bin

Credits:

1- DracoBlue for Dini

2- My Teacher Mike_Peterson

3- Me the scripter Eddy

Re: I Feel i became better in scripting now :) - T0pAz - 30.03.2012

Please provide pastebin link in future.

Re: I Feel i became better in scripting now :) - [GF]Logic - 30.03.2012

Quote:

Originally Posted by T0pAz

Please provide pastebin link in future.

Done

Re: I Feel i became better in scripting now :) - [GF]Logic - 30.03.2012

Any one else ?

Re: I Feel i became better in scripting now :) - [FSaF]Jarno - 30.03.2012

The title should be changed to the name of this script

Re: I Feel i became better in scripting now :) - [GF]Logic - 30.03.2012

can you please say your opinion the script try it out or something

Re: I Feel i became better in scripting now :) - Kwarde - 30.03.2012

It looks good, but again, the indentation really should be better (so you can remove the #pragma tabsize 0 too).
Also, ZCMD is much faster and easier to use then DCMD. When you use ZCMD you also don't have to use the '#pragma unused params'. Dnd there is SSCANF2 too, which is also better then the first SSCANF.
I also noticed you used 'strtok' in OnPlayerCommandText without doing something with it futher.
1- You shouldn't use STROK
2- When you use SSCANF(2), STRTOK isn't needed anymore.
And as last, DINI is very outdated and slow. You'd better use something as DJSON (also made by DraconBlue. Works almost the same as DINI) and Y_INI (which is harder to use then DJSON. I'd recommend you to use DJSON).
And I see this script is using the 'scriptfiles' folder, with more directories. In your .rar download you should include these folders: When a beginner is using this, his server will crash because the most beginners don't know about the scriptfiles.

Did you perhaps use some kind of (outdated) tutorial to make this?

Re: I Feel i became better in scripting now :) - [GF]Logic - 30.03.2012

yes i found a tutorial so i learnt it and script this one but thanks

Re: I Feel i became better in scripting now :) - DonWade - 30.03.2012

Rep+ for effort , but u should take a look at this

https://sampforum.blast.hk/showthread.php?tid=273088

Re: I Feel i became better in scripting now :) - ViruZz - 30.03.2012

Looks good but messy, You still have the OnGameModeInit in there.

pawn Код:

51.
public OnGameModeInit()

 52.
{

 53.
        // Don't use these lines if it's a filterscript

 54.
        SetGameModeText("Blank Script");

 55.
        AddPlayerClass(0, 1958.3783, 1343.1572, 15.3746, 269.1425, 0, 0, 0, 0, 0, 0);

 56.
        return 1;

 57.
}