[LeeXx]

Hello so basically i'm a newbie in scripting i tried making these 2 simple cmd's, but it doesn't work for a reason. When i try to test it on my ID, it says Player is not connected.

Here is the codes for /sethp cmd:

Код:

CMD:sethp(playerid,params[])
{
	if(PlayerInfo[playerid][pAdmin]>1337)
	{
	new Float:Health;
	new PID;
	if(sscanf(params, "ud", PID, Health)) return SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /sethp [playerid] [health]");
	if(!IsPlayerConnected(PID)) return SendClientMessage(playerid, -1, "Player is not connected.");
	SetPlayerHealth(PID, Health);
	}
	else SendClientMessage(playerid, -1, "You are not authorized to use this command!");
	return 1;
}

And codes for /setarmour cmd:

Код:

CMD:setarmour(playerid,params[])
{
	if(PlayerInfo[playerid][pAdmin]>1337)
	{
	new float:Armour;
	new PID;
	if(sscanf(params,"ud",PID,Armour)) return SendClientMessage(playerid,COLOR_GRAD1,"USAGE: /setarmour [playerid] [armor]");
	if(!IsPlayerConnected(PID)) return SendClientMessage(playerid,COLOR_GRAD1,"Player is not connected.");
	SetPlayerArmour(playerid, Armour);
	}
	else SendClientMessage(playerid,-1,"You are not authorized to use this command!");
	return 1;
}

I get the same result for both CMD's, so i'm sure that i made something wrong but i cant find what is it...

[Kane]

Try removing "Float:Health" & "Float:Armor". You don't need the Float.

[ISmokezU]

Eh?

PHP код:

CMD:sethp(playerid,params[])
{
    new Float:Health, PID;
    if(PlayerInfo[playerid][pAdmin] > 1337) SendClientMessage(playerid, -1, "You are not authorized to use this command!");
    if(sscanf(params, "uf", PID, Health)) return SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /sethp [playerid] [health]");
    if(PID == INVALID_PLAYER_ID) return SendClientMessage(playerid, -1, "Player is not connected.");
    //else
    SetPlayerHealth(PID, Health);
    return 1;
}
CMD:setarmour(playerid, params[])
{
    new float:Armour, PID;
    if(PlayerInfo[playerid][pAdmin] > 1337) SendClientMessage(playerid,-1,"You are not authorized to use this command!");
    if(sscanf(params,"uf", PID, Armour)) return SendClientMessage(playerid,COLOR_GRAD1,"USAGE: /setarmour [playerid] [armor]");
    if(PID == INVALID_PLAYER_ID)  return SendClientMessage(playerid,COLOR_GRAD1,"Player is not connected.");
    //else
    SetPlayerArmour(PID, Armour);
    return 1;
} 


[jasperschellekens]

PHP код:

if(!IsPlayerConnected(PID)) 


This will display the message if the player is connected.

EDIT:

PHP код:

if(IsPlayerConnectedEx(PID)) return SendClientMessage(playerid,GREY,"Player is not connected"); 


[LeeXx]

I tried removing Flaot:health and armour, but nothing. And I thought this code

PHP код:

if(!IsPlayerConnected(PID)) 


will display the message if the player is not connected with this sign "!"?

[Tamer]

Quote:

Originally Posted by LeeXx I tried removing Flaot:health and armour, but nothing. And I thought this code PHP код: if(!IsPlayerConnected(PID))  will display the message if the player is not connected with this sign "!"?

! sign means NOT.

For example 1 != 2 one is NOT equal to two.

if(!IsPlayerConnected) if IsPlayer NOT connected.

[LeeXx]

So that means my codes are correct? Yet I still get the same result, when I try to /sethp [MyID] to test it, it shows the message ''Player is not connected''?

[jlalt]

well, probably you got old sscanf or smth, try replacing "u" with "i" or "d" also its Float: not float:

so

PHP код:

CMD:setarmour(playerid,params[])
{
    if(PlayerInfo[playerid][pAdmin]>1337)
    {
    new float:Armour;
    new PID;
    if(sscanf(params,"ud",PID,Armour)) return SendClientMessage(playerid,COLOR_GRAD1,"USAGE: /setarmour [playerid] [armor]");
    if(!IsPlayerConnected(PID)) return SendClientMessage(playerid,COLOR_GRAD1,"Player is not connected.");
    SetPlayerArmour(playerid, Armour);
    }
    else SendClientMessage(playerid,-1,"You are not authorized to use this command!");
    return 1;
} 


gotta be

PHP код:

CMD:setarmour(playerid,params[])
{
    if(PlayerInfo[playerid][pAdmin]>1337)
    {
    new Float:Armour;
    new PID;
    if(sscanf(params,"if",PID,Armour)) return SendClientMessage(playerid,COLOR_GRAD1,"USAGE: /setarmour [playerid] [armor]");
    if(!IsPlayerConnected(PID)) return SendClientMessage(playerid,COLOR_GRAD1,"Player is not connected.");
    SetPlayerArmour(PID, Armour);
    }
    else SendClientMessage(playerid,-1,"You are not authorized to use this command!");
    return 1;
} 


d,i for integers and u gets playerid by his name or by his id directly [ not supported by old sscanfs or supported but a bit bugged ]. and f for floats. so in your sscanf d has to be f as health and armour are Float values.

also

PHP код:

SetPlayerArmour(playerid, Armour); 


had to be

PHP код:

SetPlayerArmour(PID, Armour); 


[LeeXx]

Yeah it actually worked, thanks for explaining to me Jlalt. + rep my friend!

[Juvanii]

Download the latest version of sscanf from:
https://sampforum.blast.hk/showthread.php?tid=570927

PHP код:

CMD:sethp(playerid,params[])
{
    new health, targetid;
    if(PlayerInfo[playerid][pAdmin] < 1337) return SendClientMessage(playerid, -1, "You are not authorized to use this command!");
    if(sscanf(params, "ui", targetid, health)) return SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /sethp [playerid] [health]");
    if(!IsPlayerConnected(targetid)) return SendClientMessage(playerid, -1, "Player is not connected.");
    SetPlayerHealth(targetid, health);
    return 1;
}
CMD:setarmour(playerid,params[])
{
    new armour, targetid;
    if(PlayerInfo[playerid][pAdmin] < 1337) return SendClientMessage(playerid, -1, "You are not authorized to use this command!");
    if(sscanf(params, "ui", targetid, health)) return SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /setarmour [playerid] [armour]");
    if(!IsPlayerConnected(targetid)) return SendClientMessage(playerid, -1, "Player is not connected.");
    SetPlayerArmour(targetid, armour);
    return 1;
} 


EDIT: Too Late :))

[LeeXx]

Haha it's alright, thanks for your help anyways
I need that link xD