1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Filterscripts

Threaded Mode
[FilterScript] Deer Hunter Job
Kristall
Little Clucker
**
Posts: 10
Threads: 4
Joined: Mar 2018
Reputation: 0
#1

09.07.2018, 10:05
(JOB): Deer Hunter

Hello! I'm back with a new FS.

In this new FS, is a new job, inspired on Nephrite Servers (JADE/RUBY).


Commands / Money

- [/getjob] - to get Hunter Job
- [/quitjob] - give up
- [/work] - to start hunting

Money:
- if u kill Deep from a distance lower than 20m, u failed and you don't receive your money
- if u kill Deep from a distance between [20, 39]m, u will get $1000 + a random part of 500$ (u can edit that)
- if u kill Deep from a distance bigger than 40m, u will got a bonus in money


Video:

https://www.youtube.com/watch?v=VQcyGT6aDpQ


pastebin: https://pastebin.com/ydALKsMG

**sorry for last topic, i forgot to put pastebin and i screw up with tittle
***I will update the FS in few days, making deers move, making it harder to fire them
Find
Reply
CodeStyle175
Banned
Posts: 455
Threads: 29
Joined: Apr 2014
#2

10.07.2018, 16:25
again wtf is this shit?
why are you repeating useless code liks this?
PHP Code:
     if(PRESSED(KEY_WALK)) {
        if(Deep_Deer[playerid] == 1) {
            if(IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }
         }
     } 
can be done this
PHP Code:
if(Deep_Deer[playerid] == 1) {
        if(IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1 || 
        IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7){
            TogglePlayerControllable(playerid, 0);
            ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
            Deep_Deer[playerid] = 0;
            KillTimer(Meeters_BTWDeer[playerid]);
            Shoot_Deer[playerid] = 0;
            SetTimer("Done_Deer", 3500, false);
        }
    } 
Find
Reply
iNkyz
Little Clucker
**
Posts: 21
Threads: 4
Joined: Jun 2018
Reputation: 0
#3

11.07.2018, 16:23
Where did you get that weapon color lol!
Find
Reply
Kristall
Little Clucker
**
Posts: 10
Threads: 4
Joined: Mar 2018
Reputation: 0
#4

20.07.2018, 14:55
Quote:
Originally Posted by CodeStyle175
View Post
again wtf is this shit?
why are you repeating useless code liks this?
PHP Code:
     if(PRESSED(KEY_WALK)) {
        if(Deep_Deer[playerid] == 1) {
            if(IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4) {
                TogglePlayerControllable(playerid, 0);
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }else if(IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7) {
                ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
                TogglePlayerControllable(playerid, 0);
                Deep_Deer[playerid] = 0;
                KillTimer(Meeters_BTWDeer[playerid]);
                Shoot_Deer[playerid] = 0;
                SetTimer("Done_Deer", 3500, false);
            }
         }
     } 
can be done this
PHP Code:
if(Deep_Deer[playerid] == 1) {
        if(IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1 || 
        IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7){
            TogglePlayerControllable(playerid, 0);
            ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
            Deep_Deer[playerid] = 0;
            KillTimer(Meeters_BTWDeer[playerid]);
            Shoot_Deer[playerid] = 0;
            SetTimer("Done_Deer", 3500, false);
        }
    } 
Every time I finish doing an FS, I look around the code and realize that I could very easily reduce the number of lines exactly as you did. Thank you for your referral, and next time I'm going to try not to throw any unnecessary code lines. See' ya!
Find
Reply
DBZdabIt3Bro7
Banned
Posts: 65
Threads: 1
Joined: Sep 2017
#5

21.07.2018, 12:52
Quote:
Originally Posted by Kristall
View Post
Every time I finish doing an FS, I look around the code and realize that I could very easily reduce the number of lines exactly as you did. Thank you for your referral, and next time I'm going to try not to throw any unnecessary code lines. See' ya!
erm, that code is just even more terrible


PHP Code:
// global variable
new Float:deerLocations[][] = {
    { 0.0, 0.0, 0.0 } // id 0 (invalid) (ps: always start your IDs from 0 and up, if you need one that's invalid, refer to use negative 1 (-1)
    { 2046.7698, -799.4532, 126.7188 } // deer 1
    { 2021.1818, -494.0207, 76.1904 } // deer 2
    {1632.5769, -599.7444, 61.8233 } // deer 3
    { 1741.4386, -979.5817, 36.6115 } // deer 4
    { 2553.6780, -963.4338, 81.6685 } // deer 5
    { 2637.4963, -380.2195, 57.9261 } // deer 6
    { 2406.9773, -403.4681, 72.1762 } // deer 7
};
// local execution
    if(Deep_Deer[playerid] != 1)
        return false;
    
    if(IsPlayerInRangeOfPoint(playerid, 3.5, deerLocations[Deer[playerid][0], deerLocations[Deer[playerid][1], deerLocations[Deer[playerid][2])) { 
        TogglePlayerControllable(playerid, 0); 
        ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0); 
        Deep_Deer[playerid] = 0; 
        Shoot_Deer[playerid] = 0; 
        KillTimer(Meeters_BTWDeer[playerid]); 
        SetTimer("Done_Deer", 3500, false); 
    } 
also for hte love of god, use line breaks.




for future releases, don't release anything unless the code has been optimized for best performance. i haven't checked the code at all, but just seeing this was tearing my eyes. gl.


_________________
Quote:
Originally Posted by CodeStyle175
View Post
again wtf is this shit?
PHP Code:
if(Deep_Deer[playerid] == 1) {
        if(IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1 || 
        IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6 ||
        IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7){
            TogglePlayerControllable(playerid, 0);
            ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
            Deep_Deer[playerid] = 0;
            KillTimer(Meeters_BTWDeer[playerid]);
            Shoot_Deer[playerid] = 0;
            SetTimer("Done_Deer", 3500, false);
        }
    } 
no, that's not how math queries work, you're asking the server:
if (player is in range of coord) and (variable deer is x) or (player is in range of coord) and (variable deer is x)
that's to say, if player is in range of coord and variable deer isn't x but player also is in range of second coord, then do this. (this would ofc be looped several times) and in the end your math query won't make any sense (the if statement) so to make your code actually run properly (to be noticed, this kind of if statement is not recommended and is bad practice.)
PHP Code:
if(Deep_Deer[playerid] == 1) {
        if((IsPlayerInRangeOfPoint(playerid, 3.5, 2046.7698, -799.4532, 126.7188) && Deer[playerid] == 1) || 
        (IsPlayerInRangeOfPoint(playerid, 3.5, 2021.1818, -494.0207, 76.1904) && Deer[playerid] == 2) ||
        (IsPlayerInRangeOfPoint(playerid, 3.5, 1632.5769, -599.7444, 61.8233) && Deer[playerid] == 3) ||
        (IsPlayerInRangeOfPoint(playerid, 3.5, 1741.4386, -979.5817, 36.6115) && Deer[playerid] == 4) ||
        (IsPlayerInRangeOfPoint(playerid, 3.5, 2553.6780, -963.4338, 81.6685) && Deer[playerid] == 5) ||
        (IsPlayerInRangeOfPoint(playerid, 3.5, 2637.4963, -380.2195, 57.9261) && Deer[playerid] == 6) ||
        (IsPlayerInRangeOfPoint(playerid, 3.5, 2406.9773, -403.4681, 72.1762) && Deer[playerid] == 7)){
        TogglePlayerControllable(playerid, 0);
        ApplyAnimation(playerid, "BOMBER", "BOM_Plant", 4.1, 1, 1, 1, 1, 1, 0);
        Deep_Deer[playerid] = 0;
        KillTimer(Meeters_BTWDeer[playerid]);
        Shoot_Deer[playerid] = 0;
        SetTimer("Done_Deer", 3500, false);
    }
} 
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Filterscripts