[AfiqIqbal]

I was trying to fix a bug when player put "%" symbol in a dialog it will crash the server

OnDialogResponse :

PHP код:

if(dialogid == DIALOG_STREAMBOX)
    {
        new string[MAX_PLAYERS];
        if(response)
        {
            for(new i = 0; i < MAX_PLAYERS; i++)
               {
                   for(new s; s < strlen(inputtext); s++)
                   {
                    if(inputtext == "%")
                    {
                         inputtext = "#";
                    }
                    format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(playerid), inputtext);
                    SendClientMessage(i, 0x00FFCCAA, string);
                       StopAudioStreamForPlayer(i);
                      SendClientMessage(i, -1, "================================");
                    PlayAudioStreamForPlayer(i, inputtext);
                     SendClientMessage(i, -1, "================================");
                      SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");
                }
              }
        }
        return 1;
    } 


But when I was trying to compile the script it says :

Код:

C:\Users\USER\Desktop\Server Scripts\GM\MYGM.pwn(2131) : error 033: array must be indexed (variable "inputtext")
C:\Users\USER\Desktop\Server Scripts\GM\MYGM.pwn(2133) : error 046: unknown array size (variable "inputtext")
C:\Users\USER\Desktop\Server Scripts\GM\MYGM.pwn(2133) : warning 215: expression has no effect
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


2 Errors.

I've tried everything that I know, can you guys help me with this error?

[Steve57]

Add [s] after inputtext

[Kane]

You okay Steve?

OP:

PHP код:

if(inputtext[s] == '%')
{
     inputtext[s] = '#';
} 


[Kraeror]

Try this:

PHP код:

if(dialogid == DIALOG_STREAMBOX)
{
    new string[MAX_PLAYERS];
    if(response)
    {
        for(new i = 0; i < MAX_PLAYERS; i++)
        {
            if(strlen(inputtext) == "%")
            {
                 strlen(inputtext) = "#";
            }
            format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(playerid), inputtext);
            SendClientMessage(i, 0x00FFCCAA, string);
            StopAudioStreamForPlayer(i);
            SendClientMessage(i, -1, "================================");
            PlayAudioStreamForPlayer(i, inputtext);
            SendClientMessage(i, -1, "================================");
            SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");
          }
    }
    return 1;
} 


[AfiqIqbal]

Quote:

Originally Posted by Arthur Kane You okay Steve? OP: PHP код: if(inputtext[s] == '%') {      inputtext[s] = '#'; }

Nahh .. it's not working mate.

[AfiqIqbal]

Quote:

Originally Posted by Kraeror Try this: PHP код: if(dialogid == DIALOG_STREAMBOX) {     new string[MAX_PLAYERS];     if(response)     {         for(new i = 0; i < MAX_PLAYERS; i++)         {             if(strlen(inputtext) == "%")             {                  strlen(inputtext) = "#";             }             format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(playerid), inputtext);             SendClientMessage(i, 0x00FFCCAA, string);             StopAudioStreamForPlayer(i);             SendClientMessage(i, -1, "================================");             PlayAudioStreamForPlayer(i, inputtext);             SendClientMessage(i, -1, "================================");             SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");           }     }     return 1; }

Код:

	
Код:
	
C:\Users\USER\Desktop\Server Scripts\GM\MYGM(2131) : error 033: array must be indexed (variable "inputtext")
C:\Users\USER\Desktop\Server Scripts\GM\MYGM(2133) : error 022: must be lvalue (non-constant)
C:\Users\USER\Desktop\Server Scripts\GM\MYGM(2133) : warning 215: expression has no effect
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


2 Errors.

[Kane]

What part didn't work? Did you get an error?

[FuNkYTheGreat]

PHP код:

if(dialogid == DIALOG_STREAMBOX)
    {
        new string[MAX_PLAYERS];
        if(response)
        {
            for(new i = 0; i < MAX_PLAYERS; i++)
               {
                   format(string,sizeof(string),"%s",str_replace("%", "#",inputtext));
                       StopAudioStreamForPlayer(i);
                      PlayAudioStreamForPlayer(i, string);
                      format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(playerid), inputtext);
                    SendClientMessage(i, 0x00FFCCAA, string);
                      SendClientMessage(i, -1, "================================");
                     SendClientMessage(i, -1, "================================");
                      SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");
                }
              }
        }
        return 1;
    } 


and for the str_replace function use this one !
https://github.com/GRGServer/SAMP/bl...tr_replace.inc

[OsmanMalagic]

PHP код:

if(dialogid == DIALOG_STREAMBOX)
{
    new string[MAX_PLAYERS];
     if(response)
      {
         if(strfind(inputtext, "#", true) != -1) return SCM(playerid, COLOR_GREY, "Not supported!");
         foreach(Player, i)
         {
             format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(i), inputtext);
              SendClientMessage(i, 0x00FFCCAA, string);
               StopAudioStreamForPlayer(i);
            PlayAudioStreamForPlayer(i, inputtext);
            SendClientMessage(i, -1, "================================");
             SendClientMessage(i, -1, "================================");
              SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");
        }
    }
    return 1;
} 


[AfiqIqbal]

Quote:

Originally Posted by FuNkYTheGreat PHP код: if(dialogid == DIALOG_STREAMBOX)     {         new string[MAX_PLAYERS];         if(response)         {             for(new i = 0; i < MAX_PLAYERS; i++)                {                    format(string,sizeof(string),"%s",str_replace("%", "#",inputtext));                        StopAudioStreamForPlayer(i);                       PlayAudioStreamForPlayer(i, string);                       format(string, sizeof(string), "[DEEJAY] %s have play a song from | Url: %s", IsPlayerName(playerid), inputtext);                     SendClientMessage(i, 0x00FFCCAA, string);                       SendClientMessage(i, -1, "================================");                      SendClientMessage(i, -1, "================================");                       SendClientMessage(i, 0x00FF99AA, "Use /stopmusic if you want to stop the song from playing");                 }               }         }         return 1;     }  and for the str_replace function use this one ! https://github.com/GRGServer/SAMP/bl...tr_replace.inc

Tested it, still crash my server when I type % into the dialog