[Loinal]

PHP код:

CMD:setdblevel(playerid, params[])
{
    new account[24], Query[300], bString[128], level, Cache:GetCache, rows;
    if(pData[playerid][Admin] == 10)
    {
        if(sscanf(params, "s[24]i", account,level)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /Setdblevel [Account] [Level]");
        if(strlen(account) > 24) return SendClientMessage(playerid, COLOR_RED, "ERROR: Player name cannot exceed 24 characters!");
        if(level == 2 || level > 10 || level < 1 || level == 0) return SendClientMessage(playerid, red, "ERROR: Invalid Level [Levels 3 to 10 or 1]");
        format(Query, sizeof(Query), "SELECT * FROM `players` WHERE `Username` = '%s'", account);
        GetCache = mysql_query(mysql, Query);
        cache_get_row_count(rows);
        if(rows == 1)
        {
            format(Query, sizeof(Query), "UPDATE `players` SET Admin=%d WHERE `Username` = '%s'", level, account);
            mysql_tquery(mysql, Query);
            format(bString, sizeof(bString), "* You have succesfully set %s's level to %d.", account, level);
            SendClientMessage(playerid, -1, bString);
        }
        else
        {
            format(bString, sizeof(bString), "ERROR: Name %s doesn't exists in the database!", account);
            return SendClientMessage(playerid, red, bString);
        }
        cache_delete(GetCache);
    }
    else return SendClientMessage(playerid, COLOR_YELLOW, "Sorry, you are not high enough level to use this command.");
    return 1;
}
CMD:query(playerid, params[])
{
    new account[24], Query[300], bString[128], level,kills,deaths,tokens,cash,racewon, Cache:GetCache, rows;
    if(pData[playerid][Admin] == 10)
    {
        if(sscanf(params, "s[24]iiiiii", account,level)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /query [Account] [Level] [Kills] [Deaths] [Tokens] [Cash] [RaceWon]");
        if(strlen(account) > 24) return SendClientMessage(playerid, COLOR_RED, "ERROR: Player name cannot exceed 24 characters!");
        if(level == 2 || level > 10 || level < 1 || level == 0) return SendClientMessage(playerid, red, "ERROR: Invalid Level [Levels 3 to 10 or 1]");
        format(Query, sizeof(Query), "SELECT * FROM `players` WHERE `Username` = '%s'", account);
        GetCache = mysql_query(mysql, Query);
        cache_get_row_count(rows);
        if(rows == 1)
        {
            format(Query, sizeof(Query), "UPDATE `players` SET Admin=%d, Kills=%d,Deaths=%d,Tokens=%d,Money=%d,RaceWon=%d WHERE `Username` = '%s'", level,kills,deaths,tokens,cash,racewon,account);
            mysql_tquery(mysql, Query);
            format(bString, sizeof(bString), "* You have succesfully set %s's level to %d | Kills to %d | Deaths to %d | Tokens to %d | Money to $%d | RaceWon to %d.", account, level,kills,deaths,tokens,cash,racewon);
            SendClientMessage(playerid, -1, bString);
        }
        else
        {
            format(bString, sizeof(bString), "ERROR: Name %s doesn't exists in the database!", account);
            return SendClientMessage(playerid, red, bString);
        }
        cache_delete(GetCache);
    }
    else return SendClientMessage(playerid, COLOR_YELLOW, "Sorry, you are not high enough level to use this command.");
    return 1;
} 


Both commands are not working it doesn't change any thing on the player data

[Loinal]

Server logs

Код:

[22:20:29] sscanf warning: Strings without a length are deprecated, please add a destination size.
[22:20:29] sscanf warning: Format specifier does not match parameter count.
[22:20:31] sscanf warning: Strings without a length are deprecated, please add a destination size.
[22:20:31] sscanf warning: Format specifier does not match parameter count.

[Logic_]

Use mysql_format to format mysql queries!

[AndreiWow]

Use %e instead of %s to escape strings

[Loinal]

Quote:

Originally Posted by Logic_ Use mysql_format to format mysql queries!

Instead of?

Quote:

Originally Posted by AndreiWow Use %e instead of %s to escape strings

Instead of?

[AndreiWow]

Wasn't I clear enough?


Use %e instead of %s to escape strings

In your mysql queries use %e for strings.
Like

.... WHERE Username = '%e'

[Loinal]

Quote:

Originally Posted by AndreiWow Wasn't I clear enough? Use %e instead of %s to escape strings In your mysql queries use %e for strings. Like .... WHERE Username = '%e'

PHP код:

CMD:setdblevel(playerid, params[])
{
    new account[24], Query[300], bString[128], level, Cache:GetCache, rows;
    if(pData[playerid][Admin] == 10)
    {
        if(sscanf(params, "s[24]i", account,level)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /Setdblevel [Account] [Level]");
        if(strlen(account) > 24) return SendClientMessage(playerid, COLOR_RED, "ERROR: Player name cannot exceed 24 characters!");
        if(level == 2 || level > 10 || level < 1 || level == 0) return SendClientMessage(playerid, red, "ERROR: Invalid Level [Levels 3 to 10 or 1]");
        format(Query, sizeof(Query), "SELECT * FROM `players` WHERE `Username` = '%e'", account);
        GetCache = mysql_query(mysql, Query);
        cache_get_row_count(rows);
        if(rows == 1)
        {
            format(Query, sizeof(Query), "UPDATE `players` SET Admin=%d WHERE `Username` = '%e'", level, account);
            mysql_tquery(mysql, Query);
            format(bString, sizeof(bString), "* You have succesfully set %s's level to %d.", account, level);
            SendClientMessage(playerid, -1, bString);
        }
        else
        {
            format(bString, sizeof(bString), "ERROR: Name %s doesn't exists in the database!", account);
            return SendClientMessage(playerid, red, bString);
        }
        cache_delete(GetCache);
    }
    else return SendClientMessage(playerid, COLOR_YELLOW, "Sorry, you are not high enough level to use this command.");
    return 1;
}
CMD:query(playerid, params[])
{
    new account[24], Query[300], bString[128], level,kills,deaths,tokens,cash,racewon, Cache:GetCache, rows;
    if(pData[playerid][Admin] == 10)
    {
        if(sscanf(params, "s[24]iiiiii", account,level)) return SendClientMessage(playerid, COLOR_RED, "USAGE: /query [Account] [Level] [Kills] [Deaths] [Tokens] [Cash] [RaceWon]");
        if(strlen(account) > 24) return SendClientMessage(playerid, COLOR_RED, "ERROR: Player name cannot exceed 24 characters!");
        if(level == 2 || level > 10 || level < 1 || level == 0) return SendClientMessage(playerid, red, "ERROR: Invalid Level [Levels 3 to 10 or 1]");
        format(Query, sizeof(Query), "SELECT * FROM `players` WHERE `Username` = '%e'", account);
        GetCache = mysql_query(mysql, Query);
        cache_get_row_count(rows);
        if(rows == 1)
        {
            format(Query, sizeof(Query), "UPDATE `players` SET Admin=%d, Kills=%d,Deaths=%d,Tokens=%d,Money=%d,RaceWon=%d WHERE `Username` = '%e'", level,kills,deaths,tokens,cash,racewon,account);
            mysql_tquery(mysql, Query);
            format(bString, sizeof(bString), "* You have succesfully set %s's level to %d | Kills to %d | Deaths to %d | Tokens to %d | Money to $%d | RaceWon to %d.", account, level,kills,deaths,tokens,cash,racewon);
            SendClientMessage(playerid, -1, bString);
        }
        else
        {
            format(bString, sizeof(bString), "ERROR: Name %s doesn't exists in the database!", account);
            return SendClientMessage(playerid, red, bString);
        }
        cache_delete(GetCache);
    }
    else return SendClientMessage(playerid, COLOR_YELLOW, "Sorry, you are not high enough level to use this command.");
    return 1;
} 


Now when i type my name he can't get my name it says that it doesn't exists

[AndreiWow]

What version is your mysql? Also use mysql_format for %e to work.

[Vince]

Just do the "set level" query and then check the results afterwards with affected_rows. If affected rows is 0 then the user doesn't exist, or they already have that level. If it returns 1 it was a success. If it returns more than 1 then your database is screwed up because then there are multiple users with the same name.

[Loinal]

Quote:

Originally Posted by AndreiWow What version is your mysql? Also use mysql_format for %e to work.

Mysql r41 and should i check by format and set by mysql_format