1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Timer freeze bug + lag
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#1

02.05.2017, 14:43
Hello!
I have a pretty bad bug in server , when i drive a vehicle ( mostly ) a public function freezes, i use a timer to call it each 1010 miliseconds, it's Checkvehinfo ( for realtime speed, odometer, fuel, status + auto car fix for admins )
so when it freezes it doesn't auto fix anymore and speed stops at a number ( not always but mostly )
when i checked server log i found this error detected by crashdetect every second ( 1010 ms ):
Код:
[16:30:03] [debug] AMX backtrace:
[16:30:03] [debug] #0 0010987c in public Checkvehinfo () from Blast.amx
[16:30:04] [debug] Run time error 4: "Array index out of bounds"
[16:30:04] [debug]  Accessing element at negative index -1
***** after 1 sec *****
[16:30:04] [debug] AMX backtrace:
[16:30:04] [debug] #0 0010987c in public Checkvehinfo () from Blast.amx
[16:30:05] [debug] Run time error 4: "Array index out of bounds"
[16:30:05] [debug]  Accessing element at negative index -1
server log is fully spammed xD,
here is the public function :
PHP код:
public Checkvehinfo()
{
    foreach(Player,i)
    {
        if(IsPlayerConnected(i))
           {
            if(PlayerInfo[i][pAdmin] >= 1) RepairVehicle(GetPlayerVehicleID(i));
            new carid = HireCar[i];
               if(GetPlayerState(i) == PLAYER_STATE_DRIVER)
               {
                   new vehicle = GetPlayerVehicleID(i),
                 spe = Carspeed(i);
                new str1[128],str2[128],str3[128],str4[128],str5[128],str6[128];
                PlayerTextDrawShow(i, Speedd[i]);
                format(str1,sizeof(str1)," Speed: ~y~%d Km/h",spe);
                PlayerTextDrawSetString(i, Speedd[i], str1); // sa facem si la bicicleta
                if(SwitchKey[i] == 2 && gCarLock[carid] == 1)
                {
                       PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, carlocked[i]);
                      format(str3,sizeof(str3),"~y~LOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str3);
                }
                if(SwitchKey[i] == 2 && gCarLock[carid] == 0)
                {
                       PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, carlocked[i]);
                    format(str3,sizeof(str3), "UNLOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str3);
                }
                if(IsABike(vehicle) && SwitchKey[i] != 2)
                {
                    PlayerTextDrawShow(i, Speedd[i]);
                    format(str1,sizeof(str1)," Speed: ~y~%d Km/h",spe);
                    PlayerTextDrawSetString(i, Speedd[i], str1);
                    PlayerTextDrawShow(i, bikeunlocked[i]);
                    format(str6,sizeof(str6), "UNLOCKED");
                    PlayerTextDrawSetString(i, bikeunlocked[i], str6);
                }
                else if(!IsABike(vehicle) && !OwnedVeh(vehicle) && SwitchKey[i] != 2)
                {
                    PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, unlocked[i]);
                    format(str6,sizeof(str6), "UNLOCKED");
                    PlayerTextDrawSetString(i, unlocked[i], str6);
                }
                if(OwnedVeh(vehicle) != 0 && !IsAPlane(vehicle) && !IsABike(vehicle) && SwitchKey[i] != 2)
                {
                       PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, Odom[i]);
                    format(str3,sizeof(str3),"Odometer: ~y~%.0fKM",CarInfo[OwnedVeh(vehicle)][cKM]);
                    PlayerTextDrawSetString(i, Odom[i], str3);
                }
                if(OwnedVeh(vehicle) != 0 && CarInfo[OwnedVeh(vehicle)][cLock] == 0 && SwitchKey[i] != 2)
                {
                    PlayerTextDrawShow(i, carlocked[i]);
                    format(str4,sizeof(str4),"UNLOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str4);
                }
                else if(OwnedVeh(vehicle) != 0 && CarInfo[OwnedVeh(vehicle)][cLock] == 1 && SwitchKey[i] != 2)
                {
                    PlayerTextDrawShow(i, carlocked[i]);
                    format(str5,sizeof(str5),"~y~LOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str5);
                }
            }
            else if(GetPlayerState(i) == PLAYER_STATE_PASSENGER)
               {
                   new count;
                   foreach(Player, x)
                {
                    if(GetPlayerState(x) == PLAYER_STATE_PASSENGER)
                       {
                           if(GetPlayerVehicleID(x) == GetPlayerVehicleID(i))
                           {
                               count ++;
                        }
                    }
                    if(count >= 1)
                    {
                        new vehicle = GetPlayerVehicleID(i),
                            spe = Carspeed(i);
                            new str1[128],str2[128],str3[128],str4[128],str5[128],str6[128];
                        PlayerTextDrawShow(i, Speedd[i]);
                        format(str1,sizeof(str1)," Speed: ~y~%d Km/h",spe);
                        PlayerTextDrawSetString(i, Speedd[i], str1);
                        if(SwitchKey[i] == 2 && gCarLock[carid] == 1)
                        {
                               PlayerTextDrawShow(i, Fuell[i]);
                            format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                            PlayerTextDrawSetString(i, Fuell[i], str2);
                            PlayerTextDrawShow(i, carlocked[i]);
                              format(str3,sizeof(str3),"~y~LOCKED");
                            PlayerTextDrawSetString(i, carlocked[i], str3);
                        }
                        if(SwitchKey[i] == 2 && gCarLock[carid] == 0)
                        {
                               PlayerTextDrawShow(i, Fuell[i]);
                            format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                            PlayerTextDrawSetString(i, Fuell[i], str2);
                            PlayerTextDrawShow(i, carlocked[i]);
                            format(str3,sizeof(str3), "UNLOCKED");
                            PlayerTextDrawSetString(i, carlocked[i], str3);
                        }
                        if(!IsABike(vehicle) && SwitchKey[i] != 2) // trebuie sa facem alt tw pt bike la unlcoked?da, sa l
                        {
                            PlayerTextDrawShow(i, Fuell[i]);
                            format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                            PlayerTextDrawSetString(i, Fuell[i], str2);
                            format(str4,sizeof(str4),"UNLOCKED");
                            PlayerTextDrawShow(i, unlocked[i]);
                            format(str6,sizeof(str6), "UNLOCKED");
                            PlayerTextDrawSetString(i, unlocked[i], str6);
                        }
                        if(OwnedVeh(vehicle) != 0 && !IsAPlane(vehicle) && SwitchKey[i] != 2)
                        {
                            PlayerTextDrawShow(i, Odom[i]);
                            format(str3,sizeof(str3),"Odometer: ~y~%.0fKM",CarInfo[OwnedVeh(vehicle)][cKM]);
                            PlayerTextDrawSetString(i, Odom[i], str3);
                        }
                        if(OwnedVeh(vehicle) != 0 && CarInfo[OwnedVeh(vehicle)][cLock] == 0 && SwitchKey[i] != 2)
                        {
                            PlayerTextDrawShow(i, carlocked[i]);
                            format(str4,sizeof(str4),"UNLOCKED");
                            PlayerTextDrawSetString(i, carlocked[i], str4);
                        }
                        else if(OwnedVeh(vehicle) != 0 && CarInfo[OwnedVeh(vehicle)][cLock] == 1 && SwitchKey[i] != 2)
                        {
                            PlayerTextDrawShow(i, carlocked[i]);
                            format(str5,sizeof(str5),"~y~LOCKED");
                            PlayerTextDrawSetString(i, carlocked[i], str5);
                        }
                    }
                    else if(count < 1)
                    {
                        PlayerTextDrawHide(i, Fuell[i]);
                           PlayerTextDrawHide(i, Speedd[i]);
                           PlayerTextDrawHide(i, carlocked[i]);
                           PlayerTextDrawHide(i, Odom[i]);
                           PlayerTextDrawHide(i, unlocked[i]);
                    }
                }
            }
            else if(GetPlayerState(i) != PLAYER_STATE_DRIVER && GetPlayerState(i) != PLAYER_STATE_PASSENGER)
            {
                   PlayerTextDrawHide(i, Fuell[i]);
                PlayerTextDrawHide(i, Speedd[i]);
                PlayerTextDrawHide(i, carlocked[i]);
                PlayerTextDrawHide(i, Odom[i]);
                PlayerTextDrawHide(i, unlocked[i]);
                PlayerTextDrawHide(i, bikeunlocked[i]);
            }
        }
    }
    return 1;
} 
thanks, i apperciate any kind of help/advice.
Find
Reply
iLearner
Gangsta
****
Posts: 579
Threads: 18
Joined: Apr 2017
Reputation: 0
#2

02.05.2017, 14:48
Compile with debud flag -d3 and get the exact line for that thing.
Find
Reply
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#3

02.05.2017, 15:13
how? ( sorry for noob question )
Find
Reply
SyS
High-roller
*****
Posts: 1,939
Threads: 11
Joined: Oct 2015
Reputation: 0
#4

02.05.2017, 15:15
https://github.com/Zeex/samp-plugin-...ith-debug-info
Find
Reply
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#5

02.05.2017, 15:21
Ok i'll edit the reply with debug results when it's compiled. ( 68k lines xD )
Find
Reply
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#6

02.05.2017, 15:33
it won't compile ( yet )
EDIT: Pawno isn't responding for over 10mins
Find
Reply
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#7

02.05.2017, 16:03
Here is it ( finally )

The text that isn't appearing:
Код:
(153504 bytes)
Find
Reply
iLearner
Gangsta
****
Posts: 579
Threads: 18
Joined: Apr 2017
Reputation: 0
#8

02.05.2017, 16:05
Drive a vehicle... and paste the text here when it appears in console.
Find
Reply
YouHack
Banned
Posts: 293
Threads: 20
Joined: Jan 2017
#9

02.05.2017, 16:38
Now i understood you...
here's the output:
Код:
[20:23:06] [debug] AMX backtrace:
[20:23:06] [debug] #0 001520c0 in public Checkvehinfo () at C:\Documents and Settings\NoName\Bureau\rpg\gamemodes\Blast.pwn:20335
[20:23:08] [debug] Run time error 4: "Array index out of bounds"
[20:23:08] [debug]  Accessing element at negative index -1
[20:23:08] [debug] AMX backtrace:
[20:23:08] [debug] #0 001520c0 in public Checkvehinfo () at C:\Documents and Settings\NoName\Bureau\rpg\gamemodes\Blast.pwn:20335
[20:23:11] ADMIN: Done
And here is the line 20335 :
PHP код:
public Checkvehinfo()
{
    foreach(Player,i)
    {
        if(IsPlayerConnected(i))
           {
            if(PlayerInfo[i][pAdmin] >= 1) RepairVehicle(GetPlayerVehicleID(i));
            new carid = HireCar[i];
               if(GetPlayerState(i) == PLAYER_STATE_DRIVER)
               {
                   new vehicle = GetPlayerVehicleID(i),
                 spe = Carspeed(i);
                new str1[128],str2[128],str3[128],str4[128],str5[128],str6[128];
                PlayerTextDrawShow(i, Speedd[i]);
                format(str1,sizeof(str1)," Speed: ~y~%d Km/h",spe);
                PlayerTextDrawSetString(i, Speedd[i], str1);
      /* ---> */if(SwitchKey[i] == 2 && gCarLock[carid] == 1)
                {
                       PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, carlocked[i]);
                      format(str3,sizeof(str3),"~y~LOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str3);
                }
                if(SwitchKey[i] == 2 && gCarLock[carid] == 0)
                {
                       PlayerTextDrawShow(i, Fuell[i]);
                    format(str2,sizeof(str2),"Fuel: ~y~%d", Gas[vehicle]);
                    PlayerTextDrawSetString(i, Fuell[i], str2);
                    PlayerTextDrawShow(i, carlocked[i]);
                    format(str3,sizeof(str3), "UNLOCKED");
                    PlayerTextDrawSetString(i, carlocked[i], str3);
                } ... 
Find
Reply
SyS
High-roller
*****
Posts: 1,939
Threads: 11
Joined: Oct 2015
Reputation: 0
#10

02.05.2017, 16:50
PHP код:
new carid = HireCar[i]; 
it seems like this providing -1 value to to carid. You should either make an exception statement for this situation (value becoming negative) can be achieved using a simple if statement. Or you have to fix the logic you implemented there.

Further more:
Update to latest foreach
foreach iterates through connected players so checking the player is connected is not required
don't declare variables inside the loop structure.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help