[Melktert]

Can someone please help me with this, if there are 2 admins online it only shows 1, and it does nothing if there are no admins online...

PHP код:

CMD:admins(playerid, params[])
{
    new adminstring[128];
    if(IsPlayerConnected(playerid))
    {
      for (new i = 0; i < MAX_PLAYERS; i++)
      {
        if(IsPlayerConnected(i))
        {
          if(PlayerInfo[i][pAdmin] > 0)
          {
            format(adminstring, sizeof(adminstring),"{FFFFFF}%s%s {FFFF00}[ID:%d]{FFFFFF}\n", adminstring, PlayerName(i), i);
          }
        }
      }
    ShowPlayerDialog(playerid,DIALOG_ONLINEADMINS,DIALOG_STYLE_MSGBOX,"Online admins",adminstring,"Close","");
    return 1;
    }
} 


[Sew_Sumi]

You don't need to check if playerid is connected.

Which admin is it showing, the lower ID, or the higher one?

And when none are online, is it showing anything at all, or is it coming up with the dialog box?

[DarkSkull]

Like Sew_Sumi said, You don't need to check if the playerid is connected.

PHP код:

CMD:admins(playerid, params[])
{
    new adminstring[256],tempstr[128], admins = 0;
    for (new i = 0; i < MAX_PLAYERS; i++) {
        if(IsPlayerConnected(i))
        {
          if(PlayerInfo[i][pAdmin] > 0)
          {
            format(tempstr, sizeof(tempstr),"{FFFFFF}%s {FFFF00}[ID:%d]{FFFFFF}\n", PlayerName(i), i);
            strcat(adminstring, tempstr, sizeof(adminstring));
            admins++;
          }
        }
      }
    if(admins > 0) {
      ShowPlayerDialog(playerid,DIALOG_ONLINEADMINS,DIALOG_STYLE_MSGBOX,"Online admins",adminstring,"Close","");
    } else {
      SendClientMessage(playerid, 0xFF0000FF, "No admins online")
    }
    return 1;
} 


Try this code. Nothing happens if no admins is online is because you don't add a count to the loop. Try and let me know if this works.

EDIT: I've updated the code try Now. Just realized something. This should show all the admins and show a message if there are no admins

[Kraeror]

Here you are:

Quote:

CMD:admins(playerid, params[]) { new adminstring[128]; new str123[500]; if(IsPlayerConnected(playerid)) { for (new i = 0; i < MAX_PLAYERS; i++) { if(IsPlayerConnected(i)) { if(PlayerInfo[i][pAdmin] > 0) { format(adminstring, sizeof(adminstring),"{FFFFFF}%s%s {FFFF00}[ID:%d]{FFFFFF}\n", adminstring, PlayerName(i), i); strcat(str123, adminstring); } } } ShowPlayerDialog(playerid,DIALOG_ONLINEADMINS,DIAL OG_STYLE_MSGBOX,"Online admins",str123,"Close",""); return 1; } }

Please, REP me if i helped!

[DarkSkull]

UPDATED CODE:

PHP код:

CMD:admins(playerid, params[])
{
    new adminstring[256],tempstr[128], admins = 0;
    for (new i = 0; i < MAX_PLAYERS; i++) {
        if(IsPlayerConnected(i))
        {
          if(PlayerInfo[i][pAdmin] > 0)
          {
            format(tempstr, sizeof(tempstr),"{FFFFFF}%s {FFFF00}[ID:%d]{FFFFFF}\n", PlayerName(i), i);
            strcat(adminstring, tempstr, sizeof(adminstring));
            admins++;
          }
        }
      }
    if(admins > 0) {
      ShowPlayerDialog(playerid,DIALOG_ONLINEADMINS,DIALOG_STYLE_MSGBOX,"Online admins",adminstring,"Close","");
    } else {
      SendClientMessage(playerid, 0xFF0000FF, "No admins online")
    }
    return 1;
} 


[GangstaSunny.]

Please guys. Please. Please. Please. I can't look to this anymore. Over years and years. For so long time i had to see this... Please. Please!

PHP код:

format(string,sizeof(string),"something");
format(string,sizeof(string),"%s something",string); //fck off strcat in this way.