[DuyDang2412]

I made a admin command to delete player account offline. Yeah, I'm having a trouble on the code, when I use the command, it always say that "can't find account" although I fill the account name correctly.

PHP код:

CMD:delaccount(playerid, params[]){
    new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128];
    if(Character[playerid][Admin] < 4) return System_Scm(playerid, "You do not have permission to perform this command.", TYPE_ERROR);
    if(sscanf(params, "s[24]", aName)) return System_Scm(playerid, "/delaccount [Account Name]", TYPE_NOTICE);
    foreach(new i: Player){
        if(!strcmp(aName, GetPlayerNameEx(playerid))) {
            format(string, sizeof(string), "Account [%s] is being used by Player ID [%d]", aName, i);
            System_Scm(playerid, string, TYPE_ERROR);
            return 1;
        } 
    }
    new rows;
    cache_get_row_count(rows);
    for(new row = 0; row < rows; row++){
        cache_get_value_name(row, "Username", szFieldName, 24);
        printf("%s - %s", aName, szFieldName);
        if(!strcmp(aName, szFieldName)) {
            mysql_format(MHandle, query, sizeof(query), "DELETE FROM `character` WHERE (`Username` = '%e') LIMIT 1", aName);
            mysql_query(MHandle, query);
            format(string, sizeof(string), "[%s] deleted [%s]", GetPlayerNameEx(playerid), aName);
            foreach(new i: Player) {
                if(Character[i][Admin] > 0) System_Scm(playerid, string, TYPE_SUCCESS);
            }
            return 1;
        }    
    }
    format(string, sizeof(string), "Can't find account [%s]", aName);
    System_Scm(playerid, string, TYPE_ERROR);
    return 1;
} 


I am using MySQL R41-2, the lastest version. I really need help!

[XStormiest]

But does the message saying: name deleted? as well?

[DuyDang2412]

No, it only says "cant find account", I don't know what problem this is.

And it doesn't print anything on the console.

[XStormiest]

Seems like it's not getting past this line: if(!strcmp(aName, szFieldName)) {
try to print something random on the console, and tell us if it prints out that text: for example: it works. If it doesn't work, it means smt is wrong. Put it in that areea: {strcmp...}

[DuyDang2412]

Quote:

Originally Posted by XStormiest Seems like it's not getting past this line: if(!strcmp(aName, szFieldName)) { try to print something random on the console, and tell us if it prints out that text: for example: it works. If it doesn't work, it means smt is wrong. Put it in that areea: {strcmp...}

Like this, man?

PHP код:

CMD:delaccount(playerid, params[]){
    new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128];
    if(Character[playerid][Admin] < 4) return System_Scm(playerid, PERMISSIONONLY, TYPE_ERROR);
    CMD:delaccount(playerid, params[]){ 
    new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128]; 
    if(Character[playerid][Admin] < 4) return System_Scm(playerid, "You do not have permission to perform this command.", TYPE_ERROR); 
    if(sscanf(params, "s[24]", aName)) return System_Scm(playerid, "/delaccount [Account Name]", TYPE_NOTICE); 
    foreach(new i: Player){ 
        if(!strcmp(aName, GetPlayerNameEx(playerid))) { 
            print("Being Used");
            format(string, sizeof(string), "Account [%s] is being used by Player ID [%d]", aName, i); 
            System_Scm(playerid, string, TYPE_ERROR); 
            return 1; 
        }  
    } 
    new rows; 
    cache_get_row_count(rows); 
    for(new row = 0; row < rows; row++){ 
        cache_get_value_name(row, "Username", szFieldName, 24); 
        printf("%s - %s", aName, szFieldName); 
        if(!strcmp(aName, szFieldName)) { 
            print("Found");
            mysql_format(MHandle, query, sizeof(query), "DELETE FROM `character` WHERE (`Username` = '%e') LIMIT 1", aName); 
            mysql_query(MHandle, query); 
            format(string, sizeof(string), "[%s] deleted [%s]", GetPlayerNameEx(playerid), aName); 
            foreach(new i: Player) { 
                if(Character[i][Admin] > 0) System_Scm(playerid, string, TYPE_SUCCESS); 
            } 
            return 1; 
        }     
    } 
            print("Can't find");
    format(string, sizeof(string), "Can't find account [%s]", aName); 
    System_Scm(playerid, string, TYPE_ERROR); 
    return 1; 
} 


I did it but It still doesn't print anything on the console when I perform the command.


Now i edit something and when I fill the online player name, it says 'Being Used', and when I fill the offline player name, it says 'Can't find' although that name is exist in my database.
It also doesn't print "%s - %s", so why? It has no condition to be allowed to perform.

I have printed the total tows onto the console.

Quote:

cache_get_row_count(rows); printf("%d", rows);

It prints '0' row, I'm sure that my total rows are more than.
Does it get the total rows failed? How can i make it gets succesfully?

[StrikerZ]

try

PHP код:

CMD:delaccount(playerid, params[]){
    new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128];
    if(Character[playerid][Admin] < 4) return System_Scm(playerid, "You do not have permission to perform this command.", TYPE_ERROR);
    if(sscanf(params, "s[24]", aName)) return System_Scm(playerid, "/delaccount [Account Name]", TYPE_NOTICE);
    foreach(new i: Player){
        if(!strcmp(aName, GetPlayerNameEx(playerid))) {
            format(string, sizeof(string), "Account [%s] is being used by Player ID [%d]", aName, i);
            System_Scm(playerid, string, TYPE_ERROR);
            return 1;
        }
    }
    mysql_format(MHande,query,sizeof(query),"SELECT `Username` FROM `character` WHERE `Username` = '%e'",aName);
    mysql_query(MHandle, query);
    new rows;
    cache_get_row_count(rows);
    if(rows != 0) {
            mysql_format(MHandle, query, sizeof(query), "DELETE FROM `character` WHERE (`Username` = '%e') LIMIT 1", aName);
            mysql_query(MHandle, query);
            format(string, sizeof(string), "[%s] deleted [%s]", GetPlayerNameEx(playerid), aName);
            foreach(new i: Player) {
                if(Character[i][Admin] > 0) System_Scm(playerid, string, TYPE_SUCCESS);
            }
            return 1;
        }
    }
    else
    {
        format(string, sizeof(string), "Can't find account [%s]", aName);
        System_Scm(playerid, string, TYPE_ERROR);
    }
    return 1;
} 


[DuyDang2412]

Quote:

Originally Posted by Sunehildeep try PHP код: CMD:delaccount(playerid, params[]){     new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128];     if(Character[playerid][Admin] < 4) return System_Scm(playerid, "You do not have permission to perform this command.", TYPE_ERROR);     if(sscanf(params, "s[24]", aName)) return System_Scm(playerid, "/delaccount [Account Name]", TYPE_NOTICE);     foreach(new i: Player){         if(!strcmp(aName, GetPlayerNameEx(playerid))) {             format(string, sizeof(string), "Account [%s] is being used by Player ID [%d]", aName, i);             System_Scm(playerid, string, TYPE_ERROR);             return 1;         }     }     mysql_format(MHande,query,sizeof(query),"SELECT `Username` FROM `character` WHERE `Username` = '%e'",aName);     mysql_query(MHandle, query);     new rows;     cache_get_row_count(rows);     if(rows != 0) {             mysql_format(MHandle, query, sizeof(query), "DELETE FROM `character` WHERE (`Username` = '%e') LIMIT 1", aName);             mysql_query(MHandle, query);             format(string, sizeof(string), "[%s] deleted [%s]", GetPlayerNameEx(playerid), aName);             foreach(new i: Player) {                 if(Character[i][Admin] > 0) System_Scm(playerid, string, TYPE_SUCCESS);             }             return 1;         }     }     else     {         format(string, sizeof(string), "Can't find account [%s]", aName);         System_Scm(playerid, string, TYPE_ERROR);     }     return 1; }

Okay, I will reply you after tried but can you tell me the difference between '%e' and '%s'?

[DuyDang2412]

Quote:

Originally Posted by Sunehildeep try PHP код: CMD:delaccount(playerid, params[]){     new aName[MAX_PLAYER_NAME], szFieldName[MAX_PLAYER_NAME], query[256], string[128];     if(Character[playerid][Admin] < 4) return System_Scm(playerid, "You do not have permission to perform this command.", TYPE_ERROR);     if(sscanf(params, "s[24]", aName)) return System_Scm(playerid, "/delaccount [Account Name]", TYPE_NOTICE);     foreach(new i: Player){         if(!strcmp(aName, GetPlayerNameEx(playerid))) {             format(string, sizeof(string), "Account [%s] is being used by Player ID [%d]", aName, i);             System_Scm(playerid, string, TYPE_ERROR);             return 1;         }     }     mysql_format(MHande,query,sizeof(query),"SELECT `Username` FROM `character` WHERE `Username` = '%e'",aName);     mysql_query(MHandle, query);     new rows;     cache_get_row_count(rows);     if(rows != 0) {             mysql_format(MHandle, query, sizeof(query), "DELETE FROM `character` WHERE (`Username` = '%e') LIMIT 1", aName);             mysql_query(MHandle, query);             format(string, sizeof(string), "[%s] deleted [%s]", GetPlayerNameEx(playerid), aName);             foreach(new i: Player) {                 if(Character[i][Admin] > 0) System_Scm(playerid, string, TYPE_SUCCESS);             }             return 1;         }     }     else     {         format(string, sizeof(string), "Can't find account [%s]", aName);         System_Scm(playerid, string, TYPE_ERROR);     }     return 1; }

It worked! Thank you very much. And can you tell me, after get a row count, I must select something first?

[Runn3R]

Use mysql_tquery and its return values to format the message if the query was succesful or not. And you shouldn't delete accounts with non-threaded queries.