[SAMPagainstpredators]

Ok, so I have a heavily redacted and advanced version of the SC:RP script, albeit none of the vehicle areas was touched other than an addition to license plates (Check plate and run plate for LEO's).

I am having an issue specifically where the car locks of player owned vehicles, as well as faction vehicles seemingly change ownership, or atleast I think.

What happens is a car will become unlockable (/lock) by the owner after time goes by... I cant say that the car is respawned etc (testing now).


I am assuming it is something to do with the dynamic ID's of the vehicles? I am just the server owner, so be easy with assuming my knowledge, although if you point me in the right direction I can get you what you need to suggest a fix!

Thank's in advance,
Zane

[haikalbintang]

Can you show me the code of the /lock cmds?

[SAMPagainstpredators]

Код:

CMD:lock(playerid, params[])
{
	static
	    id = -1;

	if (!IsPlayerInAnyVehicle(playerid) && (id = (House_Inside(playerid) == -1) ? (House_Nearest(playerid)) : (House_Inside(playerid))) != -1 && House_IsOwner(playerid, id))
	{
		if (!HouseData[id][houseLocked])
		{
			HouseData[id][houseLocked] = true;
			House_Save(id);

			ShowPlayerFooter(playerid, "You have ~r~locked~w~ your house!");
			PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);
		}
		else
		{
			HouseData[id][houseLocked] = false;
			House_Save(id);

			ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ your house!");
			PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);
		}
	}
	else if (!IsPlayerInAnyVehicle(playerid) && (id = (Business_Inside(playerid) == -1) ? (Business_Nearest(playerid)) : (Business_Inside(playerid))) != -1)
	{
		if (Business_IsOwner(playerid, id))
		{
			if (!BusinessData[id][bizLocked])
			{
				BusinessData[id][bizLocked] = true;

				Business_Refresh(id);
				Business_Save(id);

				ShowPlayerFooter(playerid, "You have ~r~locked~w~ the business!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);
			}
  			else
			{
				BusinessData[id][bizLocked] = false;

				Business_Refresh(id);
				Business_Save(id);

				ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ the business!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);
			}
		}
	}
	else if (!IsPlayerInAnyVehicle(playerid) && (id = (Entrance_Inside(playerid) == -1) ? (Entrance_Nearest(playerid)) : (Entrance_Inside(playerid))) != -1)
	{
		if (strlen(EntranceData[id][entrancePass]))
		{
			Dialog_Show(playerid, EntrancePass, DIALOG_STYLE_INPUT, "Entrance Pass", "Please enter the password for this entrance:", "Submit", "Cancel");
		}
	}
	else if ((id = Car_Nearest(playerid)) != -1)
	{
	    static
	        engine,
	        lights,
	        alarm,
	        doors,
	        bonnet,
	        boot,
	        objective;

	    GetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, doors, bonnet, boot, objective);

	    if (Car_IsOwner(playerid, id) || (PlayerData[playerid][pFaction] != -1 && CarData[id][carFaction] == GetFactionType(playerid)))
	    {
			if (!CarData[id][carLocked])
			{
				CarData[id][carLocked] = true;
				Car_Save(id);

				ShowPlayerFooter(playerid, "You have ~r~locked~w~ the vehicle!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);

				SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 1, bonnet, boot, objective);
			}
			else
			{
				CarData[id][carLocked] = false;
				Car_Save(id);

				ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ the vehicle!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);

				SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 0, bonnet, boot, objective);
			}
		}
	}
	else SendErrorMessage(playerid, "You are not in range of anything you can lock.");
	return 1;
}

[haikalbintang]

What the problem really is?

[SAMPagainstpredators]

If I restart the server, players car locks work fine... But for some reason, over time a player cannot /lock their car from the outside... It will not return a message or anything.

I am assuming the car id's are doing something awkward?

You can login game and test it out.

104.196.158.57:7777

[haikalbintang]

Quote:

Originally Posted by SAMPagainstpredators Код: CMD:lock(playerid, params[]) { static id = -1; if (!IsPlayerInAnyVehicle(playerid) && (id = (House_Inside(playerid) == -1) ? (House_Nearest(playerid)) : (House_Inside(playerid))) != -1 && House_IsOwner(playerid, id)) { if (!HouseData[id][houseLocked]) { HouseData[id][houseLocked] = true; House_Save(id); ShowPlayerFooter(playerid, "You have ~r~locked~w~ your house!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); } else { HouseData[id][houseLocked] = false; House_Save(id); ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ your house!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); } } else if (!IsPlayerInAnyVehicle(playerid) && (id = (Business_Inside(playerid) == -1) ? (Business_Nearest(playerid)) : (Business_Inside(playerid))) != -1) { if (Business_IsOwner(playerid, id)) { if (!BusinessData[id][bizLocked]) { BusinessData[id][bizLocked] = true; Business_Refresh(id); Business_Save(id); ShowPlayerFooter(playerid, "You have ~r~locked~w~ the business!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); } else { BusinessData[id][bizLocked] = false; Business_Refresh(id); Business_Save(id); ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ the business!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); } } } else if (!IsPlayerInAnyVehicle(playerid) && (id = (Entrance_Inside(playerid) == -1) ? (Entrance_Nearest(playerid)) : (Entrance_Inside(playerid))) != -1) { if (strlen(EntranceData[id][entrancePass])) { Dialog_Show(playerid, EntrancePass, DIALOG_STYLE_INPUT, "Entrance Pass", "Please enter the password for this entrance:", "Submit", "Cancel"); } } else if ((id = Car_Nearest(playerid)) != -1) { static engine, lights, alarm, doors, bonnet, boot, objective; GetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, doors, bonnet, boot, objective); if (Car_IsOwner(playerid, id) || (PlayerData[playerid][pFaction] != -1 && CarData[id][carFaction] == GetFactionType(playerid))) { if (!CarData[id][carLocked]) { CarData[id][carLocked] = true; Car_Save(id); ShowPlayerFooter(playerid, "You have ~r~locked~w~ the vehicle!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 1, bonnet, boot, objective); } else { CarData[id][carLocked] = false; Car_Save(id); ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ the vehicle!"); PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0); SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 0, bonnet, boot, objective); } } } else SendErrorMessage(playerid, "You are not in range of anything you can lock."); return 1; }

It's really confusing why u using id = -1, maybe you should change with looping like this :

Код:

for(new id = 0; id < MAX_VEHICLES; id++)
{
if ((id = Car_Nearest(playerid)) != -1)
	{
	    static
	        engine,
	        lights,
	        alarm,
	        doors,
	        bonnet,
	        boot,
	        objective;

	    GetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, doors, bonnet, boot, objective);

	    if (Car_IsOwner(playerid, id) || (PlayerData[playerid][pFaction] != -1 && CarData[id][carFaction] == GetFactionType(playerid)))
	    {
			if (!CarData[id][carLocked])
			{
				CarData[id][carLocked] = true;
				Car_Save(id);

				ShowPlayerFooter(playerid, "You have ~r~locked~w~ the vehicle!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);

				SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 1, bonnet, boot, objective);
			}
			else
			{
				CarData[id][carLocked] = false;
				Car_Save(id);

				ShowPlayerFooter(playerid, "You have ~g~unlocked~w~ the vehicle!");
				PlayerPlaySound(playerid, 1145, 0.0, 0.0, 0.0);

				SetVehicleParamsEx(CarData[id][carVehicle], engine, lights, alarm, 0, bonnet, boot, objective);
			}
		}
	}
}

[SAMPagainstpredators]

Can I copy and paste this in exchange for the code above?

As I said, I am just the server owner and my developer is away for the next two days.. this problem showed up after we made a few changes for /hotwire (which were removed)

[Wahyu33]

SC:RP version??