[justjamie]

title.
This is my code:

PHP код:

        else if(!strcmp(tmp, "list", true, 5))
        {
            new iBigStr[386];
               SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________________");
               for(new i = 1; i < sizeof(Vehicle); i++)
                {
                           if(!strcmp(Vehicle[i][vOwner], Name(playerid), false))
                        {
                            new zone[ 80 ], Float:vipos[3], lockstr[10];
                            if(Vehicle[i][tmplocked]) myStrcpy(lockstr, "Yes");
                            else myStrcpy(lockstr, "No");
                            GetVehiclePos(i, vipos[0], vipos[1], vipos[2]);
                            GetZone(vipos[0], vipos[1], vipos[2], zone);
                             format(iBigStr, sizeof(iBigStr), "{bebaba}(ID %d) {51983e}%s [Location: {bebaba}%s{51983e}] [Locked: {bebaba}%s{51983e}]", i, GetVehicleName(i), zone, lockstr);
                            SendClientMessage(playerid, -1, iBigStr);
                        }
                        else return 1;
                }
            SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________");
        } 


it doesn't execute this:

PHP код:

        else if(!strcmp(tmp, "list", true, 5))
        {
            new iBigStr[386];
               SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________________");
               for(new i = 1; i < sizeof(Vehicle); i++)
                {
                           if(!strcmp(Vehicle[i][vOwner], Name(playerid), false))
                        {
                            new zone[ 80 ], Float:vipos[3], lockstr[10];
                            if(Vehicle[i][tmplocked]) myStrcpy(lockstr, "Yes");
                            else myStrcpy(lockstr, "No");
                            GetVehiclePos(i, vipos[0], vipos[1], vipos[2]);
                            GetZone(vipos[0], vipos[1], vipos[2], zone);
                             format(iBigStr, sizeof(iBigStr), "{bebaba}(ID %d) {51983e}%s [Location: {bebaba}%s{51983e}] [Locked: {bebaba}%s{51983e}]", i, GetVehicleName(i), zone, lockstr);
                            SendClientMessage(playerid, -1, iBigStr);
                        }
                        else return 1;
                }
// THIS            SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________");
        } 


Why is that?

[Vince]

Don't return inside loops unless you explicitly want to break them.

[justjamie]

Quote:

Originally Posted by Vince Don't return inside loops unless you explicitly want to break them.

But if i don't do that, it shows: SERVER: Unknown command after executing the command successfully

[Vince]

Return after the loop, after the message that isn't displayed. Also if the very first vehicle in the list isn't owned by you then the loop will just stop on the first iteration and the only thing you will see is the first horizontal rule and nothing else.

[justjamie]

Quote:

Originally Posted by Vince Return after the loop, after the message that isn't displayed. Also if the very first vehicle in the list isn't owned by you then the loop will just stop on the first iteration and the only thing you will see is the first horizontal rule and nothing else.

I am returning it after the loop.

My code right now:

PHP код:

        else if(!strcmp(tmp, "list", true, 5))
        {
            new iBigStr[386];
               SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________________");
               SendClientMessage(playerid, -1, sprintf("{D4D4D4}[VEHICLES] {ffffff}%s{D4D4D4}'s vehicles: ",Name(playerid)));
               for(new i = 1; i < sizeof(Vehicle); i++)
                {
                           if(!strcmp(Vehicle[i][vOwner], Name(playerid), false))
                        {
                            new zone[ 80 ], Float:vipos[3], lockstr[10];
                            if(Vehicle[i][tmplocked]) myStrcpy(lockstr, "Yes");
                            else myStrcpy(lockstr, "No");
                            GetVehiclePos(i, vipos[0], vipos[1], vipos[2]);
                            GetZone(vipos[0], vipos[1], vipos[2], zone);
                             format(iBigStr, sizeof(iBigStr), "{bebaba}(ID %d) {51983e}%s [Location: {bebaba}%s{51983e}] [Locked: {bebaba}%s{51983e}]", i, GetVehicleName(i), zone, lockstr);
                            SendClientMessage(playerid, -1, iBigStr);
                        }
                }
            SendClientMessage(playerid, -1, "{3696EB}________________________________________________________________");
           } 


output:

[Shinja]

PHP код:

return 1; 


In the last line after the last SendClientMessage

[Konstantinos]

Run time error 4 for accessing negative index (-400) because the vehicle does not exist and you are trying to retrieve its name.

Since the vehicle ID is index for the vehicle array, you do not need to loop 2000 times - use the vehicle pools:

pawn Код:

for(new i = 1, j = GetVehiclePoolSize(); i <= j; i++)
{
    if (!GetVehicleModel(i)) continue; // if the vehicle does not exist, skip the iterator
    if(!strcmp(Vehicle[i][vOwner], Name(playerid), false))
    {
        ...
    }
}