1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
dialog response not happening?
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#1

14.05.2016, 16:33
Hi guys,
So im having a little problem here: when a dialog is shown and the player chooses something from the 2 listed lines it doesnt respond like it should start a script but its not working.

Ill leave the code here:

PHP код:
if(clickedid == carselect17)
    {
        SetPlayerPos(playerid, playerposescolherX[playerid],playerposescolherY[playerid],playerposescolherZ[playerid]);
         SetPlayerInterior(playerid, playerintescolher[playerid]);
         SetPlayerVirtualWorld(playerid, playervirtualworldescolher[playerid]);
        TextDrawHideForPlayer(playerid, carselect0);
        TextDrawHideForPlayer(playerid, carselect1);
        TextDrawHideForPlayer(playerid, carselect2);
        TextDrawHideForPlayer(playerid, carselect3);
        TextDrawHideForPlayer(playerid, carselect4);
        TextDrawHideForPlayer(playerid, carselect5);
        TextDrawHideForPlayer(playerid, carselect6);
        TextDrawHideForPlayer(playerid, carselect7);
        TextDrawHideForPlayer(playerid, carselect8);
        TextDrawHideForPlayer(playerid, carselect9);
        TextDrawHideForPlayer(playerid, carselect10);
        TextDrawHideForPlayer(playerid, carselect11);
        TextDrawHideForPlayer(playerid, carselect12);
        TextDrawHideForPlayer(playerid, carselect13);
        TextDrawHideForPlayer(playerid, carselect14);
        TextDrawHideForPlayer(playerid, carselect15);
        TextDrawHideForPlayer(playerid, carselect16);
        TextDrawHideForPlayer(playerid, carselect17);
        TextDrawHideForPlayer(playerid, carselect18);
        TextDrawHideForPlayer(playerid, carselect19);
        TextDrawHideForPlayer(playerid, carselect20);
        TextDrawHideForPlayer(playerid, carselect21);
        TextDrawHideForPlayer(playerid, carselect22);
        TextDrawHideForPlayer(playerid, carselect23);
        TextDrawHideForPlayer(playerid, carselect24);
        TextDrawHideForPlayer(playerid, carselect25);
        SetCameraBehindPlayer(playerid);
        CancelSelectTextDraw(playerid);
        ShowPlayerDialog(playerid, 1070, DIALOG_STYLE_LIST, "Escolhe o tipo de combustivel:","Gasoleo\nGasolina","Escolher", "Cancelar");
    } 
PHP код:
if(dialogid == 1070)
    {
        if(response)
        {
            if(listitem == 0)
            {
                new TCarModel = carroapresentar[playerid];
                escolhacombustivel[playerid] = 1;
                tipocombustivel[playerid] = 1;
                new valorveiculo = TCarModel-400;
                new precoveiculo = VehiclePrices[valorveiculo][0];
                 for(new i = 0; i < sizeof(Businesses); i++)
                    {
                        if(PlayerToPoint(25.0, playerid,Businesses[i][ExitX], Businesses[i][ExitY], Businesses[i][ExitZ]))
                        {
                            if(GetPlayerVirtualWorld(playerid) == i)
                            {
                                if(Businesses[i][BizType] == 9)
                                {
                                    for(new c=0;c<MAX_VEHICLES;c++)
                                    {
                                        if(DynamicCars[c][comprado] == 0) // Nгo comprado
                                        {
                                            if(DynamicCars[c][valor] == 0) // Sem Preзo
                                            {
                                                if(DynamicCars[c][buy] == 1) // Para venda
                                                {
                                                    if(DynamicCars[c][CarModel] == 481)
                                                    {
                                                        if(IsValidModel(TCarModel))
                                                        {
                                                            SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                                                            SendClientMessage(playerid, COLOR_WHITE, "Compraste o veiculo com sucesso. Este aparecerб na marinha de Palomino Creek em 10 horas ingame");
                                                            SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                                                                SetTimerEx("buyvehtime", 2000, false, "iii", playerid, TCarModel, c);
                                                                if(PlayerInfo[playerid][pVipActive] != 0)
                                                                {
                                                                GivePlayerEuros(playerid, -precoveiculo/2);
                                                                Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/2/100);
                                                                   Businesses[i][Till]+=precoveiculo;
                                                                OnPlayerDataSave(playerid);
                                                                }
                                                                else
                                                                {
                                                                GivePlayerEuros(playerid, -precoveiculo);
                                                                Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/100);
                                                                   Businesses[i][Till]+=precoveiculo;
                                                                }
                                                                if(PlayerInfo[playerid][pChave1] == 255)
                                                                {
                                                                   PlayerInfo[playerid][pChave1] = c+1;
                                                                  return 1;
                                                                  }
                                                                else if(PlayerInfo[playerid][pChave2] == 255)
                                                                 {
                                                                  PlayerInfo[playerid][pChave2] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave3] == 255)
                                                                  {
                                                                PlayerInfo[playerid][pChave3] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave4] == 255)
                                                                  {
                                                                PlayerInfo[playerid][pChave4] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave5] == 255)
                                                                   {
                                                                   PlayerInfo[playerid][pChave5] = c+1;
                                                                  return 1;
                                                                  }
                                                                else if(PlayerInfo[playerid][pChave6] == 255)
                                                                {
                                                                   PlayerInfo[playerid][pChave6] = c+1;
                                                                   return 1;
                                                                }
                                                        }
                                                        else
                                                        {
                                                            SendClientMessage(playerid, COLOR_RED,"{FF0000}[Erro]: {FFFFFF}Modelo Invбlido.");
                                                            return 1;
                                                        }
                                                    }
                                                }
                                            }
                                        }
                                    }
                                       return 1;
                                }
                            }
                        }
                    }
            }
            if(listitem == 1)
            {
                new TCarModel = carroapresentar[playerid];
                escolhacombustivel[playerid] = 1;
                tipocombustivel[playerid] = 2;
                new valorveiculo = TCarModel-400;
                new precoveiculo = VehiclePrices[valorveiculo][0];
                precoveiculo *= 0.9;
                for(new i = 0; i < sizeof(Businesses); i++)
                    {
                        if(PlayerToPoint(25.0, playerid,Businesses[i][ExitX], Businesses[i][ExitY], Businesses[i][ExitZ]))
                        {
                            if(GetPlayerVirtualWorld(playerid) == i)
                            {
                                if(Businesses[i][BizType] == 9)
                                {
                                    for(new c=0;c<MAX_VEHICLES;c++)
                                    {
                                        if(DynamicCars[c][comprado] == 0) // Nгo comprado
                                        {
                                            if(DynamicCars[c][valor] == 0) // Sem Preзo
                                            {
                                                if(DynamicCars[c][buy] == 1) // Para venda
                                                {
                                                    if(DynamicCars[c][CarModel] == 481)
                                                    {
                                                        if(IsValidModel(TCarModel))
                                                        {
                                                            SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                                                            SendClientMessage(playerid, COLOR_WHITE, "Compraste o veiculo com sucesso. Este aparecerб na marinha de Palomino Creek em 10 horas ingame");
                                                            SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                                                                SetTimerEx("buyvehtime", 2000, false, "iii", playerid, TCarModel, c);
                                                                if(PlayerInfo[playerid][pVipActive] != 0)
                                                                {
                                                                GivePlayerEuros(playerid, -precoveiculo/2);
                                                                Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/2/100);
                                                                   Businesses[i][Till]+=precoveiculo;
                                                                OnPlayerDataSave(playerid);
                                                                }
                                                                else
                                                                {
                                                                GivePlayerEuros(playerid, -precoveiculo);
                                                                Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/100);
                                                                   Businesses[i][Till]+=precoveiculo;
                                                                }
                                                                if(PlayerInfo[playerid][pChave1] == 255)
                                                                {
                                                                   PlayerInfo[playerid][pChave1] = c+1;
                                                                  return 1;
                                                                  }
                                                                else if(PlayerInfo[playerid][pChave2] == 255)
                                                                 {
                                                                  PlayerInfo[playerid][pChave2] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave3] == 255)
                                                                  {
                                                                PlayerInfo[playerid][pChave3] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave4] == 255)
                                                                  {
                                                                PlayerInfo[playerid][pChave4] = c+1;
                                                                return 1;
                                                                }
                                                                   else if(PlayerInfo[playerid][pChave5] == 255)
                                                                   {
                                                                   PlayerInfo[playerid][pChave5] = c+1;
                                                                  return 1;
                                                                  }
                                                                else if(PlayerInfo[playerid][pChave6] == 255)
                                                                {
                                                                   PlayerInfo[playerid][pChave6] = c+1;
                                                                   return 1;
                                                                }
                                                        }
                                                        else
                                                        {
                                                            SendClientMessage(playerid, COLOR_RED,"{FF0000}[Erro]: {FFFFFF}Modelo Invбlido.");
                                                            return 1;
                                                        }
                                                    }
                                                    else
                                                    {
                                                    SendClientMessage(playerid, COLOR_RED, "Teste1");
                                                    }
                                                }
                                                else
                                                {
                                                SendClientMessage(playerid, COLOR_RED, "Teste2");
                                                }
                                            }
                                            else
                                            {
                                            SendClientMessage(playerid, COLOR_RED, "Teste3");
                                            }
                                        }
                                        else
                                        {
                                        SendClientMessage(playerid, COLOR_RED, "Teste4");
                                        }
                                    }
                                       return 1;
                                }
                                else
                                {
                                SendClientMessage(playerid, COLOR_RED, "Teste5");
                                }
                            }
                            else
                            {
                            SendClientMessage(playerid, COLOR_RED, "Teste6");
                            }
                        }
                        else
                        {
                        SendClientMessage(playerid, COLOR_RED, "Teste7");
                        }
                    }
            }
        }
    } 




Note: those sendclientmessage were for me too see if there was anything wrong with the script but didnt find out anything.
Find
Reply
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#2

14.05.2016, 18:39
does any 1 know whats really happening? please
Find
Reply
Skimmer
Gangsta
****
Posts: 484
Threads: 11
Joined: Oct 2012
Reputation: 0
#3

14.05.2016, 19:15
Maybe one of your if-statements doesn't equal with the value you have given there.

In
Код:
listitem == 0
you aren't returning anything when the if-statement doesn't equal, but in
Код:
listitem == 1
you do this.

I have improved your code a bit, because it was looking very very messy and there were meaningless lines.

pawn Код:
if(dialogid == 1070)
{
    if(response)
    {
        new TCarModel = carroapresentar[playerid];
        escolhacombustivel[playerid] = 1;
        new valorveiculo = TCarModel-400;
        new precoveiculo = VehiclePrices[valorveiculo][0];

        if(listitem == 0)
        {
            tipocombustivel[playerid] = 1;
        }
        if(listitem == 1)
        {
            tipocombustivel[playerid] = 2;
            precoveiculo *= 0.9;
        }

        for(new i = 0; i < sizeof(Businesses); i++)
        {

            if(!PlayerToPoint(25.0, playerid,Businesses[i][ExitX], Businesses[i][ExitY], Businesses[i][ExitZ])) continue;

            if(!GetPlayerVirtualWorld(playerid) == i) continue;

            if(Businesses[i][BizType] != 9) continue;

            for(new c=0;c<MAX_VEHICLES;c++)
            {
                if(DynamicCars[c][comprado] != 0) continue;

                if(DynamicCars[c][valor] != 0) continue;

                if(DynamicCars[c][buy] != 1) continue;

                if(DynamicCars[c][CarModel] != 481) continue;
 
                if(!IsValidModel(TCarModel))
                    return SendClientMessage(playerid, COLOR_RED,"{FF0000}[Erro]: {FFFFFF}Modelo Invбlido.");

                SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                SendClientMessage(playerid, COLOR_WHITE, "Compraste o veiculo com sucesso. Este aparecerб na marinha de Palomino Creek em 10 horas ingame");
                SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");

                SetTimerEx("buyvehtime", 2000, false, "iii", playerid, TCarModel, c);

                if(PlayerInfo[playerid][pVipActive] != 0)
                {
                    GivePlayerEuros(playerid, -precoveiculo/2);
                    Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/2/100);
                    Businesses[i][Till]+=precoveiculo;
                    OnPlayerDataSave(playerid);
                }
                else
                {
                    GivePlayerEuros(playerid, -precoveiculo);
                    Businesses[i][Products]=Businesses[i][Products]-(precoveiculo/100);
                    Businesses[i][Till]+=precoveiculo;
                }

                if(PlayerInfo[playerid][pChave1] == 255)
                {
                    PlayerInfo[playerid][pChave1] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave2] == 255)
                {
                    PlayerInfo[playerid][pChave2] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave3] == 255)
                {
                    PlayerInfo[playerid][pChave3] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave4] == 255)
                {
                    PlayerInfo[playerid][pChave4] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave5] == 255)
                {
                    PlayerInfo[playerid][pChave5] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave6] == 255)
                {
                   PlayerInfo[playerid][pChave6] = c+1;
                   return 1;
                }
            }
            return 1;
        }
    }
}
Tip: Always comment your code.
Find
Reply
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#4

14.05.2016, 20:07
Thanks man. Im sorry for the messy stuff started coding a month ago and im only 14 id say for the stuff i can make im in a good path. But srsly thanks again

EDIT: Hum somehow the code still doesnt run. Goddangit :S
Find
Reply
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#5

14.05.2016, 22:45
please anyone?
Find
Reply
Mic_H
Big Clucker
***
Posts: 178
Threads: 7
Joined: Oct 2011
Reputation: 0
#6

15.05.2016, 06:23
Quote:

public OnDialogResponse(playerid, dialogid, response, listitem, inputtext[])
{
return 0; // You MUST return 0 here! Just like OnPlayerCommandText.
}
If you forgot to return 0; or did return 1; in any of your earlier filterscripts, it wont work. Check all your other Dialogs. And make sure to return 0; at the end of DialogResponse..
https://sampwiki.blast.hk/wiki/OnDialogResponse
Find
Reply
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#7

15.05.2016, 07:04
Checked changed to return 0 still doesnt work. All the others work but this one just doesnt want to work! any other ideas?
Find
Reply
Sew_Sumi
Banned
Posts: 6,242
Threads: 8
Joined: Jun 2008
#8

15.05.2016, 08:26
PHP код:
print('Debug points'); 
PHP код:
printf('%i Listitem', listitem); 
Even use your SendClientMessage setup in different spots rather than simply on the fail. Do it before you check anything so you know what it is indeed returning.

I'd also suggest to go back to what you had in the first place if it was working in other sections.
Find
Reply
GunZsmd
Banned
Posts: 143
Threads: 40
Joined: Aug 2014
#9

15.05.2016, 09:15
So i did that and i found out that nothing really happens when u press those buttons. I removed the bizz thing and replaced directly with the bizz id imma leave here what i did:
PHP код:
if(dialogid == 169)
{
    if(response)
    {
        SendClientMessage(playerid, COLOR_RED, "test");
        new TCarModel = carroapresentar[playerid];
        escolhacombustivel[playerid] = 1;
        new valorveiculo = TCarModel-400;
        new precoveiculo = VehiclePrices[valorveiculo][0];
        if(listitem == 0)
        {
            tipocombustivel[playerid] = 1;
            SendClientMessage(playerid, COLOR_RED, "op1");
        }
        if(listitem == 1)
        {
            tipocombustivel[playerid] = 2;
            SendClientMessage(playerid, COLOR_RED, "op2");
            precoveiculo *= 0.9;
        }
        SendClientMessage(playerid, COLOR_RED, "test999");
            for(new c=0;c<MAX_VEHICLES;c++)
            {
                if(DynamicCars[c][comprado] != 0) continue;
                SendClientMessage(playerid, COLOR_RED, "test5");
                if(DynamicCars[c][valor] != 0) continue;
                SendClientMessage(playerid, COLOR_RED, "test6");
                if(DynamicCars[c][buy] != 1) continue;
                SendClientMessage(playerid, COLOR_RED, "test7");
                if(DynamicCars[c][CarModel] != 481) continue;
                SendClientMessage(playerid, COLOR_RED, "test8");
                if(!IsValidModel(TCarModel))
                    return SendClientMessage(playerid, COLOR_RED,"{FF0000}[Erro]: {FFFFFF}Modelo Invбlido.");
                SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                SendClientMessage(playerid, COLOR_WHITE, "Compraste o veiculo com sucesso. Este aparecerб na marinha de Palomino Creek em 10 horas ingame");
                SendClientMessage(playerid, COLOR_GREY, "========================================================================================================");
                SetTimerEx("buyvehtime", 2000, false, "iii", playerid, TCarModel, c);
                if(PlayerInfo[playerid][pVipActive] != 0)
                {
                    GivePlayerEuros(playerid, -precoveiculo/2);
                    Businesses[1][Products]=Businesses[1][Products]-(precoveiculo/2/100);
                       Businesses[1][Till]+=precoveiculo;
                    OnPlayerDataSave(playerid);
                }
                else
                {
                    GivePlayerEuros(playerid, -precoveiculo);
                    Businesses[1][Products]=Businesses[1][Products]-(precoveiculo/100);
                       Businesses[1][Till]+=precoveiculo;
                }
                if(PlayerInfo[playerid][pChave1] == 255)
                {
                       PlayerInfo[playerid][pChave1] = c+1;
                      return 1;
                }
                else if(PlayerInfo[playerid][pChave2] == 255)
                {
                      PlayerInfo[playerid][pChave2] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave3] == 255)
                {
                    PlayerInfo[playerid][pChave3] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave4] == 255)
                {
                    PlayerInfo[playerid][pChave4] = c+1;
                    return 1;
                }
                else if(PlayerInfo[playerid][pChave5] == 255)
                {
                    PlayerInfo[playerid][pChave5] = c+1;
                      return 1;
                }
                else if(PlayerInfo[playerid][pChave6] == 255)
                {
                   PlayerInfo[playerid][pChave6] = c+1;
                   return 1;
                }
            }
            return 1;
    }
} 
From all those sendclientmessage only the first one works. Why is the script returning after the response?
Find
Reply
Sew_Sumi
Banned
Posts: 6,242
Threads: 8
Joined: Jun 2008
#10

15.05.2016, 09:45
That's why I said to output the actual listitem... Then you'd know what it's putting out when you are using that.

With those messages though you should see test, and test999. If you don't then there's something really screwed up with it.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help