Yes. Allow me to explain too what I altered.
I prioritize checks. A priority check in admin commands is the check whether or not the player using the command is authorized to use the command.
PHP код:
if(pInfo[playerid][Admin] < 5)
return SendClientMessage(playerid, GREY, "You are not authorized to use that command.");
I then create the variables that are used first in the command. You should always try to delay the declaration of variables and prioritize them. The ones used first are created first and the ones used last are declared last:
PHP код:
new
targetid,
AdminLevel
;
I use them in the sscanf function:
PHP код:
if(sscanf(params, "ui", targetid, AdminLevel))
return SendClientMessage(playerid, GREY, "USAGE: /makeadmin (playerid) (level)");
I don't know what version of sscanf you are using, but I seem to remember that there was a bug with the 'u' specifier in (one of the / a) previous version(s). If that's the case and you don't include NPC's in 'targetid' then you can use the 'r' specifier instead (and that might as well been your issue).
I once again prioritize checks according to the specifiers in the sscanf function. The first specifier is the one responsible for the playerid/name, so I check whether or not the player specified is valid first:
PHP код:
if(!IsPlayerConnected(targetid))
return SendClientMessage(playerid, GREY, "ERROR: player is not conencted.");
The second specifier is the one for the admin level, so I check if the specified admin level is less than 10 and greater than 0 (since you want level to start from 1):
PHP код:
if(10 < AdminLevel < 1)
return SendClientMessage(playerid, GREY, "LEVELS available: 1 to 10.");
And then we get to the point where we format our strings and assign the admin level to the player's variable. We first retrieve the names and thus we create the tname and pname variables first:
PHP код:
new
tname[MAX_PLAYER_NAME],
pname[MAX_PLAYER_NAME]
;
We retrieve the names:
PHP код:
GetPlayerName(playerid, pname, sizeof(pname));
GetPlayerName(targetid, tname, sizeof(tname));
Now we can format the strings and I create the variable holding the formatted strings now too:
PHP код:
new
str[101]
;
format(str, sizeof(str), "Administrator %s has set your admin level to %d, %s", pname, AdminLevel, (AdminLevel > pInfo[playerid][Admin]) ? ("congratulations on your promotion!") : ("improve yourself where possible!"));
SendClientMessage(targetid, RED, str);
format(str, sizeof(str), "You have set %s\'s admin level to %d", tname, AdminLevel);
SendClientMessage(playerid, RED, str);
And last but not least, we set the target's admin variable:
PHP код:
pInfo[targetid][Admin] = AdminLevel;
Perhaps another part of my version that requires an explanation is this:
PHP код:
format(str, sizeof(str), "Administrator %s has set your admin level to %d, %s", pname, AdminLevel, (AdminLevel > pInfo[playerid][Admin]) ? ("congratulations on your promotion!") : ("improve yourself where possible!"));
You might ask yourself, what in earth is:
PHP код:
(AdminLevel > pInfo[playerid][Admin]) ? ("congratulations on your promotion!") : ("improve yourself where possible!")
That's called the ternary operator and takes three arguments (hence the name ternary):
https://en.wikipedia.org/wiki/%3F:
A way to describe what this exactly does is by replacing it by what it replaces (if-else):
PHP код:
if(AdminLevel > pInfo[playerid][Admin]) {
format(str, sizeof(str), "Administrator %s has set your admin level to %d, congratulations on your promotion!", pname, AdminLevel);
}
else {
format(str, sizeof(str), "Administrator %s has set your admin level to %d, improve yourself where possible!", pname, AdminLevel);
}
You can basically see the ternary operator as such:
PHP код:
condition ? true : false
If your 'true' and your 'false' are string values, then they are required to be put in between brackets:
PHP код:
condition ? ("true") : ("false")
Here's the full command:
PHP код:
CMD:makeadmin(playerid, params[]) {
if(pInfo[playerid][Admin] < 5)
return SendClientMessage(playerid, GREY, "You are not authorized to use that command.");
new
targetid,
AdminLevel
;
if(sscanf(params, "ui", targetid, AdminLevel))
return SendClientMessage(playerid, GREY, "USAGE: /makeadmin (playerid) (level)");
if(!IsPlayerConnected(targetid))
return SendClientMessage(playerid, GREY, "ERROR: player is not conencted.");
if(AdminLevel > 10)
return SendClientMessage(playerid, GREY, "LEVELS available: 1 to 10.");
new
tname[MAX_PLAYER_NAME],
pname[MAX_PLAYER_NAME]
;
GetPlayerName(playerid, pname, sizeof(pname));
GetPlayerName(targetid, tname, sizeof(tname));
new
str[101]
;
format(str, sizeof(str), "Administrator %s has set your admin level to %d, %s", pname, AdminLevel, (AdminLevel > pInfo[playerid][Admin]) ? ("congratulations on your promotion!") : ("improve yourself where possible!"));
SendClientMessage(targetid, RED, str);
format(str, sizeof(str), "You have set %s\'s admin level to %d", tname, AdminLevel);
SendClientMessage(playerid, RED, str);
pInfo[targetid][Admin] = AdminLevel;
return true;
}
