[Squirrel]

so can anyone let me know whats the problem with this


Basically it doesnt work, if you ban someones IP it will still let them play normaly. The check doesnt work

PHP код:

new myIP[16];
    GetPlayerIp(playerid, myIP, sizeof(myIP));
    if(IPBanned(myIP)) {
        Kick(playerid);
        return true;
    }
IPBanned(const str[])
{
    new query[85],Cache:result,rows;
    mysql_format(mysql, query, sizeof(query), "SELECT `IP` FROM `ipbanned` WHERE `IP` = '%e' LIMIT 1",str);
    result = mysql_query(mysql, query);
    if((rows = cache_num_rows()))
    {
        rows = cache_get_row_int(0, 0);
        cache_delete(result);
        return rows;
    }
    cache_delete(result);
    return rows;
} 


[K0P]

add this under OnPlayerConnect(playerid)

Код:

    if(IPBanned(myIP)) { 
        Kick(playerid); 
        return true; 
    }

[Squirrel]

As I said above, its not working and yes I have it under OnPlayerConnect.

[Prokill911]

Because you're sending %e..
Try below code.

PHP код:

IPBanned(const str[]) {
    new query[85],Cache:result,rows;
    mysql_format(mysql, query, sizeof(query), "SELECT `IP` FROM `ipbanned` WHERE `IP` = '%s' LIMIT 1",str);
    result = mysql_query(mysql, query);
    if((rows = cache_num_rows())) {
        rows = cache_get_row_int(0, 0);
        cache_delete(result);
        return rows;
    }
    cache_delete(result);
    return rows;
} 


[Squirrel]

I tried the system, it displays info correctly in the SQL log also...

PHP код:

[19:51:30] [DEBUG] mysql_format - connection: 1, len: 85, format: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '%s' LIMIT 1"
[19:51:30] [DEBUG] mysql_query - connection: 1, query: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '127.0.0.1' LIMIT 1", use_cache: true 


[Prokill911]

I don't get the issue then
Because You're saying what I gave you works

[Squirrel]

Quote:

Originally Posted by Prokill911 I don't get the issue then Because You're saying what I gave you works

Same thing happends.

PHP код:

[21:38:52] [DEBUG] mysql_format - connection: 1, len: 85, format: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '%s' LIMIT 1"
[21:38:52] [DEBUG] mysql_query - connection: 1, query: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '127.0.0.1' LIMIT 1", use_cache: true 


It does work loading wise, but it doesnt tell player that their IP is banned etc.

PHP код:

new myIP[16];
    GetPlayerIp(playerid, myIP, sizeof(myIP));
    if(IPBanned(myIP)) {
        Msg(playerid,COLOR_RED,"IP banned");
        return true;
    } 


Full log

PHP код:

[21:43:07] [DEBUG] mysql_format - connection: 1, len: 85, format: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '%s' LIMIT 1"
[21:43:07] [DEBUG] mysql_query - connection: 1, query: "SELECT `IP` FROM `ipbanned` WHERE `IP` = '127.0.0.1' LIMIT 1", use_cache: true
[21:43:07] [DEBUG] CMySQLQuery::Execute - starting query execution
[21:43:07] [DEBUG] CMySQLQuery::Execute - query was successfully executed within 184.578 milliseconds
[21:43:07] [DEBUG] CMySQLResult::CMySQLResult() - constructor called
[21:43:07] [DEBUG] CMySQLHandle::SaveActiveResult - cache saved (id: 1)
[21:43:07] [DEBUG] cache_get_row_count - connection: 1
[21:43:07] [DEBUG] cache_delete - cache_id: 1, connection: 1
[21:43:07] [DEBUG] CMySQLResult::~CMySQLResult() - deconstructor called
[21:43:07] [DEBUG] CMySQLHandle::DeleteSavedResult - result deleted 


[Squirrel]

BUMP

[CoaPsyFactor]

i think that u are trying to get IP as int using cache_get_row_int try cache_get_row instead

[BroZeus]

Try this :

PHP код:

IPBanned(const str[]) 
{ 
    new query[85],Cache:result,rows;
    // you dont really need to select anything if you just need to check if ip is there
    // you can just use row count to see if ip exists or not
    // notice change in query here and always use %e
    mysql_format(mysql, query, sizeof(query), "SELECT NULL FROM `ipbanned` WHERE `IP` = '%e' LIMIT 1",str); 
    result = mysql_query(mysql, query); 
    rows = cache_num_rows();
    cache_delete(result); 
    return rows; 
}