1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
SQL SAVing
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#1

25.06.2015, 22:00
what's wrong with it?

PHP код:
forward OnPlayerSave(playerid);
public OnPlayerSave(playerid)
{
    new query[500];
    if(IsLoggedIn[playerid] == 1 && playerid != INVALID_PLAYER_ID && !IsPlayerNPC(playerid))
    {
        strcat(query, "UPDATE `players` SET `Admin`=%d, `Vip`=%d, `Money`=%d, `Score`=%d, `Deaths`=%d, `Kills`=%d, `HitsCompleted`=%d, `SkinID`=%d, `Robbed`=%d, `RobbedMoney`=%d, `GotRobbed`=%d, `GotRobbedMoney`=%d, `StoreRobbed`=%d, `StoreRobbedMoney`=%d, `FoodPurchased`=%d, `FoodPurchasedMoney`=%d, `WeaponsPurchased`=%d, `WeaponsPurchasedMoney`=%d, `Healed`=%d, `Arrest`=%d, `Busted`=%d,");
        strcat(query, "`Crimes`=%d, `WantedLevel`=%d, `Medical`=%d WHERE `ID`=%d AND `user`='%e'",);
        pInfo[playerid][pAdmin], pInfo[playerid][pVip], GetPlayerMoney(playerid), GetPlayerScore(playerid), pInfo[playerid][pDeaths], pInfo[playerid][pKills],
        pInfo[playerid][pHitsCompleted], GetPlayerSkin(playerid), pInfo[playerid][pRobbed], pInfo[playerid][pRobbedMoney], pInfo[playerid][pGotRobbed], pInfo[playerid][pGotRobbedMoney],
        pInfo[playerid][pStoreRobbed], pInfo[playerid][pStoreRobbedMoney], pInfo[playerid][pFoodPurchased], pInfo[playerid][pFoodPurchasedMoney],
        pInfo[playerid][pWeaponsPurchased], pInfo[playerid][pWeaponsPurchasedMoney], pInfo[playerid][pHealed], pInfo[playerid][pArrest],
        pInfo[playerid][pBusted], pInfo[playerid][pCrimes], pInfo[playerid][pWantedLevel], pInfo[playerid][pMedical],
        pInfo[playerid][pID], PlayerName(playerid));
        mysql_tquery(MySQLCon, query, "", "");
        print(query);
        mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `IsBanned`=%d WHERE `ID`=%d AND user='%e'", pInfo[playerid][pIsBanned], PlayerName(playerid));
        mysql_tquery(MySQLCon, query, "", "");
        IsLoggedIn[playerid] = 0;
        if(pInfo[playerid][pAdmin] >= 1)
        {
            mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `AdminName`=%s WHERE `ID`=%d AND `user`='%e'", pInfo[playerid][pAName]);
            return true;
        }
    }
    return 1;
} 
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#2

25.06.2015, 22:07
Okay aight after doing this.

PHP код:
5593) : error 001: expected token: "-string end-", but found "-identifier-"
(5593) : error 017: undefined symbol "players"
 (5593): warning 215: expression has no effect
5593) : error 001: expected token: ";", but found ")"
(5593) : fatal error 107: too many error messages on one line 
PHP код:
forward OnPlayerSave(playerid);
public OnPlayerSave(playerid)
{
    new query[500];
    if(IsLoggedIn[playerid] == 1 && playerid != INVALID_PLAYER_ID && !IsPlayerNPC(playerid))
    {
        strcat(query, "UPDATE `"players"` SET Admin ='%d', Vip ='%d', Money ='%d', Score ='%d', Deaths ='%d', Kills ='%d', HitsCompleted ='%d', SkinID ='%d', Robbed ='%d', RobbedMoney ='%d', GotRobbed ='%d', GotRobbedMoney ='%d', StoreRobbed ='%d', StoreRobbedMoney ='%d', FoodPurchased ='%d', FoodPurchasedMoney ='%d', WeaponsPurchased ='%d', WeaponsPurchasedMoney ='%d', Healed ='%d', Arrest ='%d', Busted='%d',");
        strcat(query, "Crimes ='%d', WantedLevel ='%d', Medical ='%d' WHERE ID ='%d' AND user ='%e'",);
        pInfo[playerid][pAdmin], pInfo[playerid][pVip], GetPlayerMoney(playerid), GetPlayerScore(playerid), pInfo[playerid][pDeaths], pInfo[playerid][pKills],
        pInfo[playerid][pHitsCompleted], GetPlayerSkin(playerid), pInfo[playerid][pRobbed], pInfo[playerid][pRobbedMoney], pInfo[playerid][pGotRobbed], pInfo[playerid][pGotRobbedMoney],
        pInfo[playerid][pStoreRobbed], pInfo[playerid][pStoreRobbedMoney], pInfo[playerid][pFoodPurchased], pInfo[playerid][pFoodPurchasedMoney],
        pInfo[playerid][pWeaponsPurchased], pInfo[playerid][pWeaponsPurchasedMoney], pInfo[playerid][pHealed], pInfo[playerid][pArrest],
        pInfo[playerid][pBusted], pInfo[playerid][pCrimes], pInfo[playerid][pWantedLevel], pInfo[playerid][pMedical],
        pInfo[playerid][pID], PlayerName(playerid));
        mysql_tquery(MySQLCon, query, "", "");
        print(query);

        mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `IsBanned`=%d WHERE `ID`=%d AND user='%e'", pInfo[playerid][pIsBanned], PlayerName(playerid));
        mysql_tquery(MySQLCon, query, "", "");
        IsLoggedIn[playerid] = 0;
        if(pInfo[playerid][pAdmin] >= 1)
        {
            mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `AdminName`=%s WHERE `ID`=%d AND `user`='%e'", pInfo[playerid][pAName]);
            return true;
        }
    }
    return 1;
} 
Find
Reply
Stanford
Gangsta
*****
Posts: 983
Threads: 98
Joined: Feb 2012
Reputation: 0
#3

25.06.2015, 22:08
What about this?:

pawn Код:
if(pInfo[playerid][pAdmin] >= 1) 
        { 
            mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `AdminName`=%s WHERE `ID`=%d AND `user`='%e'", pInfo[playerid][pAName]); 
            return true; 
        }
you basically do not send this just format the string!
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#4

25.06.2015, 22:10
Nah. The problem is on line 5593

Which is
PHP код:
strcat(query, "UPDATE `"players"` SET Admin ='%d', Vip ='%d', Money ='%d', Score ='%d', Deaths ='%d', Kills ='%d', HitsCompleted ='%d', SkinID ='%d', Robbed ='%d', RobbedMoney ='%d', GotRobbed ='%d', GotRobbedMoney ='%d', StoreRobbed ='%d', StoreRobbedMoney ='%d', FoodPurchased ='%d', FoodPurchasedMoney ='%d', WeaponsPurchased ='%d', WeaponsPurchasedMoney ='%d', Healed ='%d', Arrest ='%d', Busted='%d',"); 
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#5

25.06.2015, 23:28
need it urgent pls some1 help
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#6

26.06.2015, 08:59
Im still stuck on this. Anyone help me? I would be your thankful.
Find
Reply
J0sh...
Banned
Posts: 1,276
Threads: 6
Joined: Aug 2014
#7

26.06.2015, 09:48
Why do you have players in " marks? `players`
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#8

26.06.2015, 09:54
Well, I changed into this

PHP код:
///mysql start
forward OnPlayerSave(playerid);
public OnPlayerSave(playerid)
{
    new query[500];
    new tmp[64];
    if(IsLoggedIn[playerid] == 1 && playerid != INVALID_PLAYER_ID && !IsPlayerNPC(playerid))
    {
        format( query, sizeof( query ), "UPDATE `players` SET " );
        
        format( tmp, sizeof( tmp ), "`Admin`=%d, ", pInfo[playerid][pAdmin]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Vip`=%d, ", pInfo[playerid][pVip]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Money`=%d, ", GetPlayerCash(playerid));
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Deaths`=%d, ", pInfo[playerid][pDeaths]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Kills`=%d, ", pInfo[playerid][pKills]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`HitsCompleted`=%d, ", pInfo[playerid][pHitsCompleted]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`SkinID`=%d, ", pInfo[playerid][pDeaths]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Robbed`=%d, ", pInfo[playerid][pRobbed]);
        strcat( query, tmp );

        format( tmp, sizeof( tmp ), "`RobbedMoney`=%d, ", pInfo[playerid][pRobbedMoney]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`GotRobbed`=%d, ", pInfo[playerid][pGotRobbed]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`GotRobbedMoney`=%d, ", pInfo[playerid][pGotRobbedMoney]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`StoreRobbed`=%d, ", pInfo[playerid][pStoreRobbed]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`StoreRobbedMoney`=%d, ", pInfo[playerid][pStoreRobbedMoney]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`FoodPurchased`=%d, ", pInfo[playerid][pFoodPurchased]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`FoodPurchasedMoney`=%d, ", pInfo[playerid][pFoodPurchasedMoney]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`WeaponsPurchased`=%d, ", pInfo[playerid][pWeaponsPurchased]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`WeaponsPurchasedMoney`=%d, ", pInfo[playerid][pWeaponsPurchasedMoney]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Healed`=%d, ", pInfo[playerid][pHealed]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Arrest`=%d, ", pInfo[playerid][pArrest]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Busted`=%d, ", pInfo[playerid][pBusted]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Crimes`=%d, ", pInfo[playerid][pCrimes]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`WantedLevel`=%d, ", pInfo[playerid][pWantedLevel]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Drugs`=%d, ", pInfo[playerid][pDrugs]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Medical`=%d, ", pInfo[playerid][pMedical]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "`Drugs`=%d, ", pInfo[playerid][pDrugs]);
        strcat( query, tmp );
        
        format( tmp, sizeof( tmp ), "WHERE `ID`= %d AND `user`= '%e'", pInfo[playerid][pID], PlayerName(playerid));
        strcat( query, tmp );
        mysql_tquery(MySQLCon, query, "", "");
        print(query);

        mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `IsBanned`=%d WHERE `ID`=%d AND user='%e'", pInfo[playerid][pIsBanned], PlayerName(playerid));
        mysql_tquery(MySQLCon, query, "", "");
        IsLoggedIn[playerid] = 0;
        if(pInfo[playerid][pAdmin] >= 1)
        {
            mysql_format(MySQLCon, query, sizeof(query), "UPDATE `players` SET `AdminName`=%s WHERE `ID`=%d AND `user`='%e'", pInfo[playerid][pAName]);
            return true;
        }
    }
    return 1;
} 
But this doesn't update my database.
Find
Reply
STONEGOLD
Huge Clucker
****
Posts: 312
Threads: 83
Joined: Feb 2012
Reputation: 0
#9

26.06.2015, 10:10
Someone help me? I have been asking for help from yesterday? Rly Nobody wants to help me?
Find
Reply
Prokill911
Huge Clucker
***
Posts: 228
Threads: 25
Joined: Jan 2015
Reputation: 0
#10

26.06.2015, 12:16
Quote:
Originally Posted by STONEGOLD
Посмотреть сообщение
Nah. The problem is on line 5593

Which is
PHP код:
strcat(query, "UPDATE `"players"` SET Admin ='%d', Vip ='%d', Money ='%d', Score ='%d', Deaths ='%d', Kills ='%d', HitsCompleted ='%d', SkinID ='%d', Robbed ='%d', RobbedMoney ='%d', GotRobbed ='%d', GotRobbedMoney ='%d', StoreRobbed ='%d', StoreRobbedMoney ='%d', FoodPurchased ='%d', FoodPurchasedMoney ='%d', WeaponsPurchased ='%d', WeaponsPurchasedMoney ='%d', Healed ='%d', Arrest ='%d', Busted='%d',"); 

simply put...
You're referencing completely wrong....

INCORRECT CODE
PHP код:
strcat(query, "UPDATE `"players"` SET Admin ='%d', Vip ='%d', Money ='%d', Score ='%d', Deaths ='%d', Kills ='%d', HitsCompleted ='%d', SkinID ='%d', Robbed ='%d', RobbedMoney ='%d', GotRobbed ='%d', GotRobbedMoney ='%d', StoreRobbed ='%d', StoreRobbedMoney ='%d', FoodPurchased ='%d', FoodPurchasedMoney ='%d', WeaponsPurchased ='%d', WeaponsPurchasedMoney ='%d', Healed ='%d', Arrest ='%d', Busted='%d',"); 
CORRECT CODE
PHP код:
strcat(query, "UPDATE `players` SET `Admin` = %d, `Vip` = %d, `Money` = %d 
PLEASE NOTE
IF You're REFERENCING A STRING.....
PHP код:
"UPDATE `players` SET `username` = '%s' 
SQL Syntax doesn't require nor accept quotations around an integer.. ONLY A string / variable with characters.

So...

%d would be %d when referenced via SQL
%s would be '%s' when referenced via SQL
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help