[Su37Erich]

Today I noticed the following exploit, searching for run time erros:

PHP код:

[19:15:07] [join] CUC99F81WBDMY215PMB2 has joined the server (6:132.255.80.76)
[19:15:07] Player 'CUC99F81WBDMY215PMB2' has just connected.
[19:15:07] [join] SMLP7ZSDAGQIS84T9KXK has joined the server (6:132.255.80.76)
[19:15:07] Player 'SMLP7ZSDAGQIS84T9KXK' has just connected.
[19:15:07] [join] FCAJXMLJZ67GF0UJXPJX has joined the server (6:132.255.80.76)
[19:15:07] Player 'FCAJXMLJZ67GF0UJXPJX' has just connected.
[19:15:07] [join] Z6VMWZQEKAZB8G696HK6 has joined the server (6:132.255.80.76)
[19:15:07] Player 'Z6VMWZQEKAZB8G696HK6' has just connected.
[19:15:07] [join] PJ46QAED3M4B5965TX7T has joined the server (6:132.255.80.76)
[19:15:07] Player 'PJ46QAED3M4B5965TX7T' has just connected.
....
...
...
About 30 lines 


After it a lot of:

PHP код:

[19:15:07] [debug] Run time error 4: "Array index out of bounds"
[19:15:07] [debug]  Accessing element at index 85 past array upper bound 84
[19:15:07] [debug] AMX backtrace:
[19:15:07] [debug] #0 00008df8 in PlayerBar:CreatePlayerProgressBar (playerid=6, Float:x=46.00000, Float:y=306.00000, Float:width=88.50000, Float:height=1.50000, color=16713983, Float:max=1000.00000) at C:\Users\Erich\****** Drive\Server\pawno\include\progressbar.inc:81
[19:15:07] [debug] #1 0001417c in public SSCANF_OnPlayerConnect (playerid=6) at TheUn.pwn:1624
[19:15:07] [debug] #2 00002514 in public Itter_OnPlayerConnect (playerid=6) at C:\Users\Erich\****** Drive\Server\pawno\include\sscanf2.inc:205
[19:15:07] [debug] #3 0000108c in public OnPlayerConnect (playerid=6) at C:\Users\Erich\****** Drive\Server\Servidor SA-MP\pawno\include\YSI\y_iterate.inc:646
[19:15:07] [join] YDZJXOIZSG77JF5KCX40 has joined the server (6:132.255.80.76)
[19:15:07] [debug] Run time error 4: "Array index out of bounds" 


It seems that there is a new exploit
Have anyone noticed this too?

[Locky_]

PHP код:

[19:15:07] [join] CUC99F81WBDMY215PMB2 has joined the server (6:132.255.80.76)
[19:15:07] Player 'CUC99F81WBDMY215PMB2' has just connected.
[19:15:07] [join] SMLP7ZSDAGQIS84T9KXK has joined the server (6:132.255.80.76)
[19:15:07] Player 'SMLP7ZSDAGQIS84T9KXK' has just connected.
[19:15:07] [join] FCAJXMLJZ67GF0UJXPJX has joined the server (6:132.255.80.76)
[19:15:07] Player 'FCAJXMLJZ67GF0UJXPJX' has just connected.
[19:15:07] [join] Z6VMWZQEKAZB8G696HK6 has joined the server (6:132.255.80.76)
[19:15:07] Player 'Z6VMWZQEKAZB8G696HK6' has just connected.
[19:15:07] [join] PJ46QAED3M4B5965TX7T has joined the server (6:132.255.80.76)
[19:15:07] Player 'PJ46QAED3M4B5965TX7T' has just connected. 


This can be solved by script.

[Su37Erich]

Maybe I'm just reporting this exploit

[iZN]

Quote:

[19:15:07] [debug] Run time error 4: "Array index out of bounds" [19:15:07] [debug] Accessing element at index 85 past array upper bound 84

are you sure you don't have any arrays which might be not enough for the process?

[JernejL]

looks like your progressbar script ran out of slots, that is your script bug.

Anyways the issue is, a player can send onplayerconnect twice, you should block and kick() AND rcon banip the ip if that occurs - set a flag on onplayerconnect and clear it in onplayerdisconnect, if it's calling onplayerconnect without a disconnect earlier then it's some asshole playing with a exploit.

I guess you just allocate a progressbar on connect and ran out of it due to multiple onplayerconnect spams.

[Su37Erich]

Thank you for the info and take a look on this, I'll make some changes! Thread solved I guess.