Checking the register system
#1

Hi guys, I've been a SA-MP player for a while and registered last year. This is my first post.

I want to create a gamemode so I just followed a tutorial (more a copy past to be honest!) of how to use Y_INI. The tutorial in question was: Login and Register System - Dialogs - Using Y_INI by Kush.

I found some problems and tried to correct it on my own. (I'll hash the passwords later, I just didn't want to use udb_hash).

Код:
#include <a_samp>
#include <YSI\YSI\y_ini>

#if defined MAX_PLAYERS
	#undef MAX_PLAYERS
#endif
#define MAX_PLAYERS 50

enum
{
	DIALOG_REGISTER,
	DIALOG_LOGIN,
	DIALOG_SUCCESS_1,
	DIALOG_SUCCESS_2
}

enum pInfo
{
    pPass[17],
    pCash,
    pAdmin,
    pKills,
    pDeaths,
    pLoggedin
}
new PlayerInfo[MAX_PLAYERS][pInfo];

#define PATH "/Users/%s.ini"

#define COL_WHITE "{FFFFFF}"
#define COL_RED "{F81414}"
#define COL_GREEN "{00FF22}"
#define COL_LIGHTBLUE "{00CED1}"

main()
{
	print("\n----------------------------------");
	print(" Blank Gamemode by your name here");
	print("----------------------------------\n");
}

public OnGameModeInit()
{
	SetGameModeText("Blank Script");
	AddPlayerClass(0, 1958.3783, 1343.1572, 15.3746, 269.1425, 0, 0, 0, 0, 0, 0);
	return 1;
}

public OnGameModeExit()
{
	return 1;
}


public OnPlayerConnect(playerid)
{
    PlayerInfo[playerid][pLoggedin] = 0;
    load_user_info(playerid);
    return 1;
}

forward load_user_info(playerid);
public load_user_info(playerid)
{
	if(fexist(UserPath(playerid)))
    {
        INI_ParseFile(UserPath(playerid), "LoadUser_%s", .bExtra = true, .extra = playerid);
        ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT,""COL_WHITE"Login",""COL_WHITE"Type your password below to login.","Login","Quit");
    }
    else
    {
        ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT,""COL_WHITE"Registering...",""COL_WHITE"Type your password below to register a new account.","Register","Quit");
    }
	return 1;
}

public OnPlayerDisconnect(playerid, reason)
{
    if(fexist(UserPath(playerid)) && PlayerInfo[playerid][pLoggedin] == 1)
    {
		new INI:File = INI_Open(UserPath(playerid));
	    INI_SetTag(File,"data");
	    INI_WriteInt(File,"Cash",GetPlayerMoney(playerid));
	    INI_WriteInt(File,"Admin",PlayerInfo[playerid][pAdmin]);
	    INI_WriteInt(File,"Kills",PlayerInfo[playerid][pKills]);
	    INI_WriteInt(File,"Deaths",PlayerInfo[playerid][pDeaths]);
	    INI_Close(File);
	    PlayerInfo[playerid][pLoggedin] = 0;
	}
    return 1;
}

public OnPlayerDeath(playerid, killerid, reason)
{
	if(killerid != INVALID_PLAYER_ID)
	{
		PlayerInfo[killerid][pKills]++;
	}
    PlayerInfo[playerid][pDeaths]++;
    return 1;
}

public OnDialogResponse(playerid, dialogid, response, listitem, inputtext[])
{
    switch( dialogid )
    {
        case DIALOG_REGISTER:
        {
            if (!response)
			{
            	SetSpawnInfo(playerid, 0, 0, 1958.33, 1343.12, 15.36, 269.15, 0, 0, 0, 0, 0, 0);
                SpawnPlayer(playerid);
            }
            if(response)
            {
                if(!strlen(inputtext)) return ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT, ""COL_WHITE"Registering...",""COL_RED"You have entered an invalid password.\n"COL_WHITE"Type your password below to register a new account.","Register","Quit");
                new INI:File = INI_Open(UserPath(playerid));
                INI_SetTag(File,"data");
                INI_WriteString(File,"Password",inputtext);
                INI_WriteInt(File,"Cash",0);
                INI_WriteInt(File,"Admin",0);
                INI_WriteInt(File,"Kills",0);
                INI_WriteInt(File,"Deaths",0);
                INI_Close(File);
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT,""COL_WHITE"Login",""COL_WHITE"Type your password below to login.","Login","Quit");
			}
        }

        case DIALOG_LOGIN:
        {
            if ( !response ) return Kick ( playerid );
            load_user_info(playerid); Shall I load this here or just on OnPlayerConnect?
            if( response )
            {
				if(!strcmp(inputtext, PlayerInfo[playerid][pPass]))
                {
                    //INI_ParseFile(UserPath(playerid), "LoadUser_%s", .bExtra = true, .extra = playerid);
                    GivePlayerMoney(playerid, PlayerInfo[playerid][pCash]);
					ShowPlayerDialog(playerid, DIALOG_SUCCESS_2, DIALOG_STYLE_MSGBOX,""COL_WHITE"Success!",""COL_GREEN"You have successfully logged in!","Ok","");
                    PlayerInfo[playerid][pLoggedin] = 1;
				}
                else
                {
                    ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT,""COL_WHITE"Login",""COL_RED"You have entered an incorrect password.\n"COL_WHITE"Type your password below to login.","Login","Quit");
                }
                return 1;
            }
        }
    }
    return 1;
}

public OnPlayerRequestClass(playerid, classid)
{
	SetPlayerPos(playerid, 1958.3783, 1343.1572, 15.3746);
	SetPlayerCameraPos(playerid, 1958.3783, 1343.1572, 15.3746);
	SetPlayerCameraLookAt(playerid, 1958.3783, 1343.1572, 15.3746);
	return 1;
}

public OnPlayerCommandText(playerid, cmdtext[])
{
	if (strcmp("/help", cmdtext, true) == 0)
	{
        return 1;
	}
	return 0;
}

forward LoadUser_data(playerid,name[],value[]);
public LoadUser_data(playerid,name[],value[])
{
    INI_String("Password",PlayerInfo[playerid][pPass], 17);
    INI_Int("Cash",PlayerInfo[playerid][pCash]);
    INI_Int("Admin",PlayerInfo[playerid][pAdmin]);
    INI_Int("Kills",PlayerInfo[playerid][pKills]);
    INI_Int("Deaths",PlayerInfo[playerid][pDeaths]);
    return 1;
}

stock UserPath(playerid)
{
    new string[128],playername[MAX_PLAYER_NAME];
    GetPlayerName(playerid,playername,sizeof(playername));
    format(string,sizeof(string),PATH,playername);
    return string;
}
There is some problems with spawning, but I'll focus on that later. I would like to know if Saving and Loading is done the right way. Thank you.

P.S. - The password size on the enum is for later use while registering.
Reply
#2

First of all, you need to read this.
Reply
#3

Quote:
Originally Posted by Yashas
Посмотреть сообщение
First of all, you need to read this.
Okay. I read it and started making the following.

http://pastebin.com/JineJgNa
Reply


Forum Jump:


Users browsing this thread: 3 Guest(s)