1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Little help with engine script
barts
Big Clucker
***
Posts: 143
Threads: 50
Joined: Jan 2014
Reputation: 0
#1

10.01.2014, 14:17
I want when the engine have lower than 25% health to dont start but it start
PHP код:
MD:engine(playerid, params[])
 {
GetVehicleHealth(vehicleid, vhp);
    if(vhp < 250.0)
    {
    SendClientMessage(playerid, COLOR_GREY, "You cant start the vehicle's engine when it is broken.");
    return 1;
    }
    new engine, lights, alarm, doors, bonnet, boot, objective, vehicleid, string[128];
       if(!IsPlayerLoggedIn(playerid)) return SendClientMessage(playerid, COLOR_GREY, "You need to login first before using any command.");
    if(GetPlayerState(playerid) != PLAYER_STATE_DRIVER) return SendClientMessage(playerid, COLOR_GREY, "You are not driving a vehicle.");
    if(vehicleid == 509 || vehicleid == 481 || vehicleid == 510) return SendClientMessage(playerid, COLOR_GREY, "Bicycles have no engine.");
    vehicleid = GetPlayerVehicleID(playerid);
    GetVehicleParamsEx(vehicleid, engine, lights, alarm, doors, bonnet, boot, objective);
    if(!engine)
    {
        SetVehicleParamsEx(vehicleid, 1, lights, alarm, doors, bonnet, boot, objective);
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh])
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);}
        else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh])
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);}
         else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh])
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);}
        {
         if(masked[playerid] == 1)
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine ON", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE);
         EngineStatus[playerid] = 1;
         }
        format(string, sizeof(string), "* %s turns the vehicle's engine ON", RPN(playerid));
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE);
         EngineStatus[playerid] = 1;
    }
    else
    {
    if(vhp < 250.0)
    {
    SendClientMessage(playerid, COLOR_GREY, "You cant start the vehicle's engine when it is broken.");
    return 1;
    }
        SetVehicleParamsEx(vehicleid, 0, lights, alarm, doors, bonnet, boot, objective);
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh])
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);}
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh])
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);}
         if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh])
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);}
        {
         if(masked[playerid] == 1)
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine OFF", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE);
         EngineStatus[playerid] = 0;
         }
        format(string, sizeof(string), "* %s turns the vehicle's engine OFF", RPN(playerid));
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE);
         EngineStatus[playerid] = 0;
    }
    return 1;
} 
Find
Reply
IceShock
Big Clucker
***
Posts: 51
Threads: 5
Joined: May 2013
Reputation: 0
#2

10.01.2014, 14:34
Your code with some notes.

Код:
CMD:engine(playerid, params[]) 
 { 
GetVehicleHealth(vehicleid, vhp); 
    if(vhp < 250.0) 
    { 
    SendClientMessage(playerid, COLOR_GREY, "You cant start the vehicle's engine when it is broken."); 
    return 1; 
    } // This will cause a lot of warnings
    new engine, lights, alarm, doors, bonnet, boot, objective, vehicleid, string[128]; 
       if(!IsPlayerLoggedIn(playerid)) return SendClientMessage(playerid, COLOR_GREY, "You need to login first before using any command."); 
    if(GetPlayerState(playerid) != PLAYER_STATE_DRIVER) return SendClientMessage(playerid, COLOR_GREY, "You are not driving a vehicle."); 
    if(vehicleid == 509 || vehicleid == 481 || vehicleid == 510) return SendClientMessage(playerid, COLOR_GREY, "Bicycles have no engine."); 
    vehicleid = GetPlayerVehicleID(playerid); 
    GetVehicleParamsEx(vehicleid, engine, lights, alarm, doors, bonnet, boot, objective); 
    if(!engine) 
    { 
        SetVehicleParamsEx(vehicleid, 1, lights, alarm, doors, bonnet, boot, objective); 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);} 
        else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);} 
         else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);} 
        { 
         if(masked[playerid] == 1) 
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine ON", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 1; 
         } 
        format(string, sizeof(string), "* %s turns the vehicle's engine ON", RPN(playerid)); 
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 1; 
    } 
    else 
    { 
    if(vhp < 250.0) 
    { 
    SendClientMessage(playerid, COLOR_GREY, "You cant start the vehicle's engine when it is broken."); 
    return 1; // This will cause error in the worst case.
    } 
        SetVehicleParamsEx(vehicleid, 0, lights, alarm, doors, bonnet, boot, objective); 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);} 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);} 
         if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);} 
        { 
         if(masked[playerid] == 1) 
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine OFF", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 0; 
         } 
        format(string, sizeof(string), "* %s turns the vehicle's engine OFF", RPN(playerid)); 
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 0; 
    } 
    return 1; 
}
Fixed code by me :

Код:
CMD:engine(playerid, params[]) 
 {
    new engine, lights, alarm, doors, bonnet, boot, objective, vehicleid, string[128]; 
       if(!IsPlayerLoggedIn(playerid)) return SendClientMessage(playerid, COLOR_GREY, "You need to login first before using any command."); 
    if(GetPlayerState(playerid) != PLAYER_STATE_DRIVER) return SendClientMessage(playerid, COLOR_GREY, "You are not driving a vehicle."); 
    if(vehicleid == 509 || vehicleid == 481 || vehicleid == 510) return SendClientMessage(playerid, COLOR_GREY, "Bicycles have no engine."); 
    vehicleid = GetPlayerVehicleID(playerid); 
    GetVehicleParamsEx(vehicleid, engine, lights, alarm, doors, bonnet, boot, objective); 
    if(!engine) 
    { 
        SetVehicleParamsEx(vehicleid, 1, lights, alarm, doors, bonnet, boot, objective); 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);} 
        else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);} 
         else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh]) 
        {SetVehicleParamsEx(vehicleid, 1, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);} 
        { 
         if(masked[playerid] == 1) 
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine ON", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 1; 
         } 
        format(string, sizeof(string), "* %s turns the vehicle's engine ON", RPN(playerid)); 
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 1; 
    } 
    else if(engine == VEHICLE_PARAMS_OFF || engine == VEHICLE_PARAMS_UNSET)
    { 		
		new Float: f_vHealth;
		GetVehicleHealth(vehicleid, f_vHealth);
		if(f_vHealth < 350.0) return SendClientMessageEx(playerid, COLOR_YourColor, "Your Message Here");
        SetVehicleParamsEx(vehicleid, 0, lights, alarm, doors, bonnet, boot, objective); 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vLocked], bonnet, boot, objective);} 
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVLocked], bonnet, boot, objective);} 
         if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pVVVeh]) 
        {SetVehicleParamsEx(vehicleid, 0, lights, alarm, PlayerInfo[playerid][vVVLocked], bonnet, boot, objective);} 
        { 
         if(masked[playerid] == 1) 
         SendNearbyMessage(playerid, 15, "Someone turns the vehicle's engine OFF", COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 0; 
         } 
        format(string, sizeof(string), "* %s turns the vehicle's engine OFF", RPN(playerid)); 
         SendNearbyMessage(playerid, 15, string, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE, COLOR_PURPLE); 
         EngineStatus[playerid] = 0; 
    } 
    return 1; 
}
I hope I helped you if there is some error popping up just reply and I will help you.
Find
Reply
barts
Big Clucker
***
Posts: 143
Threads: 50
Joined: Jan 2014
Reputation: 0
#3

10.01.2014, 14:38
You bugged it
Find
Reply
IceShock
Big Clucker
***
Posts: 51
Threads: 5
Joined: May 2013
Reputation: 0
#4

10.01.2014, 14:39
Remove this if(engine == VEHICLE_PARAMS_OFF || engine == VEHICLE_PARAMS_UNSET
Find
Reply
barts
Big Clucker
***
Posts: 143
Threads: 50
Joined: Jan 2014
Reputation: 0
#5

10.01.2014, 14:42
dont work
Find
Reply
newbie scripter
Gangsta
*****
Posts: 800
Threads: 48
Joined: Apr 2012
Reputation: 0
#6

10.01.2014, 14:47
pawn Код:
new Float:vhp;
if(GetVehicleHealth(playerid, vhp) < 250)
{
    new engine, lights, alarm, doors, bonnet, boot, objective;
GetVehicleParamsEx(vehicleid, engine, lights, alarm, doors, bonnet, boot, objective);
SetVehicleParamsEx(vehicleid, 0, lights, alarm, doors, bonnet, boot, objective); // ONLY the engine param was changed (to 0) (OFF)
    return 1;
} 
// other codes
Find
Reply
IceShock
Big Clucker
***
Posts: 51
Threads: 5
Joined: May 2013
Reputation: 0
#7

10.01.2014, 14:48
Try changing :

Код:
		new Float: f_vHealth;
		GetVehicleHealth(vehicleid, f_vHealth);
		if(f_vHealth < 350.0) return SendClientMessageEx(playerid, COLOR_YourColor, "Your Message Here");
To this :

Код:
GetVehicleHealth(vehicleid, vhp); 
    if(vhp < 250.0) return SendClientMessageEx(playerid, COLOR_YourColor, "Your Message Here");
Find
Reply
barts
Big Clucker
***
Posts: 143
Threads: 50
Joined: Jan 2014
Reputation: 0
#8

10.01.2014, 15:06
Dont work
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 3 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help