Login

lulo356 · 03.11.2013, 21:18

My rank System doenst work

Quote:

if(strcmp("/rank",cmdtext,true) == 0)
{
new targetid = GetPlayerName(targetid, name, sizeof(name));
format(string,sizeof(string),"-------------------------------RANK--------------------");
SendClientMessage(playerid,COLOR_BLACK,string);
format(string,sizeof(string),"Your KillScore is %d",KillScore[playerid]);
SendClientMessage(playerid,COLOR_RED,string);
format(string,sizeof(string),"You Died %d Times",DeathScore[playerid]);
SendClientMessage(playerid,COLOR_RED,string);

if(KillScore[playerid] == 0)
{
SendClientMessage(playerid,COLOR_RED,"Rank NOBODY");
Level[playerid] = 1;
}
else if(KillScore[playerid] == 1)
{
SendClientMessage(playerid,COLOR_RED,"Rank PUSSY");
Level[playerid] = 2;
}
else if(KillScore[playerid] == 2)
{
SendClientMessage(playerid,COLOR_RED,"Rank CRACKHEAD");
Level[playerid] = 3;
}
else if(KillScore[playerid] == 3)
{
SendClientMessage(playerid,COLOR_RED,"Rank CRACKHEAD");
Level[playerid] = 4;
}
else if(KillScore[playerid] == 4)
{
SendClientMessage(playerid,COLOR_RED,"Rank MURDER");
Level[playerid] = 5;
}
else if(KillScore[playerid] == 5)
{
SendClientMessage(playerid,COLOR_RED,"Rank MURDER");
Level[playerid] = 6;
}
else if(KillScore[playerid] == 6)
{
SendClientMessage(playerid,COLOR_RED,"Rank P.I.M.P.");
Level[playerid] = 7;
}
else if(KillScore[playerid] == 7)
{
SendClientMessage(playerid,COLOR_RED,"Rank P.I.M.P.");
Level[playerid] = 8;
}
else if(KillScore[playerid] ==

{
SendClientMessage(playerid,COLOR_RED,"Rank P.I.M.P");
Level[playerid] = 9;
}
else if(KillScore[playerid] == 9)
{
SendClientMessage(playerid,COLOR_RED,"Rank GANXSTA");
Level[playerid] = 10;
}
else if(KillScore[playerid] == 10)
{
SendClientMessage(playerid,COLOR_RED,"Rank GANXSTA");
Level[playerid] = 11;
}
else if(KillScore[playerid] == 11)
{
SendClientMessage(playerid,COLOR_RED,"Rank MOTHERFUCKER");
Level[playerid] = 12;
}
else if(KillScore[playerid] == 12)
{
SendClientMessage(playerid,COLOR_RED,"Rank MOTHERFUCKER");
Level[playerid] = 13;
}
else if(KillScore[playerid] == 13)
{
SendClientMessage(playerid,COLOR_RED,"Rank MOTHERFUCKER");
Level[playerid] = 14;
}
else if(KillScore[playerid] == 14)
{
SendClientMessage(playerid,COLOR_RED,"Rank 2PAC");
Level[playerid] = 15;
}
else if(KillScore[playerid] == 15)
{
SendClientMessage(playerid,COLOR_RED,"Rank 2PAC");
Level[playerid] = 16;
}
else if(KillScore[playerid] == 16)
{
SendClientMessage(playerid,COLOR_RED,"Rank 2PAC");
Level[playerid] = 17;
}
else if(KillScore[playerid] == 17)
{
SendClientMessage(playerid,COLOR_RED,"Rank PUBLIC_ENEMY");
Level[playerid] = 18;
}
else if(KillScore[playerid] == 1

{
SendClientMessage(playerid,COLOR_RED,"Rank PUBLIC_ENEMY");
Level[playerid] = 19;
}
else if(KillScore[playerid] == 19)
{
SendClientMessage(playerid,COLOR_RED,"Rank PUBLIC_ENEMY");
Level[playerid] = 20;
}
else if(KillScore[playerid] >= 20)
{
SendClientMessage(playerid,COLOR_RED,"Rank ----->PUBLIC_ENEMY_#1<-----");
SendClientMessage(playerid,COLOR_PURPLE,"You reached the highest Level!");
Level[playerid] = 21;
}
format(string,sizeof(string),"Level -->%d [of 21 Levels]",Level[playerid]);
SendClientMessage(playerid,COLOR_RED,string);
SendClientMessage(playerid,COLOR_BLACK,"------------------------------------------------------------");
return 1;
}

DefaultEx · 03.11.2013, 23:42

Show us the error exactly?

What happens when you use the command?

lulo356 · 03.11.2013, 23:46

Well, its just in game nothing is happening

EliteApple · 04.11.2013, 00:21

For one, all of them lines are useless, you can make it shorter.

Here's an example out of my script:

pawn Код:

new admtext[64];
            if(PlayerInfo[playerid][pAdministrator] == 6) { admtext = "Management"; }
            else if(PlayerInfo[playerid][pAdministrator] == 5) { admtext = "Lead Developer"; }
            else if(PlayerInfo[playerid][pAdministrator] == 4) { admtext = "Lead Administrator"; }
            else if(PlayerInfo[playerid][pAdministrator] == 3) { admtext = "Senior Administrator"; }
            else if(PlayerInfo[playerid][pAdministrator] == 2)  { admtext = "Administrator"; }
            else if(PlayerInfo[playerid][pAdministrator] == 1) { admtext = "Trial Administrator"; }
            else { admtext = "Unknown Admin"; }

Then,

pawn Код:

new string[156];
format(string, sizeof(string), "Rank: %s", admtext);
SendClientMessage(playerid, COLOR_RED, string);

There's an idea.

zT KiNgKoNg · 04.11.2013, 08:46

@EliteApple - actaully the way you've provided is in my opinion stupid because he'll need to put that into every command or function that needs to return the staff name or other string

For example i'd use this.

pawn Код:

stock ReturnString(playerid)
{
       new returnstr[100];
       switch(PlayerInfo[playerid][pAdministrator])
       {
              case 0: { format(returnstr,sizeof(returnstr),"None"); }
              // and case {num} ect
   

       }
       return returnstr;
}

EliteApple · 04.11.2013, 22:05

That is also another way to do it as stated above. Yeah.

Login
Username:
Password:	Lost Password?
	Remember me