Login

Glad2BeHere · 24.06.2013, 18:57

I would like to ask community members if anyone has a domain or a public web page where every can see my work.... or you have a web host and you wanna add a extra domain and give me a website so i can test these things online it would be appreciate but the only place to test this is on my localhost sooo..... :/ i'm working with.

This is Un-Tested and made for you to test....

No Graphics Was Added...

Made a Configuration file = Config.php

Login Page - This is to start Session and DB check

Background Page - Select Background (14) Backgrounds to choose from 10 gta related the rest is just things i like

Stats Page - Name says it

/imageshack/img22/3236/bvm.png

Download: http://www.mediafire.com/?svo4ydm453x9p15

FEEDBACK Is NEEDED and IS APPRECIATED

if u see any errors or will like to make any comments on this I'm always happy for criticism

ScripteRNaBEEL · 25.06.2013, 08:58

moce work

Sulps · 25.06.2013, 17:14

Tested

It Works like a Charm

Glad2BeHere · 25.06.2013, 18:16

Makes me feel good and doing more web work and better stuff for community members maybe a fully function website ,thank you for testing.....

R@f · 25.06.2013, 20:50

The idea is nice but not the code. I made a list of some negative points :

The HTML code is not indented.
CSS should be in a separated file.
The PHP code is badly structured (session_start for example should always be at the top).
echo"<html><head>header('Content-type:image/jpg');</head></html>"; wtf ?
SQL Injections.
Die function for error messages.
Old mysql functions that are deprecated in PHP 5.5. PDO should be used instead.
No SQL database is provided.
No comments at all.
No filterscript to use your project with.

There are a lot of improvements to do

Glad2BeHere · 25.06.2013, 22:29

echoing out html codes is a hassle
No really they invented style tags for a reason
Not necessary to start @ the top as its where i want to start the session
Its the only way to make the page as an image (as read by googling)
Die messages was used for some instances... i used where it was suit
I can use which mysql functions i feel free to use because its what i am comfortable using
Yead i should of given a .sql file :/
Comments :/
Filterscript? Y? its not need what so ever.... all u need in the mysql info...

Johnson_boy · 26.06.2013, 08:09

Quote:

Originally Posted by Glad2BeHere

I can use which mysql functions i feel free to use because its what i am comfortable using

Are you aware that the MySQL extension you are using has been deprecated from PHP? You should definitely use MySQLi or PDO.

What I am mostly concerned is the vulnerability to MySQL injections. That's something you should fix ASAP.

Quote:

Originally Posted by Glad2BeHere

Not necessary to start @ the top as its where i want to start the session

PHP starts a session by sending a cookie containing an unique session ID to the browser. Cookies must be sent at the same time as the rest of the headers are (i.e. the very first thing the page sends). Otherwise it does not work (depends on the server configuration, but usually it doesn't). You could use output buffers to overcome the issue, or just move the start_session to the beginning of the source.

And I agree with R@f about this:

Code:

echo"<html><head>header('Content-type:image/jpg');</head></html>";

What on earth is that? It's unnecessary and wrong. You are basically making another page, and echoing, not executing PHP's header function. Also, that header should be only sent, if your page contains nothing but the image, and should be treated like an image. if you're setting a background image, you shouldn't use it. Remove the line and everyone is happy.

R@f · 26.06.2013, 09:09

Quote:

Originally Posted by Glad2BeHere

echoing out html codes is a hassle

I'm talking about the HTML code in general. This is useful : http://www.granneman.com/webdev/codi...ing-your-html/

--

Quote:

Originally Posted by Glad2BeHere

No really they invented style tags for a reason

Yes, but the recommendation is to use it in a separated CSS file. It's better for the structure of the code and it can be easily used in multiple pages.

--

Quote:

Originally Posted by Glad2BeHere

Not necessary to start @ the top as its where i want to start the session

You should read the PHP documentation. http://php.net/manual/en/function.session-start.php
"To use cookie-based sessions, session_start() must be called before outputing anything to the browser."

--

Quote:

Originally Posted by Glad2BeHere

Its the only way to make the page as an image (as read by googling)

Well, using the header function is correct, but you are outputting as a text between html tags that have already been used, which is totally wrong. The correct way is :

Code:

<?php
     header('Content-type:image/jpg');
?>

And not :

Code:

<?php
     echo "<html><head>header('Content-type:image/jpg');</head></html>";
?>

--

Quote:

Originally Posted by Glad2BeHere

Die messages was used for some instances... i used where it was suit

Die is an alias of exit, which is used to stop the execution of a script. All the code after this function won't be shown, which is not ideal for the user friendliness. Errors can be displayed using echo.

--

Quote:

Originally Posted by Glad2BeHere

I can use which mysql functions i feel free to use because its what i am comfortable using

Again, read the PHP documentation, it's clearly written that the mysql functions are depreciated in PHP 5.5 which was released a few days ago. Check this link : http://php.net/manual/en/function.mysql-query.php

--

Quote:

Originally Posted by Glad2BeHere

Comments :/

Code comments (// or /* */). Useful for understanding your code.

--

Quote:

Originally Posted by Glad2BeHere

Filterscript? Y? its not need what so ever.... all u need in the mysql info...

It's always a plus to have a filterscript with this kind of release. For example a small FS to fill the database for each user of the sa-mp server.

Glad2BeHere · 26.06.2013, 16:58

Before you talk.... You need to have facts for what u have to say :/ ....cause if u tested it in that manor you would know that... u get a error code :3..........

PHP Code:



<?php
     header('Content-type:image/jpg');
?>

Inn0cent · 11.04.2014, 12:11

Tested, Works Good.

Sublime · 11.04.2014, 12:40

First of all, good try with this. Almost all of my complaints were exaggerated by R@f and Johnson_boy (thank you), so I just have 1 more question.

Quote:

echo"<html><head>header('Content-type:image/jpg');</head></html>";

What's the purpose of the <html><head> tags recurring in each and every echo code (2 actually xd) I see? Like, why don't you only use one time of those tags and enter the PHP codes under those tags?

Login
Username:
Password:	Lost Password?
	Remember me