1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive

Threaded Mode
Login script allows any password
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#1

18.07.2011, 09:09
When ive registered the server places the password in the user file but when i come to actually logging in say my password is password123 and i enter asdfjasdfjkf it still accepts it. Heres the code:

Код:
case DIALOG_LOGIN:
        {
            if ( !response ) return Kick ( playerid );
            if( response )
            {
                if(!strlen(inputtext)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an invalid password.\n"WHITE"Type your password below to login.","Login","Quit");
                }

                if(INI_Open(getINI(playerid))) {
                INI_ReadString(PlayerInfo[playerid][Pass],"Pass",20);

                if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
                }
                new Float:x, Float:y, Float:z, Float:a;
                SetPlayerScore(playerid, INI_ReadInt("Score"));
                ResetPlayerMoney(playerid);
                GivePlayerMoney(playerid, INI_ReadInt("Cash"));
				PlayerInfo[playerid][Admin] = INI_ReadInt("Admin");
				PlayerInfo[playerid][Skin] = INI_ReadInt("Skin");
				x = INI_ReadFloat("Savedpositionx");
				y = INI_ReadFloat("Savedpositiony");
				z = INI_ReadFloat("Savedpositionz");
				a = INI_ReadFloat("Savedpositiona");
				SetSpawnInfo(playerid, 0, PlayerInfo[playerid][Skin], x, y, z, a, 0, 0, 0, 0, 0, 0);
				SetPlayerInterior(playerid, 3);
				SpawnPlayer(playerid);
				INI_Close();
    			
                }
            }
        }
Find
Reply
Bakr
Gangsta
*****
Posts: 977
Threads: 10
Joined: Apr 2011
Reputation: 0
#2

18.07.2011, 09:12
You do not stop the code from executing even if the player gets the incorrect password. You can stop the code by adding a return 1; after this line, like so:
pawn Код:
ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
return 1;
Find
Reply
_Aleksandar
Little Clucker
**
Posts: 10
Threads: 0
Joined: Apr 2011
Reputation: 0
#3

18.07.2011, 09:12
try this..

Код:
if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) 
{
ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
return false;
}
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#4

18.07.2011, 09:16
Nope i am still able to enter a wrong password
Find
Reply
Bakr
Gangsta
*****
Posts: 977
Threads: 10
Joined: Apr 2011
Reputation: 0
#5

18.07.2011, 09:20
Make sure to replace returns after both times you show a dialog in that section of code:
pawn Код:
case DIALOG_LOGIN:
        {
            if ( !response ) return Kick ( playerid );
            if( response )
            {
                if(!strlen(inputtext)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an invalid password.\n"WHITE"Type your password below to login.","Login","Quit");
                return 1;
                }

                if(INI_Open(getINI(playerid))) {
                INI_ReadString(PlayerInfo[playerid][Pass],"Pass",20);

                if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
                return 1;
                }
                new Float:x, Float:y, Float:z, Float:a;
                SetPlayerScore(playerid, INI_ReadInt("Score"));
                ResetPlayerMoney(playerid);
                GivePlayerMoney(playerid, INI_ReadInt("Cash"));
                PlayerInfo[playerid][Admin] = INI_ReadInt("Admin");
                PlayerInfo[playerid][Skin] = INI_ReadInt("Skin");
                x = INI_ReadFloat("Savedpositionx");
                y = INI_ReadFloat("Savedpositiony");
                z = INI_ReadFloat("Savedpositionz");
                a = INI_ReadFloat("Savedpositiona");
                SetSpawnInfo(playerid, 0, PlayerInfo[playerid][Skin], x, y, z, a, 0, 0, 0, 0, 0, 0);
                SetPlayerInterior(playerid, 3);
                SpawnPlayer(playerid);
                INI_Close();
                
                }
            }
        }
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#6

18.07.2011, 09:23
thats what i have got that doesnt stop it.
Find
Reply
FireCat
High-roller
*****
Posts: 2,322
Threads: 260
Joined: Jul 2010
Reputation: 0
#7

18.07.2011, 09:30
pawn Код:
if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) return ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
Find
Reply
System64
Gangsta
*****
Posts: 933
Threads: 62
Joined: May 2011
Reputation: 0
#8

18.07.2011, 09:30
man I have the same problem, somebody should make a tutorial using y_ini and whirlpool :/
Find
Reply
Bakr
Gangsta
*****
Posts: 977
Threads: 10
Joined: Apr 2011
Reputation: 0
#9

18.07.2011, 09:32
@FireCat: Your code is doing nothing different than what mine and the other above poster's does.

@slymatt: Then I'm not convinced. Are you sure you're showing the player that dialog when they connect to insert their password? Are you saving, compiling and restarting the server before re-testing the script?
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#10

18.07.2011, 09:32
That still doesnt work and System64 im using SII =P
Find
Reply
MoroDan
Huge Clucker
****
Posts: 278
Threads: 0
Joined: Jun 2011
Reputation: 0
#11

18.07.2011, 09:34
Quote:
Originally Posted by slymatt
Посмотреть сообщение
When ive registered the server places the password in the user file but when i come to actually logging in say my password is password123 and i enter asdfjasdfjkf it still accepts it. Heres the code:

Код:
case DIALOG_LOGIN:
        {
            if ( !response ) return Kick ( playerid );
            if( response )
            {
                if(!strlen(inputtext)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an invalid password.\n"WHITE"Type your password below to login.","Login","Quit");
                }

                if(INI_Open(getINI(playerid))) {
                INI_ReadString(PlayerInfo[playerid][Pass],"Pass",20);

                if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) {
                ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
                }
                new Float:x, Float:y, Float:z, Float:a;
                SetPlayerScore(playerid, INI_ReadInt("Score"));
                ResetPlayerMoney(playerid);
                GivePlayerMoney(playerid, INI_ReadInt("Cash"));
				PlayerInfo[playerid][Admin] = INI_ReadInt("Admin");
				PlayerInfo[playerid][Skin] = INI_ReadInt("Skin");
				x = INI_ReadFloat("Savedpositionx");
				y = INI_ReadFloat("Savedpositiony");
				z = INI_ReadFloat("Savedpositionz");
				a = INI_ReadFloat("Savedpositiona");
				SetSpawnInfo(playerid, 0, PlayerInfo[playerid][Skin], x, y, z, a, 0, 0, 0, 0, 0, 0);
				SetPlayerInterior(playerid, 3);
				SpawnPlayer(playerid);
				INI_Close();
    			
                }
            }
        }
Try this:
PHP код:
case DIALOG_LOGIN:
{
    if(!response) return Kick ( playerid );
    if(!strlen(inputtext))
    {
        ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an invalid password.\n"WHITE"Type your password below to login.","Login","Quit");
        return 1;
    }
    if(INI_Open(getINI(playerid)))
    {
        INI_ReadString(PlayerInfo[playerid][Pass],"Pass",20);
        if(strcmp(inputtext,PlayerInfo[playerid][Pass],false))
        {
            ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit");
            return 1;
        }
        new Float:x, Float:y, Float:z, Float:a;
        SetPlayerScore(playerid, INI_ReadInt("Score"));
        ResetPlayerMoney(playerid);
        GivePlayerMoney(playerid, INI_ReadInt("Cash"));
        PlayerInfo[playerid][Admin] = INI_ReadInt("Admin");
        PlayerInfo[playerid][Skin] = INI_ReadInt("Skin");
        x = INI_ReadFloat("Savedpositionx");
        y = INI_ReadFloat("Savedpositiony");
        z = INI_ReadFloat("Savedpositionz");
        a = INI_ReadFloat("Savedpositiona");
        SetSpawnInfo(playerid, 0, PlayerInfo[playerid][Skin], x, y, z, a, 0, 0, 0, 0, 0, 0);
        SetPlayerInterior(playerid, 3);
        SpawnPlayer(playerid);
        INI_Close();
    }
} 
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#12

18.07.2011, 09:34
yes i am saving compiling and restarting the server before retesting
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#13

18.07.2011, 09:40
that doesnt work either.
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#14

18.07.2011, 16:09
is there a way of doing something like
Код:
if(PlayerInfo[playerid][Pass] == inputtext)
I just cant work it out.
Find
Reply
iggy1
High-roller
*****
Posts: 2,421
Threads: 52
Joined: Mar 2009
Reputation: 0
#15

18.07.2011, 16:38
This will check if the password stored in the playerinfo var matches the string that inputtext holds.
pawn Код:
if(!strcmp(PlayerInfo[playerid][Pass], inputtext))
Find
Reply
_Aleksandar
Little Clucker
**
Posts: 10
Threads: 0
Joined: Apr 2011
Reputation: 0
#16

18.07.2011, 16:39
OMG you must return false; not true...
here:
Код:
if(!strlen(inputtext)) 
    { 
        ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an invalid password.\n"WHITE"Type your password below to login.","Login","Quit"); 
        return 1; 
    }
and here:
Код:
 if(strcmp(inputtext,PlayerInfo[playerid][Pass],false)) 
        { 
            ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit"); 
            return 1; 
        }
also you can return ShowPlayerDialog(playerid, DIALOG_LOGIN, DIALOG_STYLE_INPUT, ""WHITE"Login",""RED"You have entered an incorrect password.\n"WHITE"Type your password below to login.","Login","Quit"); without returning false...
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#17

18.07.2011, 16:46
i have already tried false and returning ShowPlayerDialog neither work
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#18

18.07.2011, 16:51
And iggy that didnt work either ='(
Find
Reply
Jofi
Big Clucker
***
Posts: 159
Threads: 10
Joined: May 2009
Reputation: 0
#19

18.07.2011, 17:49
I had once something like this when password encryption didn't work correctly.
When i opened that account file "password= " part was empty and script allowed to use any password at login..

Soo.. check account file to make sure there is password saved.

E: Oh sorry didn't read whole post.
Find
Reply
slymatt
Huge Clucker
***
Posts: 201
Threads: 43
Joined: Apr 2011
Reputation: 0
#20

18.07.2011, 21:38
dang this is a bad things ='( i cant work it out at all haha thanks for trying though jofi
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive