1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive

Threaded Mode
A Little mysql optimization
wups
High-roller
*****
Posts: 1,216
Threads: 59
Joined: Apr 2010
Reputation: 0
#1

15.10.2010, 16:19
Anyone know a way to optimize this script? It hangs a server for ~2seconds on centos. On debian i didn't have this problem.
pawn Код:
stock SavePlayer(playerid, bool:simple)
{
    new query[1536],weps[2][12],Float:coo[3],IP[20];
    GetPlayerPos(playerid,coo[0],coo[1],coo[2]);
    GetPlayerIp(playerid,IP,sizeof(IP));
    for (new tmp=0; tmp<12; tmp++) GetPlayerWeaponData(playerid,tmp,weps[0][tmp],weps[1][tmp]);

    format(query,sizeof(query),"SELECT * FROM `Account` WHERE `Name`='%s'",ReturnName(playerid));
    mysql_store_result();
    if(!mysql_num_rows())
    {
        new userquery[256];
        format(userquery,sizeof(userquery),"INSERT INTO `Account` (`Name`) VALUES ('%s')",ReturnName(playerid));
        mysql_query(userquery);
        mysql_free_result();
    }
    mysql_free_result();
    if(!simple)
    {
        format(query,sizeof(query),"UPDATE `Account` SET `Money.Pocket` = %i, `Money.Bank` = %i, Seklos = %i, Zole = %i, Biznis = %i, Wanted = %i, Gangas = %i, Kalejime = %i, Mobsas = %i, Namu = %i, Ginklas0 = %i, Ammo0 = %i,Ginklas1 = %i, Ammo1 = %i,Ginklas2 = %i, Ammo2 = %i,Ginklas3 = %i, Ammo3 = %i,Ginklas4 = %i, Ammo4 = %i,Ginklas5 = %i, Ammo5 = %i,Ginklas6 = %i, Ammo6 = %i,",
        GetPlayerMoneyA(playerid),playerDB[playerid][banke],playerDB[playerid][seklos],playerDB[playerid][zole],playerDB[playerid][biznis],GetPlayerWantedLevel(playerid),playerDB[playerid][pgang],
        playerDB[playerid][kalejimo_laikas],playerDB[playerid][mobsas],playerDB[playerid][namu],
        weps[0][0],weps[1][0],weps[0][1],weps[1][1],weps[0][2],weps[1][2],weps[0][3],weps[1][3],weps[0][4],weps[1][4],weps[0][5],weps[1][5],weps[0][6],weps[1][6]);

        format(query,sizeof(query),"%s Ginklas7 = %i, Ammo7 = %i,Ginklas8 = %i, Ammo8 = %i,Ginklas9 = %i, Ammo9 = %i,Ginklas10 = %i, Ammo10 = %i,Ginklas11 = %i, Ammo11 = %i, Stilius = %i, pBoxiSkill = %i, pKneeSkill = %i, pKungSkill = %i, pGrabSkill = %i, pElbowSkill = %i, Job = %i, Drabuziai = %i, Uniforma = %i, Uniformd = %i, Adminas = %i, Xp = %i, Lytis = %i,",
        query,weps[0][7],weps[1][7],weps[0][8],weps[1][8],weps[0][9],weps[1][9],weps[0][10],weps[1][10],weps[0][11],weps[1][11],playerDB[playerid][pFS],playerDB[playerid][pBoxiSkill],playerDB[playerid][pKneeSkill],playerDB[playerid][pKungSkill],playerDB[playerid][pGrabSkill],playerDB[playerid][pElbowSkill],playerDB[playerid][specialybe],playerDB[playerid][drabuziai],playerDB[playerid][uniforma],playerDB[playerid][uniformd],playerDB[playerid][admin],GetPlayerScore(playerid),playerDB[playerid][lytis]);

        format(query,sizeof(query),"%s pos_X = '%f', pos_Y = '%f', pos_Z = '%f', Interior = %i, Drugs = %i, MotoLicense = %i, SLicense = %i, Laikrodis = %i, Namie = %i, World = %i, Insurance = %i, Teises = %i,Teorinis = %i, Kortele = %i, Imtuvas = %i, IP = '%s' WHERE Name = '%s'",
        query,coo[0],coo[1],coo[2],GetPlayerInterior(playerid),playerDB[playerid][narkotikai],playerDB[playerid][teisesm],playerDB[playerid][teisess],playerDB[playerid][laikrodis],playerDB[playerid][namie], GetPlayerVirtualWorld(playerid),playerDB[playerid][draudimas],playerDB[playerid][teises],playerDB[playerid][teor],playerDB[playerid][kortele],playerDB[playerid][imtuvas],IP,ReturnName(playerid));
    }
    else
    {
        format(query,sizeof(query),"UPDATE `Account` SET `Money.Pocket` = %i, `Money.Bank` = %i, Seklos = %i, Zole = %i, Biznis = %i, Wanted = %i, Gangas = %i, Kalejime = %i, Mobsas = %i, Namu = %i, Ginklas0 = %i, Ammo0 = %i,Ginklas1 = %i, Ammo1 = %i,Ginklas2 = %i, Ammo2 = %i,Ginklas3 = %i, Ammo3 = %i,Ginklas4 = %i, Ammo4 = %i,Ginklas5 = %i, Ammo5 = %i,Ginklas6 = %i, Ammo6 = %i,",
        GetPlayerMoneyA(playerid),playerDB[playerid][banke],playerDB[playerid][seklos],playerDB[playerid][zole],playerDB[playerid][biznis],GetPlayerWantedLevel(playerid),
        playerDB[playerid][pgang],playerDB[playerid][kalejimo_laikas],playerDB[playerid][mobsas],playerDB[playerid][namu],
        weps[0][0],weps[1][0],weps[0][1],weps[1][1],weps[0][2],weps[1][2],weps[0][3],weps[1][3],weps[0][4],weps[1][4],weps[0][5],weps[1][5],weps[0][6],weps[1][6]);

        format(query,sizeof(query),"%s Ginklas7 = %i, Ammo7 = %i,Ginklas8 = %i, Ammo8 = %i,Ginklas9 = %i, Ammo9 = %i,Ginklas10 = %i, Ammo10 = %i,Ginklas11 = %i, Ammo11 = %i, Job = %i, Uniforma = %i, Uniformd = %i, Adminas = %i, Drugs = %i, MotoLicense = %i, SLicense = %i, Namie = %i,Teises = %i,Lead = %i WHERE Name = '%s'",
        query,weps[0][7],weps[1][7],weps[0][8],weps[1][8],weps[0][9],weps[1][9],weps[0][10],weps[1][10],weps[0][11],weps[1][11],
        playerDB[playerid][specialybe],playerDB[playerid][uniforma],playerDB[playerid][uniformd],playerDB[playerid][admin],
        playerDB[playerid][narkotikai],playerDB[playerid][teisesm],playerDB[playerid][teisess],playerDB[playerid][namie],playerDB[playerid][teises],playerDB[playerid][plead],ReturnName(playerid));
    }
    mysql_query(query);
    return 1;
}
And This
pawn Код:
stock SaveMasina(playerid)
{
    new name[MAX_PLAYER_NAME];
    new var[100],query[300];
    GetPlayerName(playerid, name, sizeof(name));
    format(var, 100,"SELECT * FROM `Cars` WHERE `Owner` = '%s'",name);
    mysql_query(var);
    mysql_store_result();
    if(!mysql_num_rows())
    {
        format(query,300,"INSERT INTO `Cars` (`Owner`,`AH_Typ`,`AH2_Typ`,`AH3_Typ`,`AH_X`,`AH_Y`,`AH_Z`,`AH_Rot`,`AH2_X`,`AH2_Y`,`AH2_Z`,`AH2_Rot`,`AH3_X`,`AH3_Y`,`AH3_Z`,`AH3_Rot`) VALUES ('%s',-1,-1,-1,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000)",name);
        mysql_query(query);
    }
    mysql_free_result();
    format(var, 100, "UPDATE `Cars` SET AH_Typ=%i WHERE `Owner` = '%s'", Carlist[playerid][Typ],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_X='%f' WHERE `Owner` = '%s'", Carlist[playerid][X],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Y='%f' WHERE `Owner` = '%s'", Carlist[playerid][Y],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Z='%f' WHERE `Owner` = '%s'", Carlist[playerid][Z],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Rot='%f' WHERE `Owner` = '%s'", Carlist[playerid][Rotation],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Status=%i WHERE `Owner` = '%s'", Carlist[playerid][Status],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Lock=%i WHERE `Owner` = '%s'", Carlist[playerid][Lock],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Paintjob=%i WHERE `Owner` = '%s'", Carlist[playerid][Paintjob],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Color1=%i WHERE `Owner` = '%s'", Carlist[playerid][Color1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_Color2=%i WHERE `Owner` = '%s'", Carlist[playerid][Color2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod1=%i WHERE `Owner` = '%s'", Carlist[playerid][mod1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod2=%i WHERE `Owner` = '%s'", Carlist[playerid][mod2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod3=%i WHERE `Owner` = '%s'", Carlist[playerid][mod3],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod4=%i WHERE `Owner` = '%s'", Carlist[playerid][mod4],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod5=%i WHERE `Owner` = '%s'", Carlist[playerid][mod5],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod6=%i WHERE `Owner` = '%s'", Carlist[playerid][mod6],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod7=%i WHERE `Owner` = '%s'", Carlist[playerid][mod7],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod8=%i WHERE `Owner` = '%s'", Carlist[playerid][mod8],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod9=%i WHERE `Owner` = '%s'", Carlist[playerid][mod9],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod10=%i WHERE `Owner` = '%s'", Carlist[playerid][mod10],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod11=%i WHERE `Owner` = '%s'", Carlist[playerid][mod11],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod12=%i WHERE `Owner` = '%s'", Carlist[playerid][mod12],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod13=%i WHERE `Owner` = '%s'", Carlist[playerid][mod13],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod14=%i WHERE `Owner` = '%s'", Carlist[playerid][mod14],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod15=%i WHERE `Owner` = '%s'", Carlist[playerid][mod15],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod16=%i WHERE `Owner` = '%s'", Carlist[playerid][mod16],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH_mod17=%i WHERE `Owner` = '%s'", Carlist[playerid][mod17],name); mysql_query(var);
    if(Carlist[playerid][Carid]!=-1)
    {
        format(var, 100, "UPDATE `Cars` SET Sirena=%i WHERE `Owner` = '%s'", alarmed[Carlist[playerid][Carid]],name); mysql_query(var);
        format(var, 100, "UPDATE `Cars` SET Gas=%i WHERE `Owner` = '%s'", vehicleDB[Carlist[playerid][Carid]][gas],name); mysql_query(var);
    }
    format(var, 100, "UPDATE `Cars` SET AH2_Typ=%i WHERE `Owner` = '%s'", Carlist2[playerid][Typ],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_X='%f' WHERE `Owner` = '%s'", Carlist2[playerid][X],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Y='%f' WHERE `Owner` = '%s'", Carlist2[playerid][Y],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Z='%f' WHERE `Owner` = '%s'", Carlist2[playerid][Z],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Rot='%f' WHERE `Owner` = '%s'", Carlist2[playerid][Rotation],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Status=%i WHERE `Owner` = '%s'", Carlist2[playerid][Status],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Lock=%i WHERE `Owner` = '%s'", Carlist2[playerid][Lock],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Paintjob=%i WHERE `Owner` = '%s'", Carlist2[playerid][Paintjob],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Color1=%i WHERE `Owner` = '%s'", Carlist2[playerid][Color1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_Color2=%i WHERE `Owner` = '%s'", Carlist2[playerid][Color2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod1=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod2=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod3=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod3],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod4=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod4],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod5=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod5],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod6=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod6],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod7=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod7],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod8=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod8],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod9=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod9],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod10=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod10],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod11=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod11],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod12=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod12],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod13=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod13],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod14=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod14],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod15=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod15],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod16=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod16],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH2_mod17=%i WHERE `Owner` = '%s'", Carlist2[playerid][mod17],name); mysql_query(var);
    if(Carlist2[playerid][Carid]!=-1)
    {
        format(var, 100, "UPDATE `Cars` SET Sirena2=%i WHERE `Owner` = '%s'", alarmed[Carlist2[playerid][Carid]],name); mysql_query(var);
        format(var, 100, "UPDATE `Cars` SET Gas2=%i WHERE `Owner` = '%s'", vehicleDB[Carlist2[playerid][Carid]][gas],name); mysql_query(var);
    }
    format(var, 100, "UPDATE `Cars` SET AH3_Typ=%i WHERE `Owner` = '%s'", Carlist3[playerid][Typ],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_X='%f' WHERE `Owner` = '%s'", Carlist3[playerid][X],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Y='%f' WHERE `Owner` = '%s'", Carlist3[playerid][Y],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Z='%f' WHERE `Owner` = '%s'", Carlist3[playerid][Z],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Rot='%f' WHERE `Owner` = '%s'", Carlist3[playerid][Rotation],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Status=%i WHERE `Owner` = '%s'", Carlist3[playerid][Status],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Lock=%i WHERE `Owner` = '%s'", Carlist3[playerid][Lock],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Paintjob=%i WHERE `Owner` = '%s'", Carlist3[playerid][Paintjob],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Color1=%i WHERE `Owner` = '%s'", Carlist3[playerid][Color1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_Color2=%i WHERE `Owner` = '%s'", Carlist3[playerid][Color2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod1=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod1],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod2=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod2],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod3=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod3],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod4=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod4],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod5=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod5],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod6=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod6],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod7=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod7],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod8=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod8],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod9=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod9],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod10=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod10],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod11=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod11],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod12=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod12],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod13=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod13],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod14=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod14],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod15=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod15],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod16=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod16],name); mysql_query(var);
    format(var, 100, "UPDATE `Cars` SET AH3_mod17=%i WHERE `Owner` = '%s'", Carlist3[playerid][mod17],name); mysql_query(var);
    if(Carlist3[playerid][Carid]!=-1)
    {
        format(var, 100, "UPDATE `Cars` SET Sirena3=%i WHERE `Owner` = '%s'", alarmed[Carlist3[playerid][Carid]],name); mysql_query(var);
        format(var, 100, "UPDATE `Cars` SET Gas3=%i WHERE `Owner` = '%s'", vehicleDB[Carlist3[playerid][Carid]][gas],name); mysql_query(var);
    }

}
Find
Reply
Calgon
Banned
Posts: 6,129
Threads: 36
Joined: Jan 2009
#2

15.10.2010, 16:25
I haven't checked the top part, but the second part was just overkill. You're executing a query for every stat item you're saving, there's no need. If you created one large query, that would be the most efficient way to go. Use format and create a large string and bunch your queries in to one large query (or maybe 2), like so:

pawn Код:
new largeQuery[255]; // This is an extreme size for a string. Queries are usually large, so we need to create a large string. I have a query in a gamemode that I'm scripting that is around 1024 characters, so don't be afraid to increase the string size. 
format(largeQuery, sizeof(largeQuery), "UPDATE something SET item1 = 'ya', item2 = 'ya', item3 = 'ya', item4  = 'ya'");
format(largeQuery, sizeof(largeQuery), "%s, item5 = 'ya' WHERE condition = '1'", largeQuery);
The reason for using multiple format()'s is because of the compiler input substitution feature which only reads so far through a line, you can use alternatives, but this is probably the easiest way.

Quote:
Originally Posted by [MKD]Max
Посмотреть сообщение
i cant understand anything
Then get out.
Find
Reply
wups
High-roller
*****
Posts: 1,216
Threads: 59
Joined: Apr 2010
Reputation: 0
#3

15.10.2010, 16:30
Quote:
Originally Posted by Calgon
Посмотреть сообщение
I haven't checked the top part, but the second part was just overkill. You're executing a query for every stat item you're saving, there's no need. If you created one large query, that would be the most efficient way to go. Use format and create a large string and bunch your queries in to one large query (or maybe 2), like so:

pawn Код:
new largeQuery[255]; // This is an extreme size for a string. Queries are usually large, so we need to create a large string. I have a query in a gamemode that I'm scripting that is around 1024 characters, so don't be afraid to increase the string size. 
format(largeQuery, sizeof(largeQuery), "UPDATE something SET item1 = 'ya', item2 = 'ya', item3 = 'ya', item4  = 'ya'");
format(largeQuery, sizeof(largeQuery), "%s, item5 = 'ya' WHERE condition = '1'", largeQuery);
The reason for using multiple format()'s is because of the compiler input substitution feature which only reads so far through a line, you can use alternatives, but this is probably the easiest way.



Then get out.
Thanks, i was thinking to make it like that, but i thought maybe someone would have a better idea
pawn Код:
stock Masina(playerid)
{
        new name[MAX_PLAYER_NAME],row[20],query[200];
        GetPlayerName(playerid,name,sizeof(name));
        format(query,sizeof(query),"SELECT `AH_Typ` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Typ]=strval(row); mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_X` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][X]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Y` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Y]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Z` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Z]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Rot` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Rotation]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Status` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Status]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Lock` FROM `Cars` WHERE `Owner` = '%s'",name);mysql_query(query); mysql_store_result(); mysql_fetch_row(row);Carlist[playerid][Lock]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Paintjob` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Paintjob]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Color1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Color1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_Color2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Color2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod3` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod3]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod4` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod4]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod5` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod5]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod6` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod6]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod7` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod7]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod8` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod8]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod9` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod9]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod10` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod10]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod11` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod11]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod12` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod12]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod13` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod13]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod14` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod14]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod15` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod15]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod16` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod16]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH_mod17` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][mod17]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Gas` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Gas]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Sirena` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist[playerid][Sirena]=strval(row);mysql_free_result();

        format(query,sizeof(query),"SELECT `AH2_Typ` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Typ]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_X` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][X]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Y` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Y]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Z` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Z]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Rot` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Rotation]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Status` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Status]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Lock` FROM `Cars` WHERE `Owner` = '%s'",name);mysql_query(query); mysql_store_result(); mysql_fetch_row(row);Carlist2[playerid][Lock]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Paintjob` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Paintjob]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Color1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Color1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_Color2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Color2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod3` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod3]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod4` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod4]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod5` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod5]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod6` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod6]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod7` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod7]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod8` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod8]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod9` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod9]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod10` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod10]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod11` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod11]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod12` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod12]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod13` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod13]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod14` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod14]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod15` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod15]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod16` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod16]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH2_mod17` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][mod17]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Gas2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Gas]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Sirena2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist2[playerid][Sirena]=strval(row);mysql_free_result();

        format(query,sizeof(query),"SELECT `AH3_Typ` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Typ]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_X` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][X]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Y` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Y]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Z` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Z]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Rot` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Rotation]=floatstr(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Status` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Status]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Lock` FROM `Cars` WHERE `Owner` = '%s'",name);mysql_query(query); mysql_store_result(); mysql_fetch_row(row);Carlist3[playerid][Lock]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Paintjob` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Paintjob]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Color1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Color1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_Color2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Color2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod1` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod1]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod2` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod2]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod3` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod3]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod4` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod4]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod5` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod5]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod6` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod6]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod7` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod7]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod8` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod8]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod9` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod9]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod10` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod10]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod11` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod11]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod12` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod12]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod13` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod13]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod14` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod14]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod15` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod15]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod16` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod16]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `AH3_mod17` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][mod17]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Gas3` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Gas]=strval(row);mysql_free_result();
        format(query,sizeof(query),"SELECT `Sirena3` FROM `Cars` WHERE `Owner` = '%s'",name); mysql_query(query); mysql_store_result(); mysql_fetch_row(row); Carlist3[playerid][Sirena]=strval(row);mysql_free_result();

        if(Carlist[playerid][Typ]!=-1 && Carlist[playerid][Status]==1)
        {
            Carlist[playerid][Carid]=CreateTunedCar(playerid);
        }

        if(Carlist2[playerid][Typ]!=-1 && Carlist2[playerid][Status]==1)
        {
            Carlist2[playerid][Carid]=CreateTunedCar2(playerid);
        }
        if(Carlist3[playerid][Typ]!=-1 && Carlist3[playerid][Status]==1)
        {
            Carlist3[playerid][Carid]=CreateTunedCar3(playerid);
        }
}
This is also bad, yes?
Find
Reply
Sergei
High-roller
*****
Posts: 2,862
Threads: 11
Joined: Mar 2008
Reputation: 0
#4

15.10.2010, 16:32
Use strcat to put two strings together.
Find
Reply
Leeroy.
Big Clucker
***
Posts: 188
Threads: 1
Joined: Sep 2010
Reputation: 0
#5

15.10.2010, 16:33
Quote:
Originally Posted by Calgon
Посмотреть сообщение
I haven't checked the top part, but the second part was just overkill. You're executing a query for every stat item you're saving, there's no need. If you created one large query, that would be the most efficient way to go. Use format and create a large string and bunch your queries in to one large query (or maybe 2), like so:

pawn Код:
new largeQuery[255]; // This is an extreme size for a string. Queries are usually large, so we need to create a large string. I have a query in a gamemode that I'm scripting that is around 1024 characters, so don't be afraid to increase the string size. 
format(largeQuery, sizeof(largeQuery), "UPDATE something SET item1 = 'ya', item2 = 'ya', item3 = 'ya', item4  = 'ya'");
format(largeQuery, sizeof(largeQuery), "%s, item5 = 'ya' WHERE condition = '1'", largeQuery);
The reason for using multiple format()'s is because of the compiler input substitution feature which only reads so far through a line, you can use alternatives, but this is probably the easiest way.



Then get out.
https://sampforum.blast.hk/showthread.php?tid=55261

255 cells are same as 256 if i am wrong correct me.

so 256 tends to overkill.
Find
Reply
Relixious
Big Clucker
***
Posts: 68
Threads: 0
Joined: Aug 2010
Reputation: 0
#6

15.10.2010, 16:35
Quote:
Originally Posted by [MKD]Max
Посмотреть сообщение
i cant understand anything
Then don't post here you troll.

Quote:
Originally Posted by leeroy1337
Посмотреть сообщение
https://sampforum.blast.hk/showthread.php?tid=55261

255 cells are same as 256 if i am wrong correct me.

so 256 tends to overkill.
Don't post shit please, you can make strings as big as you want from 255 to 256 is not ''overkill''.

@ontopic:
Update more fields in one query, not line by line that would raise CPU usage.
Find
Reply
Leeroy.
Big Clucker
***
Posts: 188
Threads: 1
Joined: Sep 2010
Reputation: 0
#7

15.10.2010, 16:38
Quote:
Originally Posted by Relixious
Посмотреть сообщение
Don't post shit please, you can make strings as big as you want from 255 to 256 is not ''overkill''.


The message you have entered is too short. Please lengthen your message to at least 8 characters.
Find
Reply
Calgon
Banned
Posts: 6,129
Threads: 36
Joined: Jan 2009
#8

15.10.2010, 16:40
Quote:
Originally Posted by leeroy1337
Посмотреть сообщение
https://sampforum.blast.hk/showthread.php?tid=55261

255 cells are same as 256 if i am wrong correct me.

so 256 tends to overkill.
256 cells aren't supposed to be used where not needed. In this case, 256+ cells are required. Read the thread properly and notice how ****** clearly exempted MySQL/SQL queries.
Find
Reply
Leeroy.
Big Clucker
***
Posts: 188
Threads: 1
Joined: Sep 2010
Reputation: 0
#9

15.10.2010, 16:43
Quote:
Originally Posted by Calgon
Посмотреть сообщение
256 cells aren't supposed to be used where not needed. In this case, 256+ cells are required. Read the thread properly and notice how ****** clearly exempted MySQL/SQL queries.
Thanks for correcting me calgon.
Find
Reply
wups
High-roller
*****
Posts: 1,216
Threads: 59
Joined: Apr 2010
Reputation: 0
#10

15.10.2010, 16:43
( Последний раз редактировалось wups; 15.10.2010 в 17:04. )
pawn Код:
stock SaveMasina(playerid)
{
    new name[MAX_PLAYER_NAME];
    new var[2048],query[300];
    GetPlayerName(playerid, name, sizeof(name));
    format(var, 100,"SELECT * FROM `Cars` WHERE `Owner` = '%s'",name);
    mysql_query(var);
    mysql_store_result();
    if(!mysql_num_rows())
    {
        format(query,300,"INSERT INTO `Cars` (`Owner`,`AH_Typ`,`AH2_Typ`,`AH3_Typ`,`AH_X`,`AH_Y`,`AH_Z`,`AH_Rot`,`AH2_X`,`AH2_Y`,`AH2_Z`,`AH2_Rot`,`AH3_X`,`AH3_Y`,`AH3_Z`,`AH3_Rot`) VALUES ('%s',-1,-1,-1,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000)",name);
        mysql_query(query);
    }
    mysql_free_result();
    format(var,sizeof(var),"UPDATE `Cars` SET AH_Typ=%i,AH_X='%f',AH_Y='%f',AH_Z='%f',AH_Rot='%f',AH_Status=%i,AH_Lock=%i,AH_Paintjob=%i,AH_Color1=%i,AH_Color2=%i,AH_mod1=%i,AH_mod2=%i,AH_mod3=%i,AH_mod4=%i,AH_mod5=%i,AH_mod6=%i,AH_mod7=%i,AH_mod8=%i,AH_mod9=%i,AH_mod10=%i,AH_mod11=%i,AH_mod12=%i,AH_mod13=%i,AH_mod14=%i,AH_mod15=%i,AH_mod16=%i,AH_mod17=%i WHERE Owner='%s'",
    Carlist[playerid][Typ],Carlist[playerid][X],Carlist[playerid][Y],Carlist[playerid][Z],Carlist[playerid][Rotation],Carlist[playerid][Status],Carlist[playerid][Lock],Carlist[playerid][Paintjob],Carlist[playerid][Color1],Carlist[playerid][Color2],
    Carlist[playerid][mod1],Carlist[playerid][mod2],Carlist[playerid][mod3],Carlist[playerid][mod4],Carlist[playerid][mod5],Carlist[playerid][mod6],Carlist[playerid][mod7],Carlist[playerid][mod8],Carlist[playerid][mod9],Carlist[playerid][mod10],
    Carlist[playerid][mod11],Carlist[playerid][mod12],Carlist[playerid][mod13],Carlist[playerid][mod14],Carlist[playerid][mod15],Carlist[playerid][mod16],Carlist[playerid][mod17],name);
    mysql_query(query);
    if(Carlist[playerid][Carid]!=-1)
    {
        format(var, sizeof(var), "UPDATE `Cars` SET Sirena=%i,Gas=%i WHERE `Owner` = '%s'", alarmed[Carlist[playerid][Carid]],vehicleDB[Carlist[playerid][Carid]][gas],name); mysql_query(var);
    }
    
    format(var,sizeof(var),"UPDATE `Cars` SET AH2_Typ=%i,AH2_X='%f',AH2_Y='%f',AH2_Z='%f',AH2_Rot='%f',AH2_Status=%i,AH2_Lock=%i,AH2_Paintjob=%i,AH2_Color1=%i,AH2_Color2=%i,AH2_mod1=%i,AH2_mod2=%i,AH2_mod3=%i,AH2_mod4=%i,AH2_mod5=%i,AH2_mod6=%i,AH2_mod7=%i,AH2_mod8=%i,AH2_mod9=%i,AH2_mod10=%i,AH2_mod11=%i,AH2_mod12=%i,AH2_mod13=%i,AH2_mod14=%i,AH2_mod15=%i,AH2_mod16=%i,AH2_mod17=%i WHERE Owner='%s'",
    Carlist2[playerid][Typ],Carlist2[playerid][X],Carlist2[playerid][Y],Carlist2[playerid][Z],Carlist2[playerid][Rotation],Carlist2[playerid][Status],Carlist2[playerid][Lock],Carlist2[playerid][Paintjob],Carlist2[playerid][Color1],Carlist2[playerid][Color2],
    Carlist2[playerid][mod1],Carlist2[playerid][mod2],Carlist2[playerid][mod3],Carlist2[playerid][mod4],Carlist2[playerid][mod5],Carlist2[playerid][mod6],Carlist2[playerid][mod7],Carlist2[playerid][mod8],Carlist2[playerid][mod9],Carlist2[playerid][mod10],
    Carlist2[playerid][mod11],Carlist2[playerid][mod12],Carlist2[playerid][mod13],Carlist2[playerid][mod14],Carlist2[playerid][mod15],Carlist2[playerid][mod16],Carlist2[playerid][mod17],name);
    mysql_query(query);
    if(Carlist2[playerid][Carid]!=-1)
    {
        format(var, sizeof(var), "UPDATE `Cars` SET Sirena2=%i,Gas2=%i WHERE `Owner` = '%s'", alarmed[Carlist2[playerid][Carid]],vehicleDB[Carlist2[playerid][Carid]][gas],name); mysql_query(var);
    }
    format(var,sizeof(var),"UPDATE `Cars` SET AH3_Typ=%i,AH3_X='%f',AH3_Y='%f',AH3_Z='%f',AH3_Rot='%f',AH3_Status=%i,AH3_Lock=%i,AH3_Paintjob=%i,AH3_Color1=%i,AH3_Color2=%i,AH3_mod1=%i,AH3_mod2=%i,AH3_mod3=%i,AH3_mod4=%i,AH3_mod5=%i,AH3_mod6=%i,AH3_mod7=%i,AH3_mod8=%i,AH3_mod9=%i,AH3_mod10=%i,AH3_mod11=%i,AH3_mod12=%i,AH3_mod13=%i,AH3_mod14=%i,AH3_mod15=%i,AH3_mod16=%i,AH3_mod17=%i WHERE Owner='%s'",
    Carlist3[playerid][Typ],Carlist3[playerid][X],Carlist3[playerid][Y],Carlist3[playerid][Z],Carlist3[playerid][Rotation],Carlist3[playerid][Status],Carlist3[playerid][Lock],Carlist3[playerid][Paintjob],Carlist3[playerid][Color1],Carlist3[playerid][Color2],
    Carlist3[playerid][mod1],Carlist3[playerid][mod2],Carlist3[playerid][mod3],Carlist3[playerid][mod4],Carlist3[playerid][mod5],Carlist3[playerid][mod6],Carlist3[playerid][mod7],Carlist3[playerid][mod8],Carlist3[playerid][mod9],Carlist3[playerid][mod10],
    Carlist3[playerid][mod11],Carlist3[playerid][mod12],Carlist3[playerid][mod13],Carlist3[playerid][mod14],Carlist3[playerid][mod15],Carlist3[playerid][mod16],Carlist3[playerid][mod17],name);
    mysql_query(query);
    if(Carlist3[playerid][Carid]!=-1)
    {
        format(var, sizeof(var), "UPDATE `Cars` SET Sirena2=%i,Gas2=%i WHERE `Owner` = '%s'", alarmed[Carlist3[playerid][Carid]],vehicleDB[Carlist3[playerid][Carid]][gas],name); mysql_query(var);
    }
    return 1;
}
Is this ok?

And this
pawn Код:
stock Masina(playerid)
{
        new name[MAX_PLAYER_NAME],row[2048],query[100];
        GetPlayerName(playerid,name,sizeof(name));
        format(query,sizeof(query),"SELECT * FROM `Cars` WHERE `Owner` = '%s'",name);
        mysql_query(query);
        mysql_store_result();
        mysql_fetch_row_format(row," ");
        mysql_free_result();
        
        sscanf(row,"iffffiiiiiiiiiiiiiiiiiiiiiiiiiffffiiiiiiiiiiiiiiiiiiiiiiiiiffffiiiiiiiiiiiiiiiiiiiiiiii",
        Carlist[playerid][Typ],
        Carlist[playerid][X],
        Carlist[playerid][Y],
        Carlist[playerid][Z],
        Carlist[playerid][Rotation],
        Carlist[playerid][Status],
        Carlist[playerid][Lock],
        Carlist[playerid][Paintjob],
        Carlist[playerid][Color1],
        Carlist[playerid][Color2],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][mod1],
        Carlist[playerid][Gas],
        Carlist[playerid][Sirena],
        
        Carlist2[playerid][Typ],
        Carlist2[playerid][X],
        Carlist2[playerid][Y],
        Carlist2[playerid][Z],
        Carlist2[playerid][Rotation],
        Carlist2[playerid][Status],
        Carlist2[playerid][Lock],
        Carlist2[playerid][Paintjob],
        Carlist2[playerid][Color1],
        Carlist2[playerid][Color2],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][mod1],
        Carlist2[playerid][Gas],
        Carlist2[playerid][Sirena],
        
        Carlist3[playerid][Typ],
        Carlist3[playerid][X],
        Carlist3[playerid][Y],
        Carlist3[playerid][Z],
        Carlist3[playerid][Rotation],
        Carlist3[playerid][Status],
        Carlist3[playerid][Lock],
        Carlist3[playerid][Paintjob],
        Carlist3[playerid][Color1],
        Carlist3[playerid][Color2],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][mod1],
        Carlist3[playerid][Gas],
        Carlist3[playerid][Sirena]
        );

        if(Carlist[playerid][Typ]!=-1 && Carlist[playerid][Status]==1)
        {
            Carlist[playerid][Carid]=CreateTunedCar(playerid);
        }

        if(Carlist2[playerid][Typ]!=-1 && Carlist2[playerid][Status]==1)
        {
            Carlist2[playerid][Carid]=CreateTunedCar2(playerid);
        }
        if(Carlist3[playerid][Typ]!=-1 && Carlist3[playerid][Status]==1)
        {
            Carlist3[playerid][Carid]=CreateTunedCar3(playerid);
        }
}
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive