[gamer931215]

Old, Boring, Useless

Since this was my first SAMP script ever, it really sucked so dont pm/ask me for anything.

[[MWR]Blood]

Good job, nice for Rp servers.

[Joe_]

This is possibly the worst script I have seen in quite a while, sorry.

Not only because there's 4 timers (?) .. because it's extremely static lol.

Good try if it's your first..I guess.

[gamer931215]

Quote:

Originally Posted by Joe_ This is possibly the worst script I have seen in quite a while, sorry. Not only because there's 4 timers (?) .. because it's extremely static lol. Good try if it's your first..I guess.

Well, im not good in pawno (im a vb programmer, learning pawn) but yeah atleast its without warnings.
My first gamemode has 45 warnings xD thats baaad lol

[Vince]

This is the most inefficient code I've seen for a whole lot of time:

pawn Код:

if (GetVehicleModel(GetVehicleModel(GetPlayerVehicleID(playerid))  == 520 || GetVehicleModel(GetPlayerVehicleID(playerid)) ==  577 || /*etc, etc, etc*/

This would be much more efficient:

pawn Код:

switch(GetVehicleModel(GetPlayerVehicleID(playerid)))
{
    case 520, 577, 511, 592, /*etc, etc, etc*/:
    {
        // Do whatever you want when player is in a plane
    }
}

Good for a first script, though.

[gamer931215]

Quote:

Originally Posted by Vince This is the most inefficient code I've seen for a whole lot of time: pawn Код: if (GetVehicleModel(GetVehicleModel(GetPlayerVehicleID(playerid))  == 520 || GetVehicleModel(GetPlayerVehicleID(playerid)) ==  577 || /*etc, etc, etc*/ This would be much more efficient: pawn Код: switch(GetVehicleModel(GetPlayerVehicleID(playerid))) {     case 520, 577, 511, 592, /*etc, etc, etc*/:     {         // Do whatever you want when player is in a plane     } } Good for a first script, though.

Thanks, il edit it now and update pastebin script, and in my own server what it was actually made for :P

[gamer931215]

Quote:

Originally Posted by gamer931215 Thanks, il edit it now and update pastebin script, and in my own server what it was actually made for :P

Edit:
Can you make also an "else" statement at an case statement ?
im getting an error

[shadydeath]

looks nice

[gamer931215]

Quote:

Originally Posted by Vince This is the most inefficient code I've seen for a whole lot of time [..]

Quote:

Originally Posted by Joe_ This is possibly the worst script I have seen in quite a while, sorry. Not only because there's 4 timers (?) .. because it's extremely static lol. Good try if it's your first..I guess.

Hey guys, thanks for the tips.
I kind a fixed it, hope its good now ?
Please reply

[Crusher!!]

Quote:

Originally Posted by Joe_ This is possibly the worst script I have seen in quite a while

A little respect for him, he's a starter like jou a time ago, and when they tell you your script is bad you don't like it.. he also don't like your reaction.. A little respect for a starter


@ Gamer: GoodJob