[Dolph]

Since I'm fairly new to loops, I wanted to make a /vrespawn that respawns all unoccupied vehicles.


Here is the code:

pawn Код:

dcmd_vrespawn(playerid,params[])
{
    #pragma unused params
    if(pi[playerid][admin] <= 0) return 0;
    if(sscanf(params,"u"))
    {
    for(new 1 = 0; i < MAX_VEHICLES; i++)
    {
    SendClientMessageToAll(COLOUR_YELLOW,"All unoccupied vehicles has been respawned");
    SetVehicleToRespawn(i);
    return 1;
    }
    return 1;
}

Errors:

Код:

C:\GTASER~1\GAMEMO~1\MyDm.pwn(1860) : error 001: expected token: "-identifier-", but found "-integer value-"
C:\GTASER~1\GAMEMO~1\MyDm.pwn(1862) : error 008: must be a constant expression; assumed zero
C:\GTASER~1\GAMEMO~1\MyDm.pwn(1863) : error 001: expected token: ")", but found ";"
C:\GTASER~1\GAMEMO~1\MyDm.pwn(1863) : error 036: empty statement

Could someone tell me what I've done wrong?

[Jeffry]

Try:

pawn Код:

for(new i = 0; i < MAX_VEHICLES; i++)

[Mike Garber]

No, since vehicle ID's start with 1, it should be;

pawn Код:

for(new i = 1; i < MAX_VEHICLES; i++)

[Dolph]

Lol.. I actually saw the error now: for(new i = 0; i < MAX_VEHICLES; i++) I wrote new 1..


Thanks for the help!



EDIT:

pawn Код:

dcmd_vrespawn(playerid,params[])
{
    #pragma unused params
    if(pi[playerid][admin] <= 0) return 0;
    if(sscanf(params,"u"))
    {
    for(new i = 0; i < MAX_VEHICLES; i++)
    {
    SendClientMessageToAll(COLOUR_YELLOW,"All unoccupied vehicles has been respawned");
    SetVehicleToRespawn(i);
    return 1;
    }
    }
    return 1;
}

Thats the code now.. The ClientMessage is being sent, but the vehicles doesnt respawn. Whats the problem now?

[Dolph]

I don't mean to bump, but if I don't, this topic will probably die.

[Hiddos]

pawn Код:

dcmd_vrespawn(playerid,params[])
{
    #pragma unused params
    if(pi[playerid][admin] <= 0) return 0;
    if(sscanf(params,"u"))
    {
    for(new i = 0; i < MAX_VEHICLES; i++)
    {
    SetVehicleToRespawn(i);
    }
    SendClientMessageToAll(COLOUR_YELLOW,"All unoccupied vehicles has been respawned");
    }
    return 1;
}

[Mike Garber]

As I said, vehicle ID's start with 1, so

pawn Код:

for(new i = 1; i < MAX_VEHICLES; i++)

[Hiddos]

Oh well, whatever. Even I learned something today.

[Jeffry]

Quote:

Originally Posted by Hiddos Oh well, whatever. Even I learned something today.

Same here.

[Nero_3D]

pawn Код:

dcmd_vrespawn(playerid, params[]) {
    #pragma unused params
    if(pi[playerid][admin] > 0) {
        new bool:VehicleUsed[MAX_VEHICLES], i;
        for( ; i != MAX_PLAYERS; i++) {
            if(IsPlayerInAnyVehicle(i)) {
                VehicleUsed[GetPlayerVehicleID(playerid)] = true;
            }
        }
        for(i = 1; i != MAX_VEHICLES; i++) {
            if(VehicleUsed[i] == false) {
                SetVehicleToRespawn(i);
            }
        }
        return SendClientMessageToAll(COLOUR_YELLOW,"All unoccupied vehicles has been respawned");
    }
    return 0;
}