[HY]

Introduction:

- Hello, I created a Police System, or Faction.

Members commands:

pawn Code:

/Open -> Will open the gate !
/Barrier -> Will open the barrier !
/Cuff -> Will cuff a player ! [Needs to be in Range of point 4 metres.]
/Uncuff -> Will uncuff a player ! [Needs to be in Range of point 4 metres.]
/R -> Speak in Radio Chat. A player doesn\'t see the text if you are in Range of more 50 metres !
/Arrest -> Arrests a player, but police man needs to be in down pick-up !
/Wanted -> Setting wanted to a player !

Leaders commands:

pawn Code:

* Leaders have acces to Members command !

/MakeLeader || Syntax: /MakeLeader [ID] -> Will make Leader a player !
/Invite || Syntax: /Invite [ID] -> Will invite a player !
/FKick || Syntax: /FKick [ID] -> Will kicks a player from Faction !

RCON commands:

pawn Code:

/PoliceLeader || Syntax: /PoliceLeader [ID] -> Will make a player leader in Police Faction !

Preview:

Download:

- Pastebin ;

- Solidfiles [ALL PACK + includes ]

- Free Upload Site [ALL PACK + includes]

- Filedropper [ALL PACK + includes]

- Megafile [ALL PACK + includes]

[Glossy42O]

I really like it.


You make good things, Keep it up.


Repped.

[HY]

Quote:

Originally Posted by Stuun I really like it. You make good things, Keep it up. Repped.

Thanks.

[Abagail]

This uses very insufficent code. Especially setting a player\'s color based on Wanted Level in OnPlayerUpdate.
And a few things plain out don\'t make sense:
Why give anti-kill to just cops? That has no logic, and gives cops unfair advantages. Also there is NO arrest system in place at all. When they get arrested, they have to (in RP servers, for the most part) either log off, or get an admin to let them out or some sort.

[ProKillerpa]

Cool!

[HY]

Quote:

Originally Posted by Abagail This uses very insufficent code. Especially setting a player\'s color based on Wanted Level in OnPlayerUpdate. And a few things plain out don\'t make sense: Why give anti-kill to just cops? That has no logic, and gives cops unfair advantages. Also there is NO arrest system in place at all. When they get arrested, they have to (in RP servers, for the most part) either log off, or get an admin to let them out or some sort.

Have GodMode 15 seconds at Spawn, at base..

Quote:

Originally Posted by ProKillerpa Cool!

Thanks !

[Alex Magaсa]

nice work ! keep it up!

[Abagail]

Another inefficent method. You\'re going to waste 30 lines when you could only use 1? It looks awful like this in my opionon.


What I\'m taking about:

pawn Code:

new V1;

pawn Code:

new V2;

This could easily be done in one line using...

pawn Code:

#define MAX_VEHICLE 30

pawn Code:

new Vehicles[MAX_VEHICLE];

Uncuff can also easily be abused by Law Officers. You don\'t even check if they are cuffed or not. Example using your existing code checking if they are even cuffed:

pawn Code:

CMD:uncuff(playerid, params[])
{
    if(PlayerInfo[playerid][Member] >= 1 || PlayerInfo[playerid][Leader] >= 1)
        {
                new Float:X;
                new Float:Y;
                new Float:Z;
                GetPlayerPos(playerid, X, Y, Z);
        if(IsPlayerInRangeOfPoint(playerid, 4.0, X, Y, Z))
        {
                        new ID;
                        new string[128];
                        new name[MAX_PLAYER_NAME];
                        GetPlayerName(playerid, name, 24);
            if(sscanf(params,"i", ID)) return SendClientMessage(playerid,-1,"{FF0000}USAGE: {15FF00}/UnCuff [PlayerID]");
            if(GetPlayerSpecialAction(ID) == 24)
            {
                SetPlayerSpecialAction(ID, SPECIAL_ACTION_NONE);
                format(string, sizeof(string), "{0066CC}[POLICE]: {15FF00}You uncuffed {FF0000}%s {15FF00}!", ID);
                SendClientMessage(playerid, -1, string);
                format(string, sizeof(string), "{0066CC}{15FF00}You got uncuffed by Police Officer{FF0000}%s {15FF00}!", name);
                SendClientMessage(playerid, -1, string);
            }
        }
        }
        else
        {
                SCM(playerid, -1, "{FF0000}ERROR: {15FF00}You aren\'t Police !");
        }
        return 1;
}

Your indentation also makes me want to throw up. Just saying


EDIT: Also you have a few typos such as "metres" instead of "meters".

[AllyForgien]

Very Nice script. It is very good and easy to use, as well as with a lot of typos and things I didn\'t like. I\'ve edited it to my needs though and it is doing me just fine. Thank you for this great script.

[AzaMx]

Quote:

Originally Posted by AllyForgien Very Nice script. It is very good and easy to use, as well as with a lot of typos and things I didn\'t like. I\'ve edited it to my needs though and it is doing me just fine. Thank you for this great script.

last: 13/11/2014, 09:18 AM

g00d bump.

[Kaliber]

There are a lot of repetition in your code, thats very bad coding.


You wanna avoid that.


Try to use seperate functions, instead of calling it directly every time.


Also dont use

PHP Code:

OnPlayerUpdate 


for that stuff.


Because you know exatly the time when he get wanteds, so you can change the color there.


No need to check every ms 1000 times.


And the check in

PHP Code:

OnPlayerEnterVehicle 


is complete wrong.


That will not work.


It means you can enter every car and it will say you are in a police car.

[N0FeaR]

Nice work keep it up!

[Usmanmemon]

GOOD WORK

[CaptainBoi]

good efforts

[Wherethescripters]

Very nice work, That\'s cool