[kovac]

Hello,
I m experiencing problem while trying to divide UserStats[targetid][WeaponHitsOP] with UserStats[targetid][MissedWeaponHits]

PHP Code:

    format(string, sizeof(string), "{FF0000}[STATS] {FFFFFF}Kills: %d, Deaths: %d, Ratio: %0.2f, Hit accuracy: %d", UserStats[targetid][Kills],UserStats[targetid][Deaths],floatdiv(UserStats[targetid][Kills], UserStats[targetid][Deaths]), UserStats[targetid][WeaponHitsOP]/UserStats[targetid][MissedWeaponHits]);
    SendClientMessage(playerid, COLOR_WHITE, string); 


Command would return "SERVER: Unknown command" error. Why?
If I remove that part of code, or just the accuracy, everything would be fine.

[AgusZ]

Can you show me the full of code?

[kovac]

Here you go.

PHP Code:

CMD<ALL>:stats(cmdid, playerid, params[])
{
    new targetid, string[128];
    if(sscanf(params, "u", targetid)) targetid = playerid;
    if(!IsPlayerConnected(targetid)) return SCM(playerid, COLOR_RED, NOPLAYER);
    if(!LoggedIn[targetid]) return SCM(playerid, COLOR_RED, NOTLOGGEDIN);
    SendClientMessage(playerid, COLOR_TOMATO, "");
    format(string, sizeof(string), "..:: %s's account statistic ::..", GetName(targetid));
    SendClientMessage(playerid, COLOR_TOMATO, string);
    format(string, sizeof(string), "{FF0000}[WEAPON KILLS] {FFFFFF}Deagle: %d, Sniper: %d, M4: %d, Shotgun: %d, Combat: %d, MP5: %d, SawnOff: %d", UserStats[targetid][DeagleKills],UserStats[targetid][SniperKills],UserStats[targetid][M4Kills], UserStats[targetid][ShotgunKills],UserStats[targetid][CombatKills],UserStats[targetid][MP5Kills],UserStats[targetid][SawnOffKills]);
    SendClientMessage(playerid, COLOR_WHITE, string);
    format(string, sizeof(string), "{FF0000}[STATS] {FFFFFF}Kills: %d, Deaths: %d, Ratio: %0.2f, Hit accuracy: %d", UserStats[targetid][Kills],UserStats[targetid][Deaths],floatdiv(UserStats[targetid][Kills], UserStats[targetid][Deaths]), UserStats[targetid][WeaponHitsOnPlayer]/UserStats[targetid][MissedWeaponHits]);
    SendClientMessage(playerid, COLOR_WHITE, string);
    SendClientMessage(playerid, COLOR_TOMATO, "");
    return 1;
} 


The command works if I don't include that part.

[Shadow0707]

Quote:

Originally Posted by kovac Here you go. PHP Code: format(string, sizeof(string), "{FF0000}[STATS] {FFFFFF}Kills: %d, Deaths: %d, Ratio: %0.2f, Hit accuracy: %d", UserStats[targetid][Kills],UserStats[targetid][Deaths],floatdiv(UserStats[targetid][Kills], UserStats[targetid][Deaths]), UserStats[targetid][WeaponHitsOnPlayer]/UserStats[targetid][MissedWeaponHits]); // -----  is this slash should be really there?  The command works if I don't include that part.

I just found something correct me if i'm wrong

PHP Code:

CMD<ALL>:stats(cmdid, playerid, params[]) 
{ 
    new targetid, string[128]; 
    if(sscanf(params, "u", targetid)) targetid = playerid; 
    if(!IsPlayerConnected(targetid)) return SCM(playerid, COLOR_RED, NOPLAYER); 
    if(!LoggedIn[targetid]) return SCM(playerid, COLOR_RED, NOTLOGGEDIN); 
    SendClientMessage(playerid, COLOR_TOMATO, ""); 
    format(string, sizeof(string), "..:: %s's account statistic ::..", GetName(targetid)); 
    SendClientMessage(playerid, COLOR_TOMATO, string); 
    format(string, sizeof(string), "{FF0000}[WEAPON KILLS] {FFFFFF}Deagle: %d, Sniper: %d, M4: %d, Shotgun: %d, Combat: %d, MP5: %d, SawnOff: %d", UserStats[targetid][DeagleKills],UserStats[targetid][SniperKills],UserStats[targetid][M4Kills], UserStats[targetid][ShotgunKills],UserStats[targetid][CombatKills],UserStats[targetid][MP5Kills],UserStats[targetid][SawnOffKills]); 
    SendClientMessage(playerid, COLOR_WHITE, string); 
    format(string, sizeof(string), "{FF0000}[STATS] {FFFFFF}Kills: %d, Deaths: %d, Ratio: %0.2f, Hit accuracy: %d", UserStats[targetid][Kills],UserStats[targetid][Deaths],floatdiv(UserStats[targetid][Kills], UserStats[targetid][Deaths]), UserStats[targetid][WeaponHitsOnPlayer], UserStats[targetid][MissedWeaponHits]); 
    SendClientMessage(playerid, COLOR_WHITE, string); 
    SendClientMessage(playerid, COLOR_TOMATO, ""); 
    return 1; 
} 


[RoboN1X]

Let me guess your problem:
You are trying to divide with zero...

When the player has hits but never missed, they will get that error in commands.

You need to check first if MissedWeaponHits has positive value, then you can divide with it. When both is zero, simply tells the player has no accuracy, otherwise 100% accuracy.