1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Y_Ini Save Bug?
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#1

17.06.2017, 12:58
( Last edited by AfiqIqbal; 18/06/2017 at 07:27 PM. )
I made a map license for my script, if player want to create an object, they must have a map license from the admin.
But the problem is, the map license sometimes gone when player /q, crash/timeout or server restart (not often, it happen randomly).

Main script :
PHP Code:
#include <YSI\y_ini>
#define PATH "MapLicense/%s.ini"
enum PlayerInfo
{
    maplicense
}
new MappingLicense[MAX_PLAYERS][PlayerInfo];
forward LoadMappingLicenseData(playerid,name[],value[]);
public LoadMappingLicenseData(playerid,name[],value[])
{
    INI_Int("Mapping", MappingLicense[playerid][maplicense]);
     return 1;
}
stock UserMappingLicensePath(playerid)
{
    new string[128],playername[MAX_PLAYER_NAME];
    GetPlayerName(playerid,playername,sizeof(playername));
    format(string,sizeof(string),PATH,playername);
    return string;
}
public OnPlayerConnect(playerid)
{
    if(fexist(UserMappingLicensePath(playerid)))
    {
        INI_ParseFile(UserMappingLicensePath(playerid), "LoadMappingLicenseData", .bExtra = true, .extra = playerid);
    }
    else
    {
        new INI:ini = INI_Open(UserMappingLicensePath(playerid));
         INI_WriteInt(ini,"MapLicense", 0);
          MappingLicense[playerid][maplicense] = 0;
           INI_Close(ini);
    }
    return 1;
}
public OnFilterScriptExit()
{
    foreach(new i : Player)
    {
        new INI:ini = INI_Open(UserMappingLicensePath(i));
        INI_WriteInt(ini,"MapLicense", MappingLicense[i][maplicense]);
        INI_Close(ini);
    }
    return 1;
}
public OnPlayerDisconnect(playerid, reason)
{
    new INI:ini = INI_Open(UserMappingLicensePath(playerid));
    INI_WriteInt(ini,"MapLicense", MappingLicense[playerid][maplicense]);
    INI_Close(ini);
    return 1;
} 
I put this on each command (simplified) :

PHP Code:
if(MappingLicense[playerid][maplicense] == 1)
{
    //object thing
}
else
{
     //sendclientmessage thingy
} 
Give map license command :

PHP Code:
CMD:givemaplicense(playerid, params[])
{
    if(IsPlayerAdmin(playerid))
    {
        new targetid, license, name[MAX_PLAYER_NAME], string[128 + MAX_PLAYER_NAME];
        if(sscanf(params, "ud", targetid, license))
        {
            return SendClientMessage(playerid, 0xFF0000FF, "[Error:] /givemaplicense <id> <0 - 1>");
        }
        if(license > 1 || license < 0)
        {
            return SendClientMessage(playerid, 0xFF0000FF, "[Error:] The valid number is only 0 and 1!");
        }
        if(license == MappingLicense[targetid][maplicense])
        {
            return SendClientMessage(playerid, 0xFF0000FF, "[Error:] That player already have a mapping license!");
        }
        if(license > MappingLicense[targetid][maplicense])
        {
            GetPlayerName(targetid, name, sizeof(name));
            format(string, sizeof(string), "[MAP] You have given %s a mapping license!", name);
            SendClientMessage(playerid, 0xFFFF00FF, string);
            if(targetid != playerid)
            {
                GetPlayerName(playerid, name, sizeof(name));
                format(string, sizeof(string), "[MAP] %s have given you a mapping license!", name);
                SendClientMessage(targetid, 0xFFFF00FF, string);
            }
            MappingLicense[targetid][maplicense] = license;
        }
        else
        {
            GetPlayerName(targetid, name, sizeof(name));
            format(string, sizeof(string), "[MAP] You have removed %s mapping license!", name);
            SendClientMessage(playerid, 0xFFFF00FF, string);
            if(targetid != playerid)
            {
                GetPlayerName(playerid, name, sizeof(name));
                format(string, sizeof(string), "[MAP] %s have removed your mapping license!", name);
                SendClientMessage(targetid, 0xFFFF00FF, string);
            }
            MappingLicense[targetid][maplicense] = license;
        }
        new INI:ini = INI_Open(UserMappingLicensePath(playerid));
         INI_WriteInt(ini,"MapLicense", license);
          INI_Close(ini);
    }
    else
    {
         return SendClientMessage(playerid, 0xFF0000FF, "[Error:] You are not logged in to RCON!");
    }
    return 1;
} 
What should I do? Is there anything wrong in the code?

EDIT : I think I found where is the problem, when a player (with a mapping license) connected to the server, and he didn't do any mapping cmd like /createobject, his mapping license will gone after next relog. Any clue how to fix this?
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#2

17.06.2017, 16:02
BUMP
Find
Reply
Meller
Banned
Posts: 578
Threads: 40
Joined: Dec 2016
#3

17.06.2017, 17:04
Honestly, you don't need to use y_ini for this at all, let me code you a similar system in a sec. Hold on.
Find
Reply
Meller
Banned
Posts: 578
Threads: 40
Joined: Dec 2016
#4

17.06.2017, 17:24
PHP Code:
#include <a_samp>
#include <command_proccessor> // zcmd for me
#include <sscanf2>

public OnPlayerConnect(playerid) {
    
    new path[64], name[MAX_PLAYER_NAME];
    GetPlayerName(playerid, name, MAX_PLAYER_NAME);
    format(path, 64, "maplicenses/%s", name);
    if(fexist(path))
        SetPVarInt(playerid, "mapping_license", 1);
    else SetPVarInt(playerid, "mapping_license", 0);
    return 1;
}

CMD:setmaplicense(playerid, params[]) {
    if(IsPlayerAdmin(playerid)) {
        new targetid, license;
        if(!sscanf(params, "ui", targetid, license)) {
            //always check for the first param first btw
            if(IsPlayerConnected(targetid)) {
                if((license == 1) || (license == 0)) {
                    if(license != GetPVarInt(targetid, "mapping_license")) {
                        new name[MAX_PLAYER_NAME], message[144], path[64];
                        GetPlayerName(targetid, name, MAX_PLAYER_NAME);
                        if(license == 0) {
                            GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                            format(path, 64, "maplicenses/%s", name);
                            if(fexist(path))
                                fremove(path);
                            format(message, 144, "[MAP] You have removed %s mapping license!", name);
                            SendClientMessage(playerid, 0xFFFF00FF, message);
                            if(targetid != playerid) {
                                GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                                format(message, 144, "[MAP] %s have removed your mapping license!", name);
                                SendClientMessage(targetid, 0xFFFF00FF, message);
                            }
                            SetPVarInt(targetid, "mapping_license", 0);
                        }
                        else {
                            GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                            format(path, 64, "maplicenses/%s", name);
                            if(!fexist(path)) {
                                new File:file = fopen(path, io_write);
                                fclose(file);
                            }
                            format(message, 144, "[MAP] You have given %s a mapping license!", name);
                            SendClientMessage(playerid, 0xFFFF00FF, message);
                            if(targetid != playerid) {
                                GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                                format(message, 144, "[MAP] %s have given you a mapping license!", name);
                                SendClientMessage(targetid, 0xFFFF00FF, message);
                            }
                            SetPVarInt(targetid, "mapping_license", 1);
                        }
                    }
                    else SendClientMessage(playerid, 0xFF0000FF, "[Error:] That player already have their mapping license set at that!");
                }
                else SendClientMessage(playerid, 0xFF0000FF, "[Error:] The valid number is only 0 and 1!");
            }
            else SendClientMessage(playerid, 0xFF0000FF, "[Error:] That player is not connected!");
        }
        else SendClientMessage(playerid, 0xFF0000FF, "[Error:] /givemaplicense <id> <0 - 1>");
    }
    else SendClientMessage(playerid, 0xFF0000FF, "[Error:] You are not logged in to RCON!");
    return 1;
} 
There you go bud'.

To check if he's got a map license simply type:
PHP Code:
if(GetPVarInt(targetid, "mapping_license") == 1) { } 
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#5

17.06.2017, 17:56
Quote:
Originally Posted by Meller
View Post
PHP Code:
#include <a_samp>
#include <command_proccessor> // zcmd for me
#include <sscanf2>
public OnPlayerConnect(playerid) {
    
    new path[64], name[MAX_PLAYER_NAME];
    GetPlayerName(playerid, name, MAX_PLAYER_NAME);
    format(path, 64, "maplicenses/%s", name);
    if(fexist(path))
        SetPVarInt(playerid, "mapping_license", 1);
    else SetPVarInt(playerid, "mapping_license", 0);
    return 1;
}
CMD:setmaplicense(playerid, params[]) {
    if(IsPlayerAdmin(playerid)) {
        new targetid, license;
        if(!sscanf(params, "ui", targetid, license)) {
            //always check for the first param first btw
            if(IsPlayerConnected(targetid)) {
                if((license == 1) || (license == 0)) {
                    if(license != GetPVarInt(targetid, "mapping_license")) {
                        new name[MAX_PLAYER_NAME], message[144], path[64];
                        GetPlayerName(targetid, name, MAX_PLAYER_NAME);
                        if(license == 0) {
                            GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                            format(path, 64, "maplicenses/%s", name);
                            if(fexist(path))
                                fremove(path);
                            format(message, 144, "[MAP] You have removed %s mapping license!", name);
                            SendClientMessage(playerid, 0xFFFF00FF, message);
                            if(targetid != playerid) {
                                GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                                format(message, 144, "[MAP] %s have removed your mapping license!", name);
                                SendClientMessage(targetid, 0xFFFF00FF, message);
                            }
                            SetPVarInt(targetid, "mapping_license", 0);
                        }
                        else {
                            GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                            format(path, 64, "maplicenses/%s", name);
                            if(!fexist(path)) {
                                new File:file = fopen(path, io_write);
                                fclose(file);
                            }
                            format(message, 144, "[MAP] You have given %s a mapping license!", name);
                            SendClientMessage(playerid, 0xFFFF00FF, message);
                            if(targetid != playerid) {
                                GetPlayerName(playerid, name, MAX_PLAYER_NAME);
                                format(message, 144, "[MAP] %s have given you a mapping license!", name);
                                SendClientMessage(targetid, 0xFFFF00FF, message);
                            }
                            SetPVarInt(targetid, "mapping_license", 1);
                        }
                    }
                    else SendClientMessage(playerid, 0xFF0000FF, "[Error:] That player already have their mapping license set at that!");
                }
                else SendClientMessage(playerid, 0xFF0000FF, "[Error:] The valid number is only 0 and 1!");
            }
            else SendClientMessage(playerid, 0xFF0000FF, "[Error:] That player is not connected!");
        }
        else SendClientMessage(playerid, 0xFF0000FF, "[Error:] /givemaplicense <id> <0 - 1>");
    }
    else SendClientMessage(playerid, 0xFF0000FF, "[Error:] You are not logged in to RCON!");
    return 1;
} 
There you go bud'.

To check if he's got a map license simply type:
PHP Code:
if(GetPVarInt(targetid, "mapping_license") == 1) { } 
So, if I use your method will it fix my problem or you just showing me the simple way to do this?
Find
Reply
Meller
Banned
Posts: 578
Threads: 40
Joined: Dec 2016
#6

17.06.2017, 18:56
Quote:
Originally Posted by AfiqIqbal
View Post
So, if I use your method will it fix my problem or you just showing me the simple way to do this?
That code works just like you wanted yours to work. So it'll work if you replace it with your current.
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#7

17.06.2017, 20:04
( Last edited by AfiqIqbal; 18/06/2017 at 03:58 AM. )
Thanks for your help, appreciate it. REP +

EDIT : I thought it worked .. but nope it's not working, somebody please help me...
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#8

18.06.2017, 04:03
BUMP
Find
Reply
Sew_Sumi
Banned
Posts: 6,242
Threads: 8
Joined: Jun 2008
#9

18.06.2017, 05:07
24 hour bumps only.

Say how it's not working, not just that it isn't working...
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#10

18.06.2017, 05:11
I don't know, sometimes when player relog their license is gone, and sometimes not, man it just confusing!
Find
Reply
Kane
Gangsta
*****
Posts: 824
Threads: 6
Joined: Sep 2012
Reputation: 0
#11

18.06.2017, 05:44
Are you resetting player variables on connect?
Find
Reply
Sew_Sumi
Banned
Posts: 6,242
Threads: 8
Joined: Jun 2008
#12

18.06.2017, 07:04
If it\'s sporadic, then it could be something else interfering with it.
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#13

18.06.2017, 13:17
Quote:
Originally Posted by Arthur Kane
View Post
Are you resetting player variables on connect?
No, I didn\'t
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#14

18.06.2017, 13:30
Quote:
Originally Posted by Sew_Sumi
View Post
If it\'s sporadic, then it could be something else interfering with it.
Maybe I have to reset the map license variable to 0, in OnPlayerDisconnect? Let me try ..
Find
Reply
Uberanwar
Gangsta
*****
Posts: 893
Threads: 132
Joined: May 2012
Reputation: 0
#15

18.06.2017, 13:36
You have to reset all your variables when the user connect and after that you continue with the login/register process which will initialize the correct values for all your variables.
Find
Reply
AfiqIqbal
Big Clucker
***
Posts: 71
Threads: 9
Joined: Feb 2016
Reputation: 0
#16

18.06.2017, 19:26
Thanks for all the help, I fixed it.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 3 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help