[1fret]

Im making a jail command now i placed the timer to the unjail in ongamemodeinit but it only counts to negative numbers even if the player jailtime is 0, it still counts to negative numbers as long as the player connect to server...

PHP код:

//ongamemodeinit
    SetTimer("PrisonTimer", 1000, true);
//the command
CMD:ajail(playerid, params[])
{
    if(IsPlayerAdmin(playerid) || pInfo[playerid][Admin] >= 3)
    {
        new playerb, time, string[128], RandomCell;
         if(sscanf(params, "uis[64]", playerb, time, params)) return SendClientMessage(playerid, error, "Usage: /ajail [playerid] [time] [reason]");
        if(!IsPlayerConnected(playerb)) return SendClientMessage(playerid, error, "Player id not connected.");
        if(time == 0)
        {
            if(!pInfo[playerb][Jailed]) return SendClientMessage(playerid, 0xFFFFFF, "Player is not prisoned.");
            SetPlayerColor(playerb, error);
            pInfo[playerb][Jailed] = 0;
            pInfo[playerb][JailedTime] = time;
            SetPlayerInterior(playerb, 0);
            SetPlayerVirtualWorld(playerb, 0);
            RandomCell = random(sizeof(RandomJails));
            SetPlayerFacingAngle(playerb, 88.5042);
            SetPlayerPos(playerb, 1548.8394,-1669.6111,13.5656);
            SetCameraBehindPlayer(playerb);
            format(string, sizeof(string), "[AdmCmd]: {FF6347}An Administrator has released %s from Jail. [Reason: %s]",GetName(playerb), params);
            SendClientMessageToAll(red, string);
            format(string, sizeof(string), "[AdmCmd]:{FF6347}You have been released by administrator %s.",GetName(playerid));
            SendClientMessage(playerid,red, string);
            TogglePlayerControllable(playerb, 1);
        }
        else
        {
            SetPlayerColor(playerb, error);
            pInfo[playerb][Jailed] = 2;
            pInfo[playerb][JailedTime] = time*60;
            SetPlayerVirtualWorld(playerb, 1337);
                  SetPlayerInterior(playerb, 3);
            ResetPlayerWeapons(playerb);
            RandomCell = random(sizeof(RandomJails));
            SetPlayerFacingAngle(playerb, RandomJails[RandomCell][3]);
            TogglePlayerControllable(playerb, 0);
            SetTimerEx("EnterExitTimer", 5000, false, "i", playerb);
            SetPlayerPos(playerb, RandomJails[RandomCell][0], RandomJails[RandomCell][1], RandomJails[RandomCell][2]);
            SetCameraBehindPlayer(playerb);
            format(string, sizeof(string), "[AdmCmd]: {FF6347}An Administrator has jailed %s. [Reason: %s]", GetName(playerb), params);
            SendClientMessageToAll(red, string);
            format(string, sizeof(string), "[AdmCmd]: {FF6347}You have been jailed by administrator %s. Minutes: %d || Seconds: %d",GetName(playerid), pInfo[playerb][JailedTime]/60, pInfo[playerb][JailedTime]);
            SendClientMessage(playerb, red, string);
            GameTextForPlayer(playerb, "~w~Loading Objects", 3500, 3);
            TogglePlayerControllable(playerb, 0);
            SetTimerEx("EnterExitTimer", 5000, false, "i", playerb);
            pInfo[playerb][pSpawnFreeze] = 1;
            RemovePlayerAttachedObject(playerb, 0);
            SetPlayerSpecialAction(playerb, SPECIAL_ACTION_NONE);
        }
    }
      else return ShowMessage(playerid, error, 1);
      return 1;
} 


PHP код:

forward PrisonTimer();
public PrisonTimer()
{
    foreach(Player, playerid)
    {
        if(pInfo[playerid][Jailed] == 2)
        {
            pInfo[playerid][Jailed] = 0;
            pInfo[playerid][JailedTime] = 0;
            SetPlayerInterior(playerid, 0);
            SetPlayerVirtualWorld(playerid, 0);
            SetPlayerFacingAngle(playerid, 88.5042);
            SetPlayerColor(playerid, error);
            SetPlayerPos(playerid, 1548.8394,-1669.6111,13.5656);
            SetCameraBehindPlayer(playerid);
            SendClientMessage(playerid, jblue, " Time Served. Be on your best behaviour now :) .");
        }
        else
        {
            new string[128];
            pInfo[playerid][JailedTime] --;
            format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[playerid][JailedTime]);
            GameTextForPlayer(playerid, string, 1500, 3);
        }
    }
    return 1;
} 


[sams90]

try this sir

PHP код:

forward PrisonTimer(); 
public PrisonTimer() 
{ 
    new string[128]; 
    format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[playerid][JailedTime]);
    foreach(Player, playerid) 
    { 
        if(pInfo[playerid][Jailed] == 2) 
        { 
            KillTimer(PrisonTimer[playerid]);
            pInfo[playerid][Jailed] = 0; 
            pInfo[playerid][JailedTime] = 0; 
            SetPlayerInterior(playerid, 0); 
            SetPlayerVirtualWorld(playerid, 0); 
            SetPlayerFacingAngle(playerid, 88.5042); 
            SetPlayerColor(playerid, error); 
            SetPlayerPos(playerid, 1548.8394,-1669.6111,13.5656); 
            SetCameraBehindPlayer(playerid); 
            SendClientMessage(playerid, jblue, " Time Served. Be on your best behaviour now :) ."); 
        } 
        else 
        { 
            GameTextForPlayer(playerid, string, 1500, 3); 
        } 
    } 
    pInfo[playerid][JailedTime] --;
    return 1; 
} 


[1fret]

Quote:

Originally Posted by sams90 try this sir PHP код: forward PrisonTimer();  public PrisonTimer()  {      new string[128];      format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[playerid][JailedTime]);     foreach(Player, playerid)      {          if(pInfo[playerid][Jailed] == 2)          {              KillTimer(PrisonTimer[playerid]);             pInfo[playerid][Jailed] = 0;              pInfo[playerid][JailedTime] = 0;              SetPlayerInterior(playerid, 0);              SetPlayerVirtualWorld(playerid, 0);              SetPlayerFacingAngle(playerid, 88.5042);              SetPlayerColor(playerid, error);              SetPlayerPos(playerid, 1548.8394,-1669.6111,13.5656);              SetCameraBehindPlayer(playerid);              SendClientMessage(playerid, jblue, " Time Served. Be on your best behaviour now :) .");          }          else          {              GameTextForPlayer(playerid, string, 1500, 3);          }      }      pInfo[playerid][JailedTime] --;     return 1;  }

I dont think that will fix anything...

[sams90]

did u try that?

[1fret]

Quote:

Originally Posted by sams90 did u try that?

By the look of it and to my experience in pawno, you only just moved the string to the top , that doesnt solve the issue.. The issue at hand is , the timer is not counting down the time properly

[khRamin78]

first of all dont define one things 2x time

PHP код:

if(sscanf(params, "uis[64]", playerb, time, params))
//you are defining params 2x times upthere try new reason[]; instead of params 


then why are you using this at if (time == 0) ?

PHP код:

RandomCell = random(sizeof(RandomJails)); 


and why are you setting timers 2x time ?

PHP код:

SetTimerEx("EnterExitTimer", 5000, false, "i", playerb); 


and can you explain me how it works ?

PHP код:

// in top you are setting pInfo[playerid][Jailed] == 2 when a player gets jailed by admin 
// and in down you are checking if pInfo[playerid][Jailed] == 2 so :S when the else part is called ?
 foreach(Player, playerid) 
    { 
        if(pInfo[playerid][Jailed] == 2) 
        { 
            pInfo[playerid][Jailed] = 0; 
            pInfo[playerid][JailedTime] = 0; 
            SetPlayerInterior(playerid, 0); 
            SetPlayerVirtualWorld(playerid, 0); 
            SetPlayerFacingAngle(playerid, 88.5042); 
            SetPlayerColor(playerid, error); 
            SetPlayerPos(playerid, 1548.8394,-1669.6111,13.5656); 
            SetCameraBehindPlayer(playerid); 
            SendClientMessage(playerid, jblue, " Time Served. Be on your best behaviour now :) ."); 
        } 
        else 
        { 
            new string[128]; 
            pInfo[playerid][JailedTime] --; 
            format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[playerid][JailedTime]); 
            GameTextForPlayer(playerid, string, 1500, 3); 
        } 
    } 


im sure this will work for you

PHP код:

public PrisonTimer()
{
    for(new i;i<MAX_PLAYERS;i++)
    {
        if(pInfo[i][Jailed] > 0)
        {
            if(pInfo[i][JailedTime] == 0)
            {
                pInfo[i][Jailed] = 0;
                SetPlayerInterior(i, 0);
                SetPlayerVirtualWorld(i, 0);
                SetPlayerFacingAngle(i, 88.5042);
                SetPlayerColor(i, error);
                    SetPlayerPos(i, 1548.8394,-1669.6111,13.5656);
                SetCameraBehindPlayer(i);
                    SendClientMessage(i, jblue, " Time Served. Be on your best behaviour now :) .");
            }
            else
            {
                new string[128];
                pInfo[i][JailedTime] --;
                    format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[i][JailedTime]);
                GameTextForPlayer(i, string, 1500, 3);
            }
        }
    }
    return 1;
} 


[1fret]

Quote:

Originally Posted by khRamin78 first of all dont define one things 2x time PHP код: if(sscanf(params, "uis[64]", playerb, time, params)) //you are defining params 2x times upthere try new reason[]; instead of params  then why are you using this at if (time == 0) ? PHP код: RandomCell = random(sizeof(RandomJails));  and why are you setting timers 2x time ? PHP код: SetTimerEx("EnterExitTimer", 5000, false, "i", playerb);  and can you explain me how it works ? PHP код: // in top you are setting pInfo[playerid][Jailed] == 2 when a player gets jailed by admin  // and in down you are checking if pInfo[playerid][Jailed] == 2 so :S when the else part is called ?  foreach(Player, playerid)      {          if(pInfo[playerid][Jailed] == 2)          {              pInfo[playerid][Jailed] = 0;              pInfo[playerid][JailedTime] = 0;              SetPlayerInterior(playerid, 0);              SetPlayerVirtualWorld(playerid, 0);              SetPlayerFacingAngle(playerid, 88.5042);              SetPlayerColor(playerid, error);              SetPlayerPos(playerid, 1548.8394,-1669.6111,13.5656);              SetCameraBehindPlayer(playerid);              SendClientMessage(playerid, jblue, " Time Served. Be on your best behaviour now :) .");          }          else          {              new string[128];              pInfo[playerid][JailedTime] --;              format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[playerid][JailedTime]);              GameTextForPlayer(playerid, string, 1500, 3);          }      }  im sure this will work for you PHP код: public PrisonTimer() {     for(new i;i<MAX_PLAYERS;i++)     {         if(pInfo[i][Jailed] > 0)         {             if(pInfo[i][JailedTime] == 0)             {                 pInfo[i][Jailed] = 0;                 SetPlayerInterior(i, 0);                 SetPlayerVirtualWorld(i, 0);                 SetPlayerFacingAngle(i, 88.5042);                 SetPlayerColor(i, error);                     SetPlayerPos(i, 1548.8394,-1669.6111,13.5656);                 SetCameraBehindPlayer(i);                     SendClientMessage(i, jblue, " Time Served. Be on your best behaviour now :) .");             }             else             {                 new string[128];                 pInfo[i][JailedTime] --;                     format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[i][JailedTime]);                 GameTextForPlayer(i, string, 1500, 3);             }         }     }     return 1; }

You guys are not getting the issue at hand, the issue is the timer wont count down the players jailed time to release them, thats the issue...

And the enterexittimer freezes players cause i used a mapped prison so it load the objects then unfreeze the players

[khRamin78]

Quote:

Originally Posted by 1fret You guys are not getting the issue at hand, the issue is the timer wont count down the players jailed time to release them, thats the issue... And the enterexittimer freezes players cause i used a mapped prison so it load the objects then unfreeze the players

i got what your problem is and also i give it a fix try that it will work

PHP код:

public PrisonTimer() 
{ 
    for(new i;i<MAX_PLAYERS;i++) 
    { 
        if(pInfo[i][Jailed] > 0) 
        { 
            if(pInfo[i][JailedTime] == 0) 
            { 
                pInfo[i][Jailed] = 0; 
                SetPlayerInterior(i, 0); 
                SetPlayerVirtualWorld(i, 0); 
                SetPlayerFacingAngle(i, 88.5042); 
                SetPlayerColor(i, error); 
                    SetPlayerPos(i, 1548.8394,-1669.6111,13.5656); 
                SetCameraBehindPlayer(i); 
                    SendClientMessage(i, jblue, " Time Served. Be on your best behaviour now :) ."); 
            } 
            else 
            { 
                new string[128]; 
                pInfo[i][JailedTime] --; 
                    format(string,sizeof(string),"~r~Jailed Time Left: ~w~%d ~r~seconds", pInfo[i][JailedTime]); 
                GameTextForPlayer(i, string, 1500, 3); 
            } 
        } 
    } 
    return 1; 
} 


actully your problem was that in prisontimer that else state wont ever be called thats why it dosnt work and with this code it will work try that

[1fret]

RESOLVED