1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Help In Exp System
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#1

27.12.2016, 22:57
This Codes in my Gamemode
PHP код:
new old_Exp[MAX_PLAYERS];
new new_Exp[MAX_PLAYERS];
public OnGameModeExit()
{
    for(new playerid = 0; playerid < MAX_PLAYERS; playerid++)
    {
        TextDrawHideForAll(Rank[playerid]);
        TextDrawDestroy(Rank[playerid]);
         TextDrawHideForAll(Exp[playerid]);
    TextDrawDestroy(Exp[playerid]);
    }
return 1;
}
public OnPlayerConnect(playerid)
{
    new_Exp[playerid] = 0;
    old_Exp[playerid] = 120;
    new temp_str[10];
    strcat(new_string , "Exp:");
    valstr(temp_str ,new_Exp[playerid]);
    strcat(new_string ,temp_str[playerid]);
    strcat(new_string , "/");
    valstr(temp_str ,old_Exp[playerid]);
    strcat(new_string ,temp_str[playerid]);
    Exp[playerid] = TextDrawCreate(484.000000, 98.559997,new_string);
    TextDrawLetterSize(Exp[playerid], 0.345998, 1.413333);
    TextDrawAlignment(Exp[playerid], 1);
    TextDrawColor(Exp[playerid], -2139094785);
    TextDrawSetShadow(Exp[playerid], 0);
    TextDrawSetOutline(Exp[playerid], 1);
    TextDrawBackgroundColor(Exp[playerid], 51);
    TextDrawFont(Exp[playerid], 1);
    TextDrawSetProportional(Exp[playerid], 1);
    Rank[playerid] = TextDrawCreate(483.999877, 113.493309, "Level: 0 Rank: Beginner");
    TextDrawLetterSize(Rank[playerid], 0.353999, 1.450666);
    TextDrawAlignment(Rank[playerid], 1);
    TextDrawColor(Rank[playerid], -2139094785);
    TextDrawSetShadow(Rank[playerid], 0);
    TextDrawSetOutline(Rank[playerid], 1);
    TextDrawBackgroundColor(Rank[playerid], 51);
    TextDrawFont(Rank[playerid], 1);
    TextDrawSetProportional(Rank[playerid], 1);
    ExpFNL[playerid] = TextDrawCreate(472.000000, 126.186546, "Exp For Next Level: 120");
    TextDrawLetterSize(ExpFNL[playerid], 0.373999, 1.383466);
    TextDrawAlignment(ExpFNL[playerid], 1);
    TextDrawColor(ExpFNL[playerid], -2139094785);
    TextDrawSetShadow(ExpFNL[playerid], 0);
    TextDrawSetOutline(ExpFNL[playerid], 1);
    TextDrawBackgroundColor(ExpFNL[playerid], 51);
    TextDrawFont(ExpFNL[playerid], 1);
    TextDrawSetProportional(ExpFNL[playerid], 1);
     TextDrawShowForPlayer(playerid, Exp[playerid]);
      TextDrawShowForPlayer(playerid, Rank[playerid]);
       TextDrawShowForPlayer(playerid, ExpFNL[playerid]);
        return 1;
}
public OnPlayerDeath(playerid, killerid, reason)
{
    if(killerid != INVALID_PLAYER_ID)
    {
        SendDeathMessage(killerid, playerid, reason);
    GivePlayerMoney(playerid,-GetPlayerMoney(playerid)/2);
    PlayerInfo[killerid][pKills] += 1;
    PlayerInfo[killerid][pScore] += 1;
    SetPlayerScore(killerid, PlayerInfo[killerid][pScore]);
    new temp_str[10];
    new_Exp[killerid] = new_Exp[killerid] + 90;
    new_Exp[playerid] = new_Exp[playerid] - 90;
      if(new_Exp[playerid] < 0)
    {
        new_Exp[playerid] = 0;
      }
    if(new_Exp[killerid] >= 120)
    {
           old_Exp[killerid] = 380;
         SendClientMessage(killerid,COLOR_YELLOW,"New Level");
      }
    new_string = "";
    strcat(new_string , "Exp:");
    valstr(temp_str ,new_Exp[killerid]);
    strcat(new_string ,temp_str);
    strcat(new_string , "/");
    valstr(temp_str ,old_Exp[playerid]);
    strcat(new_string ,temp_str);
    TextDrawSetString(Exp[killerid], new_string);
    TextDrawShowForPlayer(killerid, Exp[killerid]);
    new_string = "";
    strcat(new_string , "Exp:");
    valstr(temp_str ,new_Exp[playerid]);
    strcat(new_string ,temp_str);
    strcat(new_string , "/");
    valstr(temp_str ,old_Exp[playerid]);
    strcat(new_string ,temp_str);
    TextDrawSetString(Exp[playerid], new_string);
    TextDrawShowForPlayer(playerid, Exp[playerid]);
    }
    return 1;
} 
please help me what's Wrong i don't know why this have bugs and dos'nt work
Find
Reply
Lordzy
High-roller
*****
Posts: 2,698
Threads: 37
Joined: Mar 2012
Reputation: 0
#2

27.12.2016, 22:59
"new_string" should be indexed on it's declaration. You haven't mentioned the bug, so do explain the bug.
(NVM : Seems like 'new_string' is a global variable..)
Find
Reply
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#3

27.12.2016, 23:00
i can run the server and give you ip now for you Check it yor self if you want
Find
Reply
Lordzy
High-roller
*****
Posts: 2,698
Threads: 37
Joined: Mar 2012
Reputation: 0
#4

27.12.2016, 23:03
I edited my first post, you might want to check that out. What makes you unable to explain the bug? I can't connect to your SA-MP server right now. If you're not willing to explain the bug, wait for someone to connect to your server and solve.
Find
Reply
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#5

27.12.2016, 23:07
problem is Not Simple you if you kill One player Sometimes The first line Change to ALAM Sometimes Changes to
0/120 0/120
!
Find
Reply
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#6

28.12.2016, 09:42
i runned the server and i'm there if you want help join and kill me check this bug 151.246.24.31
Find
Reply
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#7

28.12.2016, 10:06
Please Someone give me a true Code
Find
Reply
Swedky
Banned
Posts: 2,041
Threads: 97
Joined: Jun 2013
#8

28.12.2016, 13:34
Are you using NPCs? I don't know why, but NPCs always bug strings (atleast for me).

Use "format" instead "strcat".
Find
Reply
Ramin
Big Clucker
***
Posts: 76
Threads: 17
Joined: Aug 2014
Reputation: 0
#9

28.12.2016, 13:37
NPC is Include? no just i used this includes #include <a_samp>
#include <zcmd>
#include <YSI\y_ini>
#include <sscanf2>
#include <AWC>
#include <mSelection>
#include <create_veh>
#include <moneyhax>
#include <foreach>


#include <mxINI>
Find
Reply
RIDE2DAY
Huge Clucker
***
Posts: 212
Threads: 14
Joined: Jul 2015
Reputation: 0
#10

28.12.2016, 15:18
PHP код:
new old_Exp[MAX_PLAYERS];
new new_Exp[MAX_PLAYERS];
public OnGameModeExit()
{
    for(new playerid = 0; playerid < MAX_PLAYERS; playerid++)
    {
        TextDrawHideForAll(Rank[playerid]);
        TextDrawDestroy(Rank[playerid]);
        TextDrawHideForAll(Exp[playerid]);
        TextDrawDestroy(Exp[playerid]);
    }
    return 1;
}
public OnPlayerConnect(playerid)
{
    /* I declare new_string just in case of you don't have it. */
    new new_string[15];
    
    new_Exp[playerid] = 0;
    old_Exp[playerid] = 120;
    
    /* You don't have to convert integers to strings in this case, you can use format instead and the %d specifier. */
    format(new_string, sizeof(new_string), "Exp: %d/%d", new_Exp[playerid], old_Exp[playerid]);
    Exp[playerid] = TextDrawCreate(484.000000, 98.559997, new_string);
    TextDrawLetterSize(Exp[playerid], 0.345998, 1.413333);
    TextDrawAlignment(Exp[playerid], 1);
    TextDrawColor(Exp[playerid], -2139094785);
    TextDrawSetShadow(Exp[playerid], 0);
    TextDrawSetOutline(Exp[playerid], 1);
    TextDrawBackgroundColor(Exp[playerid], 51);
    TextDrawFont(Exp[playerid], 1);
    TextDrawSetProportional(Exp[playerid], 1);
    Rank[playerid] = TextDrawCreate(483.999877, 113.493309, "Level: 0 Rank: Beginner");
    TextDrawLetterSize(Rank[playerid], 0.353999, 1.450666);
    TextDrawAlignment(Rank[playerid], 1);
    TextDrawColor(Rank[playerid], -2139094785);
    TextDrawSetShadow(Rank[playerid], 0);
    TextDrawSetOutline(Rank[playerid], 1);
    TextDrawBackgroundColor(Rank[playerid], 51);
    TextDrawFont(Rank[playerid], 1);
    TextDrawSetProportional(Rank[playerid], 1);
    ExpFNL[playerid] = TextDrawCreate(472.000000, 126.186546, "Exp For Next Level: 120");
    TextDrawLetterSize(ExpFNL[playerid], 0.373999, 1.383466);
    TextDrawAlignment(ExpFNL[playerid], 1);
    TextDrawColor(ExpFNL[playerid], -2139094785);
    TextDrawSetShadow(ExpFNL[playerid], 0);
    TextDrawSetOutline(ExpFNL[playerid], 1);
    TextDrawBackgroundColor(ExpFNL[playerid], 51);
    TextDrawFont(ExpFNL[playerid], 1);
    TextDrawSetProportional(ExpFNL[playerid], 1);
    TextDrawShowForPlayer(playerid, Exp[playerid]);
    TextDrawShowForPlayer(playerid, Rank[playerid]);
    TextDrawShowForPlayer(playerid, ExpFNL[playerid]);
     return 1;
}
public OnPlayerDeath(playerid, killerid, reason)
{
    if(killerid != INVALID_PLAYER_ID)
    {
        SendDeathMessage(killerid, playerid, reason);
        GivePlayerMoney(playerid, -GetPlayerMoney(playerid)/2);
        PlayerInfo[killerid][pKills]++;
        PlayerInfo[killerid][pScore]++;
        SetPlayerScore(killerid, PlayerInfo[killerid][pScore]);
        new_Exp[killerid] += 90;
        new_Exp[playerid] -= 90;
          if(new_Exp[playerid] < 0)
        {
            new_Exp[playerid] = 0;
          }
          
        if(new_Exp[killerid] >= 120)
        {
            old_Exp[killerid] += 380; // You missed the + to increase its value, I guess it should be += 120 actually.
             SendClientMessage(killerid,COLOR_YELLOW,"New Level");
          }
          
        /* I declare new_string just in case of you don't have it. */
        new new_string[15];
    
        format(new_string, sizeof(new_string), "Exp: %d/%d", new_Exp[killerid], old_Exp[killer]);
        
        TextDrawSetString(Exp[killerid], new_string);
        TextDrawShowForPlayer(killerid, Exp[killerid]);
        format(new_string, sizeof(new_string), "Exp: %d/%d", new_Exp[playerid], old_Exp[playerid]);
        TextDrawSetString(Exp[playerid], new_string);
        TextDrawShowForPlayer(playerid, Exp[playerid]);
    }
    return 1;
} 
I found many errors there, I added a comment where I could. You should move to PlayerTextdraws by the way.

Stop using ambiguous variable names.
PHP код:
new new_string[10]; // This hurts my eyes.
/* You should use something like: */
new p_CurrentExp[MAX_PLAYERS];
new p_OldExp[MAX_PLAYERS];
new exp_string[15]; 
It's up to you.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help