[Naruto_Emilio]

Hello guys, I am facing a serious problem, which is people uses cheat engine to modify dialog items names, it affects my server because my server uses an inventory system, it wasnt made by me, and I dont want to remove it, I dont have time for it, if theres any fix for this, or anything that I can block people from using cheat engine i'll be gladful

[SickAttack]

Don't have time to solve problems? Don't open a server.

-> I remind you that this board isn't for requests.

[Naruto_Emilio]

Quote:

Originally Posted by SickAttack Don't have time to solve problems? Don't open a server. -> I remind you that this board isn't for requests.

The board is for scripting help, I am requesting help from people, if you cant help, then you shouldnt post here, go somewhere else to show off..

[SickAttack]

Quote:

Originally Posted by Naruto_Emilio The board is for scripting help, I am requesting help from people, if you cant help, then you shouldnt post here, go somewhere else to show off..

This board is for requesting help on code you have written... Go read the forum specific rules.

[Naruto_Emilio]

bump

[Micko123]

You have 351 reputation and 1882 posts and still don't know for rules..

[MikeB]

Quote:

Originally Posted by Micko123 You have 351 reputation and 1882 posts and still don't know for rules..

Post count/reputation doesn't define knowledge.

[Threshold]

Instead of relying on the client's response, you should try and keep everything server-sided if possible.

For example:

PHP Code:

#define DIALOG_TEST 1

#define MAX_LIST_ITEMS 25        // The maximum amount of list items
#define MAX_LIST_ITEM_TEXT 60    // The maximum length a list item text can be

new
    ListItem[MAX_PLAYERS][MAX_LIST_ITEMS][MAX_LIST_ITEM_TEXT],
    Player_ListItem[MAX_PLAYERS] = {0, ...}
;

#define AddListItem(%0,%1) format(ListItem[(%0)][Player_ListItem[(%0)]++], sizeof(ListItem[][]), (%1))
#define ClearListItems(%0); for(new litem = 0; litem != sizeof(ListItem[]); litem++) ListItem[(%0)][litem][0] = EOS; Player_ListItem[(%0)] = 0;

public OnPlayerSpawn(playerid)
{
    AddListItem(playerid, "1. Briefcase");
    AddListItem(playerid, "2. Torn Letter");
    AddListItem(playerid, "3. Cyanide Pills");
    AddListItem(playerid, "4. Toolbox");
    ShowListDialog(playerid, DIALOG_TEST, .caption = "Items List");
    return 1;
}

ShowListDialog(playerid, dialogid, caption[] = "Dialog")
{
    new dialog_str[MAX_LIST_ITEMS * MAX_LIST_ITEM_TEXT];
    for(new i = 0; i < sizeof(ListItem[]); i++)
    {
        if(ListItem[playerid][i][0] == EOS) break;
        format(dialog_str, sizeof(dialog_str), "%s\n%s", dialog_str, ListItem[playerid][i]);
    }
    return ShowPlayerDialog(playerid, dialogid, DIALOG_STYLE_LIST, caption, dialog_str, "Select", "Exit");
}

public OnDialogResponse(playerid, dialogid, response, listitem, inputtext[])
{
    if(response)
    {
        switch(dialogid)
        {
            case DIALOG_TEST:
            {
                printf("%s | %s", inputtext, ListItem[playerid][listitem]);
                if(strcmp(inputtext, ListItem[playerid][listitem], true) != 0)
                {
                    // inputtext does not match the list item text they selected
                    //Kick(playerid);
                    return 0;
                }
                ClearListItems(playerid); // Reset the player's list items text
                return 1;
            }
        }
    }
    return 0;
} 


And I repeat, that is purely an example. You should make something that fits your own needs.

[Naruto_Emilio]

I would like to understand, how they are able to do it?

[PrO.GameR]

You can simply validate the inputtext before using it, I assume you use something like PlayerInv[playerid][0]="Water" or maybe inv item indexes, simply validate it like !strcmp(PlayerInv[playerid][listitem],inputtext)
or something similar, I have no idea how your inv is coded.

They simply change inputtext, they have no access to anything else.

[Threshold]

It's actually very easy. You can even change a players name, client messages and everything. Of course only you will see the changes, but when such information is sent back to the server, that's when you need protection from it.

[Micko123]

Quote:

Originally Posted by MikeB Post count/reputation doesn't define knowledge.

Noone said it does. What am I saying is that those much posts and reps took time to get.. And with that time some rules should be learned..

[TwinkiDaBoss]

So lets say someone changes dialog name and list items name, how does it even affect you? You are using dialog ids to retrieve data arent you? Also show us some code if you want help.

[Threshold]

When using dialog type DIALOG_STYLE_LIST, the selection you choose also sends the list item text in the form of 'inputtext' in OnDialogResponse.

While using inputtext as a method of selecting an item is not the safest, it's probably one of the easiest once you have protection against players that can change this text.

[SickAttack]

The script shouldn't be using the text of the selected item in the first place, rather an array with an index (listitem).