1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Server stops after OnPlayerSpawn
ChristolisTV
Big Clucker
***
Posts: 154
Threads: 23
Joined: Feb 2015
Reputation: 0
#1

01.10.2016, 08:54
Hello there people! I have a really serious problem which I can't deal with. When I spawn, my server crashes.

OnPlayerSpawn:
PHP код:
public OnPlayerSpawn(playerid)
{
    new
        Query[250],
        DBResult: Result,
        pName[250],
         Field[20],
        Field2[20],
         Field3[20],
        Field4[20]
    ;
    GetPlayerName(playerid, pName, sizeof(pName));
    
    format(Query, sizeof(Query), "SELECT * FROM `Accounts` WHERE Name = '%s'", DB_Escape(pName));
    Result = db_query(Database, Query);
    db_get_field_assoc(Result, "Skin", Field, 30);
    SetPlayerSkin(playerid, strval(Field));
    
    db_get_field_assoc(Result, "Interior", Field, 30);
    SetPlayerInterior(playerid, strval(Field));
    
    db_get_field_assoc(Result, "Angle", Field, 30);
    SetPlayerFacingAngle(playerid, strval(Field));
    
    db_get_field_assoc(Result, "Skin", Field, 30);
    SetPlayerSkin(playerid, strval(Field));
    
    db_get_field_assoc(Result, "X", Field2, 30);
    format(Field, sizeof(Field2), "%f", Field2);
    
    db_get_field_assoc(Result, "Y", Field3, 30);
    format(Field, sizeof(Field3), "%f", Field3);
    
    db_get_field_assoc(Result, "Z", Field4, 30);
    format(Field, sizeof(Field4), "%f", Field4);
    
    SetPlayerPos(playerid, strval(Field2), strval(Field3), strval(Field4));
    SetCameraBehindPlayer(playerid);
    db_free_result(Result);
     return 1;
} 
If I solve my problem, the helper gets a rep from me.
Find
Reply
SickAttack
High-roller
*****
Posts: 4,759
Threads: 33
Joined: Dec 2013
Reputation: 0
#2

01.10.2016, 09:05
Quote:
Originally Posted by Wiki
Using an invalid handle will crash your server! Get a valid handle by using db_query. But it's protected against NULL references.
Other:
- Use the new functions such as getting a value from the database as an integer/float.
- Fix the cells you specified, player names are up to 24 chars, those field variables you created are set to 20 but you put 30 in the function.
- Learn to debug your code, you can find the exact issue (to debug add prints after calling each function, see where it stops at).
- Load crashdetect plugin. Read and find the issue based on what it prints.
Find
Reply
Konstantinos
Spam Machine
*****
Posts: 11,827
Threads: 33
Joined: Dec 2011
Reputation: 0
#3

01.10.2016, 09:07
You don't check if there are rows before retrieving the data.
Find
Reply
ChristolisTV
Big Clucker
***
Posts: 154
Threads: 23
Joined: Feb 2015
Reputation: 0
#4

01.10.2016, 09:14
Quote:
Originally Posted by Konstantinos
Посмотреть сообщение
You don't check if there are rows before retrieving the data.
Didn't work.
PHP код:
public OnPlayerSpawn(playerid)
{
    new
        Query[250],
        DBResult: Result,
        pName[250],
         Field[20],
        Field2[20],
         Field3[20],
        Field4[20]
    ;
    GetPlayerName(playerid, pName, sizeof(pName));
    
    format(Query, sizeof(Query), "SELECT * FROM `Accounts` WHERE Name = '%s'", DB_Escape(pName));
    Result = db_query(Database, Query);
    if(db_num_rows(Result))
    {
        db_get_field_assoc(Result, "Skin", Field, 30);
        SetPlayerSkin(playerid, strval(Field));
        db_get_field_assoc(Result, "Interior", Field, 30);
        SetPlayerInterior(playerid, strval(Field));
        db_get_field_assoc(Result, "Angle", Field, 30);
        SetPlayerFacingAngle(playerid, strval(Field));
        db_get_field_assoc(Result, "Skin", Field, 30);
        SetPlayerSkin(playerid, strval(Field));
        db_get_field_assoc(Result, "X", Field2, 30);
        format(Field, sizeof(Field2), "%f", Field2);
        db_get_field_assoc(Result, "Y", Field3, 30);
        format(Field, sizeof(Field3), "%f", Field3);
        db_get_field_assoc(Result, "Z", Field4, 30);
        format(Field, sizeof(Field4), "%f", Field4);
        SetPlayerPos(playerid, strval(Field2), strval(Field3), strval(Field4));
        SetCameraBehindPlayer(playerid);
    }
    db_free_result(Result);
     return 1;
} 
Find
Reply
Konstantinos
Spam Machine
*****
Posts: 11,827
Threads: 33
Joined: Dec 2011
Reputation: 0
#5

01.10.2016, 09:23
Like SickAttack said, load crashdetect plugin to see what is causing the crash. If the data in a column retrieved was null, it used to crash but that is supposed fixed in 0.3.7 R* version.

The thing I'm unsure is if you try to retrieve a field that does not exist, you better enable db_logging (in server.cfg, set that setting to 1).
Find
Reply
ChristolisTV
Big Clucker
***
Posts: 154
Threads: 23
Joined: Feb 2015
Reputation: 0
#6

01.10.2016, 09:32
I loaded crashdetect.dll and no errors detected. I also set db_logging to 1. Didn't work though.

server_log:

Код:
----------
Loaded log file: "server_log.txt".
----------

SA-MP Dedicated Server
----------------------
v0.3.7, ©2005-2015 SA-MP Team

[12:24:25] 
[12:24:25] Server Plugins
[12:24:25] --------------
[12:24:25]  Loading plugin: sscanf.dll
[12:24:25] 

[12:24:25]  ===============================

[12:24:25]       sscanf plugin loaded.     

[12:24:25]          Version:  2.8.1        

[12:24:25]    © 2012 Alex "******" Cole  

[12:24:25]  ===============================

[12:24:25]   Loaded.
[12:24:25]  Loading plugin: Whirlpool.dll
[12:24:25]  
[12:24:25]  ==================
[12:24:25]  
[12:24:25]   Whirlpool loaded
[12:24:25]  
[12:24:25]  ==================
[12:24:25]  
[12:24:25]   Loaded.
[12:24:25]  Loading plugin: audio.dll
[12:24:25] 

*** Audio Plugin v0.5 R2 by Incognito loaded ***

[12:24:25]   Loaded.
[12:24:25]  Loading plugin: crashdetect.dll
[12:24:25]   CrashDetect v4.16 is OK.
[12:24:25]   Loaded.
[12:24:25]  Loading plugin: streamer.dll
[12:24:25] 

*** Streamer Plugin v2.5.2 by Incognito loaded ***

[12:24:25]   Loaded.
[12:24:25]  Loading plugin: FCNPC.dll
[12:24:25] 
[12:24:25] -------------------------------------------------
[12:24:25]      FCNPC - Fully Controllable NPC v1.0.5
[12:24:25] 
[12:24:25] - Author: OrMisicL
[12:24:25] - Contributors: ziggi, Neutralneu
[12:24:25] - Server version: 0.3.7
[12:24:25] - Build: Apr 17 2016 at 01:34:41
[12:24:25] -------------------------------------------------
[12:24:25] 
[12:24:25] Loading...
[12:24:25]   Loaded.
[12:24:25]  Loaded 6 plugins.

[12:24:25] 
[12:24:25] Filterscripts
[12:24:25] ---------------
[12:24:25]   Loading filterscript 'GarHouse.amx'...
[12:24:25] Warning: the maxplayers limit is less than maxnpc (possible crash)
[12:24:25]  
[12:24:25]  ======================================= 
[12:24:25]  |                                     | 
[12:24:25]  |        YSI version 1.03.0011        | 
[12:24:25]  |        By Alex "******" Cole        | 
[12:24:25]  |                                     | 
[12:24:25]  |  Checking the latest YSI version..  | 
[12:24:25]  |                                     | 
[12:24:25]  ======================================= 
[12:24:25]  
[12:24:25] 
>> Attempting to load GarHouse v2.0... <<

[12:24:25] *** Audio Plugin: Started TCP server on port 7777
[12:24:25] 
Total House Interiors Loaded: 11. Duration: 4 ms

[12:24:25] 
Total Houses Loaded: 7. Duration: 20 ms

[12:24:25] 
>> GarHouse v2.0 By [03]Garsino Loaded <<

[12:24:25]   Loading filterscript 'key2.amx'...
[12:24:25] 
--------------------------------------
[12:24:25]  >> Filterscript "Key 2" Loaded! <<
[12:24:25] --------------------------------------

[12:24:25]   Loading filterscript 'TimeSP.amx'...
[12:24:25] TLN's Time, Week & Day System Loaded!
[12:24:25]   Loading filterscript 'Sleep_System.amx'...
[12:24:25]  
[12:24:25]  
[12:24:25]  
[12:24:25]  ======================================= 
[12:24:25]  |                                     | 
[12:24:25]  |        YSI version 4.00.0001        | 
[12:24:25]  |        By Alex "******" Cole        | 
[12:24:25]  |                                     | 
[12:24:25]  ======================================= 
[12:24:25]  
[12:24:25] 
--------------------------------------------
[12:24:25] ! Using Sleep System by GoKkuU aka Frederico !
[12:24:25] --------------------------------------------

[12:24:25]   Loading filterscript 'CAccounts.amx'...
[12:24:25] 
--------------------------------------
[12:24:25]  Accounts system by Christolis. (LOADED)
[12:24:25] --------------------------------------

[12:24:25]   Loading filterscript 'zones.amx'...
[12:24:25] 
--------------------------------------
[12:24:25]  Zone System 0.1 by RoamPT 
[12:24:25] --------------------------------------

[12:24:25]   Loaded 6 filterscripts.

[12:24:25] *** Audio_SetPack: Audio pack set to "HotDog" (transferable and automated)
[12:24:25] ------------------------------------
[12:24:25]  Roreplay Gamemode by Christolis
[12:24:25] ------------------------------------
[12:24:25] Number of vehicle models: 36
[12:24:25]  
[12:24:25]  ========================================== 
[12:24:25]  |                                        | 
[12:24:25]  |  A new version (v3.09.0684) of YSI is  | 
[12:24:25]  |            available from:             | 
[12:24:25]  |                                        | 
[12:24:25]  |     www.y-less.com/YSI/YSI_1.0.zip     | 
[12:24:25]  |                                        | 
[12:24:25]  | Changelog:                             | 
[12:24:25]  |                                        | 
[12:24:25]  |   1.04.0000:                           | 
[12:24:25]  |                                        | 
[12:24:25]  |   RC 1 for YSI 3.0.  Available from:   | 
[12:24:25]  | http://www.y-less.com/YSI/YSI_3.0.rar  | 
[12:24:25]  | - includes MANY new libraries and      | 
[12:24:25]  | fixes, see                             | 
[12:24:25]  | http://forum.sa-mp.com/showthread.php? | 
[12:24:25]  | p=1425938 for more information, with   | 
[12:24:25]  | more topics and updates due over the   | 
[12:24:25]  | next few weeks.  In brief: Added       | 
[12:24:25]  | "y_inline", "y_text", "y_users",       | 
[12:24:25]  | "y_uvar", "y_svar", "y_remote";        | 
[12:24:25]  | updated "y_timers", "y_iter"; MANY     | 
[12:24:25]  | MANY fixes and tweaks in almost every  | 
[12:24:25]  | other library.                         | 
[12:24:25]  |                                        | 
[12:24:25]  |   3.00.0000:                           | 
[12:24:25]  |                                        | 
[12:24:25]  |   YSI 3.0 released!  Now includes the  | 
[12:24:25]  | "y_text" library for better messages,  | 
[12:24:25]  | and a reworked "y_classes" library.    | 
[12:24:25]  | Largely documented here                | 
[12:24:25]  | "http://forum.sa-mp.com/showthread.php | 
[12:24:25]  | ?t=321092".                            | 
[12:24:25]  |                                        | 
[12:24:25]  |   3.01.0002:                           | 
[12:24:25]  |                                        | 
[12:24:25]  |   Small fixes to "y_text" and          | 
[12:24:25]  | "y_classes".                           | 
[12:24:25]  |                                        | 
[12:24:25]  |   3.09.0684:                           | 
[12:24:25]  |                                        | 
[12:24:25]  |   Reverted to old download location.   | 
[12:24:25]  | Improved (and fixed) version checks;   | 
[12:24:25]  | added y_bitmap, y_areas, y_races,      | 
[12:24:25]  | y_zonenames, better documentation;     | 
[12:24:25]  | MANY other bug fixes - see the github  | 
[12:24:25]  | repository for more details:           | 
[12:24:25]  |                                        | 
[12:24:25]  ========================================== 
[12:24:25]  
[12:24:28] [connection] 127.0.0.1:50044 requests connection cookie.
[12:24:29] Incoming connection: 127.0.0.1:50044 id: 0
[12:24:29] [join] Christolis has joined the server (0:127.0.0.1)
Find
Reply
SickAttack
High-roller
*****
Posts: 4,759
Threads: 33
Joined: Dec 2013
Reputation: 0
#7

01.10.2016, 09:36
Do a debug that consists in commenting part by part of the code, until you find on which part the server crashes.
Find
Reply
ChristolisTV
Big Clucker
***
Posts: 154
Threads: 23
Joined: Feb 2015
Reputation: 0
#8

01.10.2016, 09:47
Quote:
Originally Posted by SickAttack
Посмотреть сообщение
Do a debug that consists in commenting part by part of the code, until you find on which part the server crashes.
Nice idea dude! Let me try and tell you if I solved my problem and give you the rep then.
Find
Reply
ChristolisTV
Big Clucker
***
Posts: 154
Threads: 23
Joined: Feb 2015
Reputation: 0
#9

01.10.2016, 10:50
I found the line that causes the crash, removed it temporarily but now it doesnt save my stats when I dissconnect.
PHP код:
public OnPlayerDisconnect(playerid, reason)
{
    new
        Query[350],
        DBResult: Result,
        pName[250],
        Float: pHealth,
        Float: pArmour,
        Float: Angle,
         Float:    X,
        Float:  Y,
         Float:    Z
    ;
    GetPlayerName(playerid, pName, sizeof(pName));
    GetPlayerPos(playerid, X, Y, Z);
    
    format(Query, sizeof(Query), "UPDATE `Accounts` SET Money = '%i', Health = '%f', Armour = '%f', X = '%f', Y = '%f', Z = '%f', Interior = '%f', Angle = '%f' WHERE Name = '%s'",
         GetPlayerMoney(playerid),
          GetPlayerHealth(playerid, pHealth),
         GetPlayerArmour(playerid, pArmour),
         X, Y, Z,
          GetPlayerInterior(playerid),
           GetPlayerFacingAngle(playerid, Angle),
          DB_Escape(pName));
          
    Result = db_query(Database, Query);
    
    db_free_result(Result);
    return 1;
} 
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help