1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
TextLable doesnt update?
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#1

26.06.2016, 09:20
Hello, i have this business system, and when a player sells his business to another player
it will give they key, and remove the key from the seller. But the 3dTextLable doest update
the owner name.

pawn Код:
else if(strcmp(x_job,"business",true) == 0)
            {
                if(BizOffer[playerid] < 999)
                {
                    if(PlayerInfo[playerid][pCash] > BizPrice[playerid])
                    {
                        if(IsPlayerConnected(BizOffer[playerid]))
                        {
                            if(ProxDetectorS(3.0, playerid, BizOffer[playerid]))
                            {
                                for(new i = 0; i < sizeof(BizzInfo); i++)
                                {
                                    GetPlayerName(GuardOffer[playerid], giveplayer, sizeof(giveplayer));
                                    GetPlayerName(playerid, sendername, sizeof(sendername));
                                    format(string, sizeof(string), "* You accepted the Business for $%d from %s.",BizPrice[playerid],giveplayer);
                                    SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
                                    format(string, sizeof(string), "* %s accepted your Business, and the $%d was added to your Bank Account.",sendername,BizPrice[playerid]);
                                    SendClientMessage(GuardOffer[playerid], COLOR_LIGHTBLUE, string);
                                    format(string, sizeof(string), "%s has accepted the business from %s for $%d", sendername,giveplayer,BizPrice[playerid]);
                                    PayLog(string);
                                    PlayerInfo[playerid][pPbiskey] = PlayerInfo[BizOffer[playerid]][pPbiskey];
                                    strmid(BizzInfo[i][bOwner], sendername, 0, strlen(sendername), 255);
                                    OnPropTextdrawUpdate(i);
                                    OnBizzPickupUpdate(i);
                                    OnPropUpdate();
                                    UpdateAccount(playerid);
                                    PlayerInfo[BizOffer[playerid]][pPbiskey] = 255;
                                    PlayerInfo[BizOffer[playerid]][pAccount] += BizPrice[playerid];
                                    PlayerInfo[playerid][pCash] = PlayerInfo[playerid][pCash]-BizPrice[playerid];
                                    GivePlayerMoney(playerid, -BizPrice[playerid]);
                                    BizOffer[playerid] = 999;
                                    BizPrice[playerid] = 0;
                                    OnPropTextdrawUpdate(i);
                                    OnBizzPickupUpdate(i);
                                    OnPropUpdate();
                                    return 1;
                                }
                            }
                            else
                            {
                                SendClientMessage(playerid, COLOR_GRAD1, "   You're too far away !");
                                return 1;
                            }
                        }
                        return 1;
                    }
                    else
                    {
                        SendClientMessage(playerid, COLOR_GREY, "   You can't afford that !");
                        return 1;
                    }
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GREY, "   Nobody offered you a business.");
                    return 1;
                }
            }
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#2

26.06.2016, 10:54
Anyone?
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#3

26.06.2016, 11:15
Hello!

Can you show us the code where you update the 3d text label?
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#4

26.06.2016, 11:21
Of course
pawn Код:
forward OnPropTextdrawUpdate(bizzid);
public OnPropTextdrawUpdate(bizzid)
{
    if(BizzInfo[bizzid][bOwned] == 0)
    {
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Status: For Sale \nPrice: $%s",BizzInfo[bizzid][bMessage],Comma(BizzInfo[bizzid][bBuyPrice]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    if(BizzInfo[bizzid][bOwned] == 1)
    {
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Owner: %s \nEntry Fee: $%s",BizzInfo[bizzid][bMessage],BizzInfo[bizzid][bOwner],Comma(BizzInfo[bizzid][bEntranceCost]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    return 1;
}
Find
Reply
Zevcore
Little Clucker
**
Posts: 33
Threads: 10
Joined: Jun 2015
Reputation: 0
#5

26.06.2016, 11:27
Use this: https://sampwiki.blast.hk/wiki/Update3DTextLabelText
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#6

26.06.2016, 11:30
PHP код:
else if(strcmp(x_job,"business",true) == 0)
{
    if(BizOffer[playerid] < 999)
     {
          if(PlayerInfo[playerid][pCash] > BizPrice[playerid])
        {
            if(IsPlayerConnected(BizOffer[playerid]))
            {
                  if(ProxDetectorS(3.0, playerid, BizOffer[playerid]))
                {
                    for(new i = 0; i < sizeof(BizzInfo); i++)
                     {
                            GetPlayerName(GuardOffer[playerid], giveplayer, sizeof(giveplayer));
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            if(!strcmp(BizzInfo[i][bOwner],giveplayer,true))
                            {
                                format(string, sizeof(string), "* You accepted the Business for $%d from %s.",BizPrice[playerid],giveplayer);
                                SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "* %s accepted your Business, and the $%d was added to your Bank Account.",sendername,BizPrice[playerid]);
                                SendClientMessage(GuardOffer[playerid], COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "%s has accepted the business from %s for $%d", sendername,giveplayer,BizPrice[playerid]);
                                PayLog(string);
                                PlayerInfo[playerid][pPbiskey] = PlayerInfo[BizOffer[playerid]][pPbiskey];
                                strmid(BizzInfo[i][bOwner], sendername, 0, strlen(sendername), 255);
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                UpdateAccount(playerid);
                                PlayerInfo[BizOffer[playerid]][pPbiskey] = 255;
                                PlayerInfo[BizOffer[playerid]][pAccount] += BizPrice[playerid];
                                PlayerInfo[playerid][pCash] = PlayerInfo[playerid][pCash]-BizPrice[playerid];
                                GivePlayerMoney(playerid, -BizPrice[playerid]);
                                 BizOffer[playerid] = 999;
                                BizPrice[playerid] = 0;
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                return 1;
                            }
                    }
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD1, "   You're too far away !");
                    return 1;
                }
            }
        }
        else
        {
              SendClientMessage(playerid, COLOR_GREY, "   You can't afford that !");
            return 1;
        }
     }
    else
    {
        SendClientMessage(playerid, COLOR_GREY, "   Nobody offered you a business.");
        return 1;
      }
} 
Try this. I put in this row:
PHP код:
if(!strcmp(BizzInfo[i][bOwner],giveplayer,true)) 
So the script will check if the bizz is yours. So you have the correct bizz id.
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#7

26.06.2016, 11:36
Still not working :/
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#8

26.06.2016, 11:39
PHP код:
forward OnPropTextdrawUpdate(bizzid);
public OnPropTextdrawUpdate(bizzid)
{
    if(BizzInfo[bizzid][bOwned] == 0)
    {
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Status: For Sale \nPrice: $%s",BizzInfo[bizzid][bMessage],Comma(BizzInfo[bizzid][bBuyPrice]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    if(BizzInfo[bizzid][bOwned] == 1)
    {
        printf("Bizz-ID #2: %i - Owner: %s",bizzid,BizzInfo[bizzid][bOwner]);
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Owner: %s \nEntry Fee: $%s",BizzInfo[bizzid][bMessage],BizzInfo[bizzid][bOwner],Comma(BizzInfo[bizzid][bEntranceCost]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    return 1;
}
else if(strcmp(x_job,"business",true) == 0)
{
    if(BizOffer[playerid] < 999)
     {
          if(PlayerInfo[playerid][pCash] > BizPrice[playerid])
        {
            if(IsPlayerConnected(BizOffer[playerid]))
            {
                  if(ProxDetectorS(3.0, playerid, BizOffer[playerid]))
                {
                    for(new i = 0; i < sizeof(BizzInfo); i++)
                     {
                            GetPlayerName(GuardOffer[playerid], giveplayer, sizeof(giveplayer));
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            if(!strcmp(BizzInfo[i][bOwner],giveplayer,true))
                            {
                                format(string, sizeof(string), "* You accepted the Business for $%d from %s.",BizPrice[playerid],giveplayer);
                                SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "* %s accepted your Business, and the $%d was added to your Bank Account.",sendername,BizPrice[playerid]);
                                SendClientMessage(GuardOffer[playerid], COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "%s has accepted the business from %s for $%d", sendername,giveplayer,BizPrice[playerid]);
                                PayLog(string);
                                printf("Bizz-ID: %i - New Owner: %s",i,sendername);
                                PlayerInfo[playerid][pPbiskey] = PlayerInfo[BizOffer[playerid]][pPbiskey];
                                strmid(BizzInfo[i][bOwner], sendername, 0, strlen(sendername), 255);
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                UpdateAccount(playerid);
                                PlayerInfo[BizOffer[playerid]][pPbiskey] = 255;
                                PlayerInfo[BizOffer[playerid]][pAccount] += BizPrice[playerid];
                                PlayerInfo[playerid][pCash] = PlayerInfo[playerid][pCash]-BizPrice[playerid];
                                GivePlayerMoney(playerid, -BizPrice[playerid]);
                                 BizOffer[playerid] = 999;
                                BizPrice[playerid] = 0;
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                return 1;
                            }
                    }
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD1, "   You're too far away !");
                    return 1;
                }
            }
        }
        else
        {
              SendClientMessage(playerid, COLOR_GREY, "   You can't afford that !");
            return 1;
        }
     }
    else
    {
        SendClientMessage(playerid, COLOR_GREY, "   Nobody offered you a business.");
        return 1;
      }
} 
Take this code. What is printing in the console (server.log.txt) when you buy a bizz by an player?
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#9

26.06.2016, 11:40
also it gives the business correctly, just just not update the 3DTextLable
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#10

26.06.2016, 11:41
Yes, I understood you.
Take the code above your last post and answer the question please.
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#11

26.06.2016, 11:47
it said this, but didnt update business lable

pawn Код:
[13:43:23] Bizz-ID: 0 - New Owner: Maya 
[13:43:23]   [ function: updateaccount - Maya ]
[13:43:23]    < player file updated >
[13:43:23]   [ updateaccount complete ]
[13:43:23]   [ function: updateaccount - Maya ]
[13:43:23]    < player file updated >
[13:43:23]   [ updateaccount complete ]
[13:43:26]   [ function: updateaccount - Tom_Cowart ]
[13:43:26]    < player file updated >
[13:43:26]   [ updateaccount complete ]
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#12

26.06.2016, 11:49
So. Take this code:
PHP код:
forward OnPropTextdrawUpdate(bizzid);
public OnPropTextdrawUpdate(bizzid)
{
    printf("Bizz-ID #2: %i - Owner: %s - bOwned: %i",bizzid,BizzInfo[bizzid][bOwner],BizzInfo[bizzid][bOwned]);
    if(BizzInfo[bizzid][bOwned] == 0)
    {
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Status: For Sale \nPrice: $%s",BizzInfo[bizzid][bMessage],Comma(BizzInfo[bizzid][bBuyPrice]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    if(BizzInfo[bizzid][bOwned] == 1)
    {
        printf("Bizz-ID #2: %i - Owner: %s",bizzid,BizzInfo[bizzid][bOwner]);
        Delete3DTextLabel(BizzLabel[bizzid]);
        format(PropertyString,sizeof(PropertyString),""COL_BIZ"%s \n"COL_WHITE"Owner: %s \nEntry Fee: $%s",BizzInfo[bizzid][bMessage],BizzInfo[bizzid][bOwner],Comma(BizzInfo[bizzid][bEntranceCost]));
        BizzLabel[bizzid] = Create3DTextLabel(PropertyString ,COLOR_BIZ,BizzInfo[bizzid][bEntranceX], BizzInfo[bizzid][bEntranceY], BizzInfo[bizzid][bEntranceZ],25, 0, 1);
    }
    return 1;
} 
What is printing now?
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#13

26.06.2016, 11:56
it says this [13:54:19] Bizz-ID #2: 0 - Owner: Maya - bOwned: 0
Find
Reply
Mencent
High-roller
*****
Posts: 1,311
Threads: 11
Joined: Mar 2015
Reputation: 0
#14

26.06.2016, 11:57
PHP код:
else if(strcmp(x_job,"business",true) == 0)
{
    if(BizOffer[playerid] < 999)
     {
          if(PlayerInfo[playerid][pCash] > BizPrice[playerid])
        {
            if(IsPlayerConnected(BizOffer[playerid]))
            {
                  if(ProxDetectorS(3.0, playerid, BizOffer[playerid]))
                {
                    for(new i = 0; i < sizeof(BizzInfo); i++)
                     {
                            GetPlayerName(GuardOffer[playerid], giveplayer, sizeof(giveplayer));
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            if(!strcmp(BizzInfo[i][bOwner],giveplayer,true))
                            {
                                format(string, sizeof(string), "* You accepted the Business for $%d from %s.",BizPrice[playerid],giveplayer);
                                SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "* %s accepted your Business, and the $%d was added to your Bank Account.",sendername,BizPrice[playerid]);
                                SendClientMessage(GuardOffer[playerid], COLOR_LIGHTBLUE, string);
                                format(string, sizeof(string), "%s has accepted the business from %s for $%d", sendername,giveplayer,BizPrice[playerid]);
                                PayLog(string);
                                printf("Bizz-ID: %i - New Owner: %s",i,sendername);
                                PlayerInfo[playerid][pPbiskey] = PlayerInfo[BizOffer[playerid]][pPbiskey];
                                strmid(BizzInfo[i][bOwner], sendername, 0, strlen(sendername), 255);
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                UpdateAccount(playerid);
                                BizzInfo[i][bOwned] = 1;
                                PlayerInfo[BizOffer[playerid]][pPbiskey] = 255;
                                PlayerInfo[BizOffer[playerid]][pAccount] += BizPrice[playerid];
                                PlayerInfo[playerid][pCash] = PlayerInfo[playerid][pCash]-BizPrice[playerid];
                                GivePlayerMoney(playerid, -BizPrice[playerid]);
                                 BizOffer[playerid] = 999;
                                BizPrice[playerid] = 0;
                                OnPropTextdrawUpdate(i);
                                OnBizzPickupUpdate(i);
                                OnPropUpdate();
                                return 1;
                            }
                    }
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD1, "   You're too far away !");
                    return 1;
                }
            }
        }
        else
        {
              SendClientMessage(playerid, COLOR_GREY, "   You can't afford that !");
            return 1;
        }
     }
    else
    {
        SendClientMessage(playerid, COLOR_GREY, "   Nobody offered you a business.");
        return 1;
      }
} 
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#15

26.06.2016, 12:03
It's still not working, i think it is this line that is the problem
pawn Код:
strmid(BizzInfo[i][bOwner], sendername, 0, strlen(sendername), 255);
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#16

26.06.2016, 12:48
Anyone?
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#17

26.06.2016, 15:31
Still not fixed :/
Find
Reply
MayaEU
Huge Clucker
****
Posts: 384
Threads: 102
Joined: Nov 2015
Reputation: 0
#18

27.06.2016, 14:44
Can anyone help me?
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 2 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help