[justjamie]

Hello,
i'm making a command (banip), but it doesn't work.
Everytime i ban someone using the command it shows:

Код:

127.0.0.1 [03/04/16 | 10:36:52] justjamie - (null)

When i ban a ip using the rcon, i get this:

Код:

127.0.0.1 [03/04/16 | 10:39:50] NONE - IP BAN

The ip shows banned, but i still can join ingame.

This is my banip command:

pawn Код:

COMMAND:banip(playerid, params[])
{
    new eReason [ 64 ], iReason[ 128 ], tmp[ 64 ], string[ 128 ];
    if(sscanf(params, "ss", eReason, iReason)) return SCP(playerid, "[IP Range][Reason]");

    format(tmp, sizeof(tmp), "banip %s", eReason);
    SendRconCommand(tmp);
    SendRconCommand("reloadbans");

    format(string, MAX_STRING, "4[ IPBAN ] IP address %s has been banned. Reason: %s", eReason, iReason);
    iEcho(string);
    return 1;
}

What's wrong here and why doesn't it work?

[justjamie]

Someone any idea?

[AndySedeyn]

You need to add the string's size next to the specifiers in sscanf.

PHP код:

if(sscanf(params, "s[64]s[128]", eReason, iReason)) 


[justjamie]

Quote:

Originally Posted by AndySedeyn You need to add the string's size next to the specifiers in sscanf. PHP код: if(sscanf(params, "s[64]s[128]", eReason, iReason))

Doesn't work.

[iKevin]

Quote:

Originally Posted by justjamie Doesn't work.

Do you have sscanf plugin and include?

[justjamie]

Quote:

Originally Posted by KevinExec Do you have sscanf plugin and include?

Yup,
otherwise it wouldnt show the NULL as a ban, right?

[Tingesport]

Код:

COMMAND:banip(playerid, params[])
{
	new eReason [ 64 ], iReason[ 128 ], tmp[ 64 ], string[ 128 ];
	if(sscanf(params, "s[64]s[128]", eReason, iReason)) return SCP(playerid, "[IP Range][Reason]");

	format(tmp, sizeof(tmp), "banip %s", eReason);
	SendRconCommand(tmp);
	SendRconCommand("reloadbans");

	format(string, MAX_STRING, "4[ IPBAN ] IP address %s has been banned. Reason: %s", eReason, iReason);
	iEcho(string);
	return 1;
}

You need to specify string size within sscanf parameters even though it's specified.

[justjamie]

Quote:

Originally Posted by Tingesport Код: COMMAND:banip(playerid, params[]) { new eReason [ 64 ], iReason[ 128 ], tmp[ 64 ], string[ 128 ]; if(sscanf(params, "s[64]s[128]", eReason, iReason)) return SCP(playerid, "[IP Range][Reason]"); format(tmp, sizeof(tmp), "banip %s", eReason); SendRconCommand(tmp); SendRconCommand("reloadbans"); format(string, MAX_STRING, "4[ IPBAN ] IP address %s has been banned. Reason: %s", eReason, iReason); iEcho(string); return 1; } You need to specify string size within sscanf parameters even though it's specified.

now it shows this

[Karan007]

PHP код:

COMMAND:banip(playerid, params[])
{
    new eReason [ 64 ], iReason[ 128 ], tmp[ 64 ], string[ 128 ];
    if(sscanf(params, "ss", eReason, iReason)) return SendClientMessage(playerid, -1,"[IP Range][Reason]");

    format(tmp, sizeof(tmp), "banip %s", eReason);
    SendRconCommand(tmp);
    SendRconCommand("reloadbans");

    format(string, sizeof(string), "4[ IPBAN ] IP address %s has been banned. Reason: %s", eReason, iReason);
    iEcho(string);
    return 1;
} 


Not sure if it'll work but try it WITHOUT changing anything in my code.

[justjamie]

Quote:

Originally Posted by Karan007 PHP код: COMMAND:banip(playerid, params[]) {     new eReason [ 64 ], iReason[ 128 ], tmp[ 64 ], string[ 128 ];     if(sscanf(params, "ss", eReason, iReason)) return SendClientMessage(playerid, -1,"[IP Range][Reason]");     format(tmp, sizeof(tmp), "banip %s", eReason);     SendRconCommand(tmp);     SendRconCommand("reloadbans");     format(string, sizeof(string), "4[ IPBAN ] IP address %s has been banned. Reason: %s", eReason, iReason);     iEcho(string);     return 1; }  Not sure if it'll work but try it WITHOUT changing anything in my code.

It works now, but i can still connect with that IP.