[Sc0pion]

Fixed!

[TonyVk]

Why you dont use public OnPlayerEnterVehicle?

[Mouiz]

Use this:

PHP код:

public OnPlayerStateChange(playerid, newstate, oldstate) 
{ 
    new vehicleid = GetVehicleModel(GetPlayerVehicleID(playerid)); 
    if(vehicleid == 437 || vehicleid == 431) 
    { 
        if(Bus_Driver[playerid] == 1) 
        { 
            SendClientMessage(playerid,COLOR_YELLOW, "Use /busdriver to begin.");
        } 
    } 
    if(vehicleid != 437 || vehicleid != 431) 
    { 
        if(Bus_Driver[playerid] == 0) 
        { 
            SendClientMessage(playerid,COLOR_YELLOW, "Bus driver job has been cancelled as you got into another vehicle other than a coach, or a bus.");
        } 
    } 
    return 1; 
} 


[xerox8521]

Either add an else before the 2nd if statement or replace the || with && in the 2nd statement

[Sc0pion]

Fixed!

[Mouiz]

Quote:

Originally Posted by Sc0pion Player looses the job doesn't matter which vehicle he/she gets in. PHP код: public OnPlayerEnterVehicle(playerid, vehicleid) { /*------------------------------------------------------ -> When player exits a vehicle ------------------------------------------------------*/ /*------------------------------------------------------ -> When player enters a diffenrent vehicle when doing a job ------------------------------------------------------*/     new busdrivervehicle = GetVehicleModel(GetPlayerVehicleID(playerid));     if(busdrivervehicle != 437 || busdrivervehicle != 431)     {         if(Bus_Driver[playerid] == 1)         {             new Bstring[256], busdriver[MAX_PLAYER_NAME];             GetPlayerName(playerid, busdriver, sizeof(busdriver));             Bus_Driver[playerid] = 0;             DestroyDynamicRaceCP(BD_Checkpoint[playerid]);             BD_Steps[playerid] = BD_Checkpoint[playerid] = -1;             SendClientMessage(playerid, green, "[ NOTIFICATION: Your bus driver job has been abandoned as you got into a different vehicle. ]");             format(Bstring, sizeof(Bstring), "[ BUS DRIVER: %s (Id: %d) is no longer a bus driver in Los Santos. ]", busdriver, playerid);             return SendClientMessageToAll(green,Bstring);         }     }      return 1; }  You are wrong mate: PHP код: if(Bus_Driver[playerid] == 0)// Not a bus driver  if(Bus_Driver[playerid] == 1) //Is a bus driver

Oh sorry for that,i dident noticed

[Sc0pion]

Fixed!

[TonyVk]

Try this:

Код:

public OnPlayerStateChange(playerid, newstate, oldstate) 
{ 
    new vehicleid = GetVehicleModel(GetPlayerVehicleID(playerid)); 
/*------------------------------------------------------ 
-> When player enters a coach or a buss 
------------------------------------------------------*/ 
    if(vehicleid == 437 || vehicleid == 431) 
    { 
        if(Bus_Driver[playerid] == 0) 
        { 
            return SendClientMessage(playerid,COLOR_YELLOW, "Use /busdriver to begin.");// This works when I'm not a bus driver. 
        } 
    } 
    if(vehicleid != 437 && vehicleid != 431) 
    { 
        if(Bus_Driver[playerid] == 1) 
        { 
            return SendClientMessage(playerid,COLOR_YELLOW, "Bus driver job has been cancelled as you got into another vehicle other than a coach, or a bus.");
        } 
    } 
    return 1; 
}

[Sc0pion]

Fixed!

[Threshold]

pawn Код:

public OnPlayerStateChange(playerid, newstate, oldstate)
{
    if(newstate == PLAYER_STATE_DRIVER)
    {
        new vehicleid = GetVehicleModel(GetPlayerVehicleID(playerid));
        /*------------------------------------------------------
        -> When player enters a coach or a buss
        ------------------------------------------------------*/
        if(vehicleid == 437 || vehicleid == 431)
        {
            if(!Bus_Driver[playerid]) SendClientMessage(playerid, COLOR_YELLOW, "Use /busdriver to begin.");
        }
        else
        {
            if(Bus_Driver[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_YELLOW, "Bus driver job has been cancelled as you got into another vehicle other than a coach, or a bus.");
                //Bus_Driver[playerid] = 0;
            }
        }
    }
    return 1;
}

The problem was this line:

pawn Код:

if(vehicleid != 437 || vehicleid != 431)

This means, if the vehicle model isn't 437, or isn't 431, then continue..
Let's say your vehicle model is 437. (Bus or coach? too lazy to search)

If your vehicle model is 437, that means it is NOT equal to 431. If your vehicle model is 431, that means it is NOT equal to 437. So this statement would successfully continue for any and every vehicle model. The correct usage would have been:

pawn Код:

if(vehicleid != 437 && vehicleid != 431)

This way, if the model is NOT 437, AND the model is NOT 431, then continue.