[Rabea]

i can enter any password and it will work
any fix?

pawn Код:

else if(dialogid == 2) // Login
    {
        if(response)
        {
            new file[64], password[256], IP[16], password2[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            WP_Hash(password2, sizeof(password2), inputtext);
            format(password, sizeof(password), "%s", dini_Get(file, "Password"));
            if(strcmp(password, inputtext,true) && strcmp(password, password2, true))
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}Invalid password.");
                ShowDialog(playerid, 2);
                return 1;
            }
            if(strlen(inputtext) < 4)
            {
             SendClientMessage(playerid, COLOR_GREY, "Password can't be shorter than 6 characters.");
             ShowDialog(playerid, 2);
             return 1;
            }
            if(strlen(inputtext) > 256)
            {
                SendClientMessage(playerid, COLOR_GREY, "Password can't be longer than 256 characters.");
                ShowDialog(playerid, 2);
                return 1;
            }
            else if(sscanf(inputtext, "s[128]", inputtext))
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}You must enter a password to procceed.");
                ShowDialog(playerid, 2);
                return 1;
            }
            else
            {
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                format(PlayerInfo[playerid][pIP], 16, "%s", dini_Get(file, "IP"));
                GetPlayerIp(playerid, IP, sizeof(IP));
                dini_Set(file, "IP", IP);
                PlayerInfo[playerid][pGender] = dini_Int(file, "Gender");
                PlayerInfo[playerid][pAge] = dini_Int(file, "Age");
                if(!PlayerInfo[playerid][pGender] || !PlayerInfo[playerid][pAge])
                {
                    ShowDialog(playerid, 3);
                }
                else
                {
                    LoadChar(playerid);
                    SpawnPlayer(playerid);
                }
            }
        }
        else
        {
            SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}You have chosen to quit the server.");
            FixedKick(playerid);
        }
    }

[DRIFT_HUNTER]

pawn Код:

if(strcmp(password, inputtext,true) && strcmp(password, password2, true))

to:

pawn Код:

if(strlen(password2) > 0 && strcmp(password, password2) == 0)

Remember: strcmp returns 0 if strings are matched.
And i assumed that you save passwords in user file hashed with WP_Hash

[Rabea]

All passwords works exept the one i created.

[DRIFT_HUNTER]

Show how you save passwords

[Rabea]

pawn Код:

else if(dialogid == 1) // Register
    {
        if(response)
        {
            if(strlen(inputtext) < 6)
            {
             SendClientMessage(playerid, COLOR_GREY, "Password can't be shorter than 6 characters.");
             ShowDialog(playerid, 1);
             return 1;
            }
            if(strlen(inputtext) > 256)
            {
                SendClientMessage(playerid, COLOR_GREY, "Password can't be longer than 256 characters.");
                ShowDialog(playerid, 1);
                return 1;
            }
            new file[64], IP[16], string[128], password[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            if(!dini_Exists(file))
            {
                GetPlayerIp(playerid, IP, sizeof(IP));
                dini_Create(file);
                WP_Hash(password, sizeof(password), inputtext);
                dini_Set(file, "Password", password);
                dini_Set(file, "IP", IP);
                PlayerInfo[playerid][pLevel] = 1;
                dini_IntSet(file, "Level", PlayerInfo[playerid][pLevel]);
                format(string, sizeof(string), "SERVER: {FFFFFF}You have successfully registered on {FF6347}RealCity RPG{FFFFFF}. (Password: %s)", inputtext);
                SendClientMessage(playerid, COLOR_LIGHTRED, string);
                ShowDialog(playerid, 2);
            }
        }
        else
        {
            SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}You have chosen to quit the server.");
            FixedKick(playerid);
        }
    }

[DRIFT_HUNTER]

These must work as i checked every line

pawn Код:

else if(dialogid == 2) // Login
    {
        if(response)
        {
            new file[64], password[256], IP[16], password2[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            WP_Hash(password2, sizeof(password2), inputtext);
            format(password, sizeof(password), "%s", dini_Get(file, "Password"));

            if(strlen(inputtext) == 0)
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}You must enter a password to procceed.");
                ShowDialog(playerid, 2);
                return 1;
            }
            if(strlen(inputtext) < 4)
            {
             SendClientMessage(playerid, COLOR_GREY, "Password can't be shorter than 6 characters.");
             ShowDialog(playerid, 2);
             return 1;
            }
            if(strlen(inputtext) > 256)
            {
                SendClientMessage(playerid, COLOR_GREY, "Password can't be longer than 256 characters.");
                ShowDialog(playerid, 2);
                return 1;
            }
            else if(strcmp(password, password2, true) != 0)
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}Invalid password.");
                ShowDialog(playerid, 2);
                return 1;
            }
            else
            {
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                SendClientMessage(playerid, COLOR_WHITE, "");
                format(PlayerInfo[playerid][pIP], 16, "%s", dini_Get(file, "IP"));
                GetPlayerIp(playerid, IP, sizeof(IP));
                dini_Set(file, "IP", IP);
                PlayerInfo[playerid][pGender] = dini_Int(file, "Gender");
                PlayerInfo[playerid][pAge] = dini_Int(file, "Age");
                if(!PlayerInfo[playerid][pGender] || !PlayerInfo[playerid][pAge])
                {
                    ShowDialog(playerid, 3);
                }
                else
                {
                    LoadChar(playerid);
                    SpawnPlayer(playerid);
                }
            }
        }
        else
        {
            SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}You have chosen to quit the server.");
            FixedKick(playerid);
        }
    }

[Rabea]

Thanks.
+rep