1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Don't show admin names
DerickClark
High-roller
*****
Posts: 1,752
Threads: 338
Joined: Jul 2012
Reputation: 0
#1

26.01.2013, 22:42
it don't show the Admin Names olny the number level i wanna it as a name like Moderator


Код:
COMMAND:admins(playerid, params[])
{
    new str[128],name[MAX_PLAYER_NAME];
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    for(new i; i<=MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 GetPlayerName(i,name,sizeof(name));
                 format(str, sizeof(str), "%s[%d] Level:%d",name, i,APlayerData[i][PlayerLevel]);
                 SendClientMessage(playerid, 0xFFFFFFAA, str);
            }
        }
    }
    return 1;
}
Find
Reply
Sime30
Huge Clucker
****
Posts: 348
Threads: 26
Joined: Oct 2012
Reputation: 0
#2

26.01.2013, 23:17
pawn Код:
COMMAND:admins(playerid, params[])
{
    new str[128],name[MAX_PLAYER_NAME];
    GetPlayerName(i, sendername, sizeof(sendername));
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    foreach (Player, i)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 format(string, 256, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level{FFFFFF}%s",sendername,APlayerData[i][PlayerLevel]);
         SendClientMessage(playerid, 0xFFFFFFAA, str);
            }
        }
    }
    return 1;
}
Find
Reply
DerickClark
High-roller
*****
Posts: 1,752
Threads: 338
Joined: Jul 2012
Reputation: 0
#3

26.01.2013, 23:25
Код:
C:\Users\pawno\include\PPC_PlayerCommands.inc(2525) : error 017: undefined symbol "i"
C:\Users\pawno\include\PPC_PlayerCommands.inc(2525) : error 017: undefined symbol "sendername"
C:\Users\include\PPC_PlayerCommands.inc(2525) : error 029: invalid expression, assumed zero
C:\Users\pawno\include\PPC_PlayerCommands.inc(2525) : fatal error 107: too many error messages on one line

Compilation aborted.Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


4 Errors.
Find
Reply
Sime30
Huge Clucker
****
Posts: 348
Threads: 26
Joined: Oct 2012
Reputation: 0
#4

26.01.2013, 23:33
pawn Код:
COMMAND:admins(playerid, params[])
{
    new str[128],name[MAX_PLAYER_NAME];
    new sendername[MAX_PLAYER_NAME];
    GetPlayerName(i, sendername, sizeof(sendername));
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    for(new i; i<=MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 format(string, 256, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level{FFFFFF}%s",sendername,APlayerData[i][PlayerLevel]);
         SendClientMessage(playerid, 0xFFFFFFAA, str);
            }
        }
    }
    return 1;
}
Find
Reply
DerickClark
High-roller
*****
Posts: 1,752
Threads: 338
Joined: Jul 2012
Reputation: 0
#5

26.01.2013, 23:35
Still don't work
Find
Reply
SchurmanCQC
High-roller
*****
Posts: 1,739
Threads: 53
Joined: Oct 2010
Reputation: 0
#6

26.01.2013, 23:41
Quote:
Originally Posted by Sime30
Посмотреть сообщение
pawn Код:
COMMAND:admins(playerid, params[])
{
    new str[128],name[MAX_PLAYER_NAME];
    new sendername[MAX_PLAYER_NAME];
    GetPlayerName(i, sendername, sizeof(sendername));
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    for(new i; i<=MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 format(string, 256, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level{FFFFFF}%s",sendername,APlayerData[i][PlayerLevel]);
           SendClientMessage(playerid, 0xFFFFFFAA, str);
            }
        }
    }
    return 1;
}
There are obvious mistakes in your code.

pawn Код:
COMMAND:admins(playerid, params[])
{
    new string[128],name[MAX_PLAYER_NAME], sendername[MAX_PLAYER_NAME], admins;
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    for(new i=0;i<MAX_PLAYERS;i++)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 admins++;
                 GetPlayerName(i, sendername, sizeof(sendername));//Gave i a value when it wasn't even initialized.
                 format(string, 128, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level{FFFFFF}%s",sendername,APlayerData[i][PlayerLevel]);//Never initialized variable string?
                 SendClientMessage(playerid, 0xFFFFFFAA, string);//Sent the player an empty string.
            }
        }
    }
    if(admins == 0)
    {
        SendClientMessage(playerid, 0xFFFFFFAA, "None.");
    }
    return 1;
}
Find
Reply
DerickClark
High-roller
*****
Posts: 1,752
Threads: 338
Joined: Jul 2012
Reputation: 0
#7

26.01.2013, 23:44
Quote:
Originally Posted by Schurman
Посмотреть сообщение
There are obvious mistakes in your code.

pawn Код:
COMMAND:admins(playerid, params[])
{
    new string[128],name[MAX_PLAYER_NAME], sendername[MAX_PLAYER_NAME], admins;
    SendClientMessage(playerid, 0xFFFFFFAA, "Admins Online:");
    for(new i=0;i<MAX_PLAYERS;i++)
    {
        if(IsPlayerConnected(i))
        {
            if (APlayerData[i][PlayerLevel] >= 1)
            {
                 admins++;
                 GetPlayerName(i, sendername, sizeof(sendername));//Gave i a value when it wasn't even initialized.
                 format(string, 128, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level{FFFFFF}%s",sendername,APlayerData[i][PlayerLevel]);//Never initialized variable string?
                 SendClientMessage(playerid, 0xFFFFFFAA, string);//Sent the player an empty string.
            }
        }
    }
    if(admins == 0)
    {
        SendClientMessage(playerid, 0xFFFFFFAA, "None.");
    }
    return 1;
}
Код:
C:\pawno\include\PPC_PlayerCommands.inc(2524) : warning 204: symbol is assigned a value that is never used: "name"
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


1 Warning.
Find
Reply
Sime30
Huge Clucker
****
Posts: 348
Threads: 26
Joined: Oct 2012
Reputation: 0
#8

26.01.2013, 23:45
Do you have something like this on top ?
pawn Код:
#define ForEach(%0,%1) \
    for(new %0; %0 != %1; %0++) if(IsPlayerConnected(%0) && !IsPlayerNPC(%0))
IF YES ,TRY THIS!

pawn Код:
CMD:admins(playerid, params[])
    {
        if(IsPlayerConnected(playerid))
        {
                new string[256];
                new sendername[MAX_PLAYER_NAME];
            SendClientMessage(playerid, COLOR_GREEN, "__________Admins__________");
            foreach (Player, i)
            {
                if(APlayerData[i][PlayerLevel] >= 1 && APlayerData[i][PlayerLevel] < 1339)
                {
                    new admtext[256];
                    if(APlayerData[i][PlayerLevel] == 1338) { admtext = "Owner"; }
                    else if(APlayerData[i][PlayerLevel] == 1337) { admtext = "1337"; }
                    else if(APlayerData[i][PlayerLevel] == 5) { admtext = "5"; }
                    else if(APlayerData[i][PlayerLevel] == 4) { admtext = "4"; }
                    else if(APlayerData[i][PlayerLevel] == 3) { admtext = "3"; }
                    else if(APlayerData[i][PlayerLevel] == 2)   { admtext = "2"; }
                    else if(APlayerData[i][PlayerLevel] == 1) { admtext = "1"; }
                    else { admtext = "1"; }
                    GetPlayerName(i, sendername, sizeof(sendername));
                    format(string, 256, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level: {FFFFFF}%s", sendername, admtext);
                        SendClientMessage(playerid, COLOR_YELLOW, string);
                    }

                }
            }
        }
        return 1;
    }
Find
Reply
SchurmanCQC
High-roller
*****
Posts: 1,739
Threads: 53
Joined: Oct 2010
Reputation: 0
#9

26.01.2013, 23:49
Quote:
Originally Posted by Sime30
Посмотреть сообщение
Do you have something like this on top ?
pawn Код:
#define ForEach(%0,%1) \
    for(new %0; %0 != %1; %0++) if(IsPlayerConnected(%0) && !IsPlayerNPC(%0))
IF YES ,TRY THIS!

pawn Код:
CMD:admins(playerid, params[])
    {
        if(IsPlayerConnected(playerid))
        {
                new string[256];
                new sendername[MAX_PLAYER_NAME];
            SendClientMessage(playerid, COLOR_GREEN, "__________Admins__________");
            foreach (Player, i)
            {
                if(APlayerData[i][PlayerLevel] >= 1 && APlayerData[i][PlayerLevel] < 1339)
                {
                    new admtext[256];
                    if(APlayerData[i][PlayerLevel] == 1338) { admtext = "Owner"; }
                    else if(APlayerData[i][PlayerLevel] == 1337) { admtext = "1337"; }
                    else if(APlayerData[i][PlayerLevel] == 5) { admtext = "5"; }
                    else if(APlayerData[i][PlayerLevel] == 4) { admtext = "4"; }
                    else if(APlayerData[i][PlayerLevel] == 3) { admtext = "3"; }
                    else if(APlayerData[i][PlayerLevel] == 2)   { admtext = "2"; }
                    else if(APlayerData[i][PlayerLevel] == 1) { admtext = "1"; }
                    else { admtext = "1"; }
                    GetPlayerName(i, sendername, sizeof(sendername));
                    format(string, 256, "{F81414}Admin: {FFFFFF}%s | {48E31C}Level: {FFFFFF}%s", sendername, admtext);
                        SendClientMessage(playerid, COLOR_YELLOW, string);
                    }

                }
            }
        }
        return 1;
    }
Why the hell is admtext 256 cells in length when it only contains one or two characters? It should be 32 cells long at the MOST.

Don't be using this guy's code. It is poorly done and will lag your server. (Inefficient code means an iniffecient server.)
Find
Reply
Sime30
Huge Clucker
****
Posts: 348
Threads: 26
Joined: Oct 2012
Reputation: 0
#10

26.01.2013, 23:51
It won't lag! And I put 256 if he wants to change maybe "1" to word "Moderator"
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help