[Wonderweiss]

can you guys help me when a player kills other player
to display a message
something like this but i got a error

Код:

SendClientMessage(killerid, COLOR_YELLOW, "Congratulations you killed %s !"); (playerid);

the error:

Код:

C:\Users\Bojan\Desktop\LVDM\gamemodes\lvdm.pwn(311) : warning 215: expression has no effect

[CentyPoo]

pawn Код:

SendClientMessage(killerid, COLOR_YELLOW, "Congratulations you killed %s !", playerid);

Your (playerid) was in the wrong place, when you use %s, %d for example, just place the vars after the string with a comma.

EDIT: playerid isn't a string either, if you wanted names it'd be;

pawn Код:

new pName[MAX_PLAYER_NAME], string[128];
pName = GetPlayerName(playerid, pName, MAX_PLAYER_NAME);
format(string, sizeof(string), "Congratulations you killed %s !", pName);
SendClientMessage(killerid, COLOR_YELLOW, string);

EDIT again: Thanks for the post below, forgot about format.

[Wonderweiss]

i get this error now

Код:

C:\Users\Bojan\Desktop\LVDM\gamemodes\lvdm.pwn(311) : warning 202: number of arguments does not match definition

[[HK]Ryder[AN]]

wrong code you got there bro.
Use this

Код:

new string[100];
format(string, sizeof(string), "Congratulations you killed %s !", playerid);
SendClientMessage(killerid, COLOR_YELLOW, string);

[Wonderweiss]

@[HK]Ryder[AN] it dosnt work.. no message show

[[HK]Ryder[AN]]

Where did you paste it?Show some code around it.

[Wonderweiss]

here is the whole thing

Код:

public OnPlayerDeath(playerid, killerid, reason)
{
    new playercash;
	if(killerid == INVALID_PLAYER_ID) {
        SendDeathMessage(INVALID_PLAYER_ID,playerid,reason);
        ResetPlayerMoney(playerid);
        	new string[100];
	format(string, sizeof(string), "Congratulations you killed %s !", playerid);
	SendClientMessage(killerid, COLOR_YELLOW, string);
	} else {
	    	SendDeathMessage(killerid,playerid,reason);
			SetPlayerScore(killerid,GetPlayerScore(killerid)+1);
			playercash = GetPlayerMoney(playerid);
			if (playercash > 0)  {
				GivePlayerMoney(killerid, playercash);
				ResetPlayerMoney(playerid);
			}
			else
			{
			}
     	}
 	return 1;
}

[[HK]Ryder[AN]]

Change this whole thing to

Код:

public OnPlayerDeath(playerid, killerid, reason)
{
    new playercash;
	if(killerid == INVALID_PLAYER_ID) {
        SendDeathMessage(INVALID_PLAYER_ID,playerid,reason);
        ResetPlayerMoney(playerid);
        	new string[100], pname[MAX_PLAYER_NAME+1];
        GetPlayerName(playerid, pname, sizeof(pname));
	format(string, sizeof(string), "Congratulations you killed %s !", pname);
	SendClientMessage(killerid, -1, string);
	} else {
	    	SendDeathMessage(killerid,playerid,reason);
			SetPlayerScore(killerid,GetPlayerScore(killerid)+1);
			playercash = GetPlayerMoney(playerid);
			if (playercash > 0)  {
				GivePlayerMoney(killerid, playercash);
				ResetPlayerMoney(playerid);
			}
			else
			{
			}
     	}
 	return 1;
}

[Wonderweiss]

it still dosnt work

[Emmet_]

Lot of mistakes in that code lol

pawn Код:

public OnPlayerDeath(playerid, killerid, reason)
{
    new playercash;
    if (killerid != INVALID_PLAYER_ID) 
    {
        SendDeathMessage(killerid, playerid, reason);
        new string[64], pname[MAX_PLAYER_NAME+1];
        GetPlayerName(playerid, pname, sizeof(pname));
    format(string, sizeof(string), "Congratulations you killed %s !", pname);
    SendClientMessage(killerid, -1, string);
   
    SendDeathMessage(killerid,playerid,reason);
    SetPlayerScore(killerid,GetPlayerScore(killerid)+1);
    playercash = GetPlayerMoney(playerid);
    if (playercash > 0)  
        {
        GivePlayerMoney(killerid, playercash);
        ResetPlayerMoney(playerid);
        }
    }
    else
    {
        ResetPlayerMoney(playerid);
    }
    return 1;
}