[Akcent_Voltaj]

how can i make this "/refill [name] [price] [reason]"

PHP код:

    if(strcmp(cmd, "/refill", true) == 0)
                    {
                        if(IsPlayerConnected(playerid))
                        {
                              if (PlayerInfo[playerid][pMember] == 15)
                            {
                                SendClientMessage(playerid, COLOR_GREY, "   You are not a Car Mechanic!");
                                return 1;
                            }
                            tmp = strtok(cmdtext, idx);
                            if(!strlen(tmp))
                            {
                                SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /refill [playerid/PartOfName] [price]");
                                return 1;
                            }
                            new playa;
                            new money;
                            playa = ReturnUser(tmp);
                            tmp = strtok(cmdtext, idx);
                            money = strval(tmp);
                            if(money < 1 || money > 99999) { SendClientMessage(playerid, COLOR_GREY, "   Price not lower then 1, or above 99999!"); return 1; }
                            if(IsPlayerConnected(playa))
                            {
                                if(playa != INVALID_PLAYER_ID)
                                {
                                    if(ProxDetectorS(8.0, playerid, playa)&& IsPlayerInAnyVehicle(playa))
                                    {
                                        if(playa == playerid) { SendClientMessage(playerid, COLOR_GREY, "   Can't do that!"); return 1; }
                                        GetPlayerName(playa, giveplayer, sizeof(giveplayer));
                                        GetPlayerName(playerid, sendername, sizeof(sendername));
                                        format(string, sizeof(string), "* Iai oferit lui %s ca sa-i faci plinu cu %dLei .",giveplayer,money);
                                        SendClientMessage(playerid, COLOR_PURPLE, string);
                                        format(string, sizeof(string), "* Mecanicul %s vrea sa-ti faca plinu cu %dLei, (scrie /accepta refill) pentru a accepta.",sendername,money);
                                        SendClientMessage(playa, COLOR_LIGHTBLUE, string);
                                        RefillOffer[playa] = playerid;
                                        RefillPrice[playa] = money;
                                    }
                                    else
                                    {
                                        SendClientMessage(playerid, COLOR_GREY, "   That player is not near you / not in a car.");
                                    }
                                }
                            }
                            else
                            {
                                SendClientMessage(playerid, COLOR_GREY, "   That player is offline.");
                            }
                        }
                        return 1;
                    } 


[Roel]

It's possible with the strtok function, but it will get a chaos and I think it also will be bugged.
Why don't you use sscanf, then this is very easy.

[KingHual]

1st - Use zcmd, it's a faster command processer. 2nd - Use sscanf, sinc strtok is slow.

[Roel]

Quote:

Originally Posted by king_hual 1st - Use zcmd, it's a faster command processer. 2nd - Use sscanf, sinc strtok is slow.

Are you sure, because I don't think zcmd is faster, it's only a little easier to write commands.
I think you should use dcmd, because this also allows you to easy write cmds.
And because it is a define thingy, it is not faster and not slower then the normal cmd definition.
Not sure if zcmd is slower but it's a include with maybe 100 lines, so I think it is slower.
I'm sure it isn't faster.

And the thing i like with dcmd is that it allows to to group the cmds in onplayercommand.
in zcmd you have to put in every single cmd that he isn't allowed to use it when he is in a vehicle.
Using dcmd you can just put the dcmd in the if(onfoot) thing.

[Akcent_Voltaj]

i would like information ,how is it slow?i only know strtok..what inc.do i need for zcmd?or..

[KingHual]

Zcmd - https://sampforum.blast.hk/showthread.php?tid=91354
Sscanf - https://sampforum.blast.hk/showthread.php?tid=120356 (It's a plugin)

And zcmd is not slower than the default processor. Also, speed has nothing to do with number of lines.

[Roel]

For dcmd you only need to put this line below your includes at the top of your script:

Код:

#define dcmd(%1,%2,%3) if (!strcmp((%3)[1], #%1, true, (%2)) && ((((%3)[(%2) + 1] == '\0') && (dcmd__%1(playerid, ""))) || (((%3)[(%2) + 1] == ' ') && (dcmd__%1(playerid, (%3)[(%2) + 2]))))) return 1

Then you can make a cmd like this:

Код:

public OnPlayerCommandText(playerid, cmdtext[])
{
	dcmd(heal, 4, cmdtext);
	return 0;
}
 
dcmd_heal(playerid, params[])
{
        new id;
	if (strlen(params))
	{
		id = strval(params);
		if (IsPlayerConnected(id))
		{
			SetPlayerHealth(id, 100.0);
			SendClientMessage(id, 0x00FF00AA, "You have been healed");
			SendClientMessage(playerid, 0x00FF00AA, "Player healed");
		}
		else
		{
			SendClientMessage(playerid, 0xFF0000AA, "Player not found");
		}
	}
	else
	{
		SendClientMessage(playerid, 0xFF0000AA, "Usage: \"/heal <playerid>\"");
	}
	return 1;
}

And I looked on wiki, it seems the zcmd is faster, I don't know how but it seems to be: here you can find zcmd: clicky

[Roel]

Quote:

Originally Posted by king_hual Zcmd - https://sampforum.blast.hk/showthread.php?tid=91354 Sscanf - https://sampforum.blast.hk/showthread.php?tid=120356 (It's a plugin) And zcmd is not slower than the default processor. Also, speed has nothing to do with number of lines.

Yea I was wrong lol, this is faster indeed, but still I like dcmd more because it's easy to group them.

[Akcent_Voltaj]

COMMAND:mycommand(playerid, params[])
{
//my refill for top
} is it good for zcmd??

[KingHual]

Sure, but remove all the useless strtok-related variables, and use sscanf