1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
/Siren Help Please [+REP]
rbush12
Big Clucker
***
Posts: 197
Threads: 9
Joined: Jul 2012
Reputation: 0
#1

30.09.2012, 10:06
hey Guys

i have a siren system inside my gamemode and it works fine, except when i try to remove it it doesnt remove. heres my code.

PHP код:
    if(strcmp(cmd, "/siren", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            if(PlayerInfo[playerid][pMember] == 1 || PlayerInfo[playerid][pLeader] == 1 || PlayerInfo[playerid][pMember] == 2 || PlayerInfo[playerid][pLeader] == 2 || gTeam[playerid] == 2)
            {
                new VID = GetPlayerVehicleID(playerid);
                tmp = strtok(cmdtext, idx);
                if(!strlen(tmp))
                {
                    SendClientMessage(playerid, COLOR_GREY, "USAGE: /siren [inside, roof, remove]");
                    SendClientMessage(playerid, COLOR_GREY, "[INFO]: 'remove' will remove the item from your vehicle!");
                    return 1;
                }
                strmid(Siren, tmp, 0, strlen(cmdtext), 255);
                if(strcmp(Siren, "inside", true, strlen(Siren)) == 0)
                {
                    if(!IsValidObject(Siren[playerid]))
                    {
                        //if(VID != 426) { return SendClientMessage(playerid, COLOR_LIGHTRED, "You need to be in a Premier model!"); } // If he's not in a Premier...
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                        AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.75, 0.4, 0.0, 0.1, 0.0); // Inside - Premier
                        format(string, sizeof(string), "* %s puts the siren on the dashboard.", sendername);
                        ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                    } else { return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren!"); }
                }
                else if(strcmp(Siren, "roof", true, strlen(Siren)) == 0)
                {
                    if(!IsValidObject(Siren[playerid]))
                    {
                        //if(VID != 426) { return SendClientMessage(playerid, COLOR_LIGHTRED, "You need to be in a Premier model!"); } // If he's not in a Premier...
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                        AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.0, 0.8, 0.0, 0.1, 0.0); // tak - Premier
                        format(string, sizeof(string), "* %s puts the siren on the roof.", sendername);
                        ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                    } else { return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren!"); }
                }
                else if(strcmp(Siren, "remove", true, strlen(Siren)) == 0)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    DestroyObject(Siren[playerid]);
                    Siren[playerid] = -1;
                    format(string, sizeof(string), "* %s takes down the siren.", sendername);
                    ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                }
            } else { SendClientMessage(playerid, COLOR_GREY, "[ERROR] You're not part of the team !"); }
        }
        return 1;
    } 
Please can someone help.
Find
Reply
The-gold
Little Clucker
**
Posts: 2
Threads: 0
Joined: Jan 2012
Reputation: 0
#2

30.09.2012, 10:43
Hello, i don't know the problem about your code but i think maybe you can try to delete : Siren[playerid] = -1;
No ?
And when you write in your chat : /siren remove
the sentance : "takes down the siren." appears ?

Sorry for my bad english ^^
Find
Reply
rbush12
Big Clucker
***
Posts: 197
Threads: 9
Joined: Jul 2012
Reputation: 0
#3

30.09.2012, 10:46
I have removed that line and the problem is still there.

PHP код:
    if(strcmp(cmd, "/siren", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            if(PlayerInfo[playerid][pMember] == 1 || PlayerInfo[playerid][pLeader] == 1 || PlayerInfo[playerid][pMember] == 2 || PlayerInfo[playerid][pLeader] == 2 || gTeam[playerid] == 2)
            {
                new VID = GetPlayerVehicleID(playerid);
                tmp = strtok(cmdtext, idx);
                if(!strlen(tmp))
                {
                    SendClientMessage(playerid, COLOR_GREY, "USAGE: /siren [inside, roof, remove]");
                    SendClientMessage(playerid, COLOR_GREY, "[INFO]: 'remove' will remove the item from your vehicle!");
                    return 1;
                }
                strmid(Siren, tmp, 0, strlen(cmdtext), 255);
                if(strcmp(Siren, "inside", true, strlen(Siren)) == 0)
                {
                    if(!IsValidObject(Siren[playerid]))
                    {
                        //if(VID != 426) { return SendClientMessage(playerid, COLOR_LIGHTRED, "You need to be in a Premier model!"); } // If he's not in a Premier...
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                        AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.75, 0.4, 0.0, 0.1, 0.0); // Inside - Premier
                        format(string, sizeof(string), "* %s puts the siren on the dashboard.", sendername);
                        ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                    } else { return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren!"); }
                }
                else if(strcmp(Siren, "roof", true, strlen(Siren)) == 0)
                {
                    if(!IsValidObject(Siren[playerid]))
                    {
                        //if(VID != 426) { return SendClientMessage(playerid, COLOR_LIGHTRED, "You need to be in a Premier model!"); } // If he's not in a Premier...
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                        AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.0, 0.8, 0.0, 0.1, 0.0); // tak - Premier
                        format(string, sizeof(string), "* %s puts the siren on the roof.", sendername);
                        ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                    } else { return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren!"); }
                }
                else if(strcmp(Siren, "remove", true, strlen(Siren)) == 0)
                {
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    DestroyObject(Siren[playerid]);
                    format(string, sizeof(string), "* %s takes down the siren.", sendername);
                    ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                }
            } else { SendClientMessage(playerid, COLOR_GREY, "[ERROR] You're not part of the team !"); }
        }
        return 1;
    } 
Find
Reply
The-gold
Little Clucker
**
Posts: 2
Threads: 0
Joined: Jan 2012
Reputation: 0
#4

30.09.2012, 10:50
Ok, so it's not the problem about on the code.
Find
Reply
rbush12
Big Clucker
***
Posts: 197
Threads: 9
Joined: Jul 2012
Reputation: 0
#5

30.09.2012, 11:30
OK. so
Find
Reply
rbush12
Big Clucker
***
Posts: 197
Threads: 9
Joined: Jul 2012
Reputation: 0
#6

30.09.2012, 12:23
Can someone please help me. I really need this to be fixed.
Find
Reply
Mr.Anonymous
Gangsta
*****
Posts: 852
Threads: 26
Joined: Jul 2011
Reputation: 0
#7

30.09.2012, 12:26
In the remove part, try to create the object again and then destroy it. Just try.
Find
Reply
Danyal
Huge Clucker
****
Posts: 332
Threads: 28
Joined: Sep 2011
Reputation: 0
#8

30.09.2012, 12:47
pawn Код:
//----------- On top of script
new SirenAttached[MAX_PLAYERS];

public OnPlayerConnect(playerid)
{
    SirenAttached[playerid] = 0;
}

if(strcmp(cmd, "/siren", true) == 0) 
    { 
        if(IsPlayerConnected(playerid)) 
        { 
            if(PlayerInfo[playerid][pMember] == 1 || PlayerInfo[playerid][pLeader] == 1 || PlayerInfo[playerid][pMember] == 2 || PlayerInfo[playerid][pLeader] == 2 || gTeam[playerid] == 2) 
            { 
                new VID = GetPlayerVehicleID(playerid);
                Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                tmp = strtok(cmdtext, idx);
                if(!strlen(tmp)) 
                { 
                    SendClientMessage(playerid, COLOR_GREY, "USAGE: /siren [inside, roof, remove]"); 
                    SendClientMessage(playerid, COLOR_GREY, "[INFO]: 'remove' will remove the item from your vehicle!"); 
                    return 1; 
                } 
                strmid(Siren, tmp, 0, strlen(cmdtext), 255); 
                if(strcmp(Siren, "inside", true, strlen(Siren)) == 0) 
                { 
                    if(!IsValidObject(Siren[playerid])) 
                    {
                        if(SirenAttached[playerid] == 0)
                        {
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            SirenAttached[playerid] = 1; 
                            AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.75, 0.4, 0.0, 0.1, 0.0);
                            format(string, sizeof(string), "* %s puts the siren on the dashboard.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE); 
                        }
                        else if(SirenAttached[playerid] == 2)
                        {
                            return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                        }
                    } 
                    else
                    { 
                        return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                    } 
                } 
                else if(strcmp(Siren, "roof", true, strlen(Siren)) == 0) 
                { 
                    if(!IsValidObject(Siren[playerid])) 
                    { 
                        if(SirenAttached[playerid] == 0)
                        {
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            SirenAttached[playerid] = 2;
                            AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.0, 0.8, 0.0, 0.1, 0.0); // tak - Premier 
                            format(string, sizeof(string), "* %s puts the siren on the roof.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                        }
                        else if(SirenAttached[playerid] == 1)
                        {
                            return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                        }
                    }
                    else
                    {
                        return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                    } 
                } 
                else if(strcmp(Siren, "remove", true, strlen(Siren)) == 0) 
                {
                    if(!IsValidObject(Siren[playerid])) 
                    {
                        if(SirenAttached[playerid] >= 1)
                        {                   
                            DestroyObject(Siren[playerid]);
                            SirenAttached[playerid] = 0;
                            GetPlayerName(playerid, sendername, sizeof(sendername)); 
                            format(string, sizeof(string), "* %s takes down the siren.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                        }
                    }
                } 
            } else { SendClientMessage(playerid, COLOR_GREY, "[ERROR] You're not part of the team !"); } 
        } 
        return 1; 
    }
Try this if it works...
Find
Reply
rbush12
Big Clucker
***
Posts: 197
Threads: 9
Joined: Jul 2012
Reputation: 0
#9

30.09.2012, 13:14
Quote:
Originally Posted by Danyal
Посмотреть сообщение
pawn Код:
//----------- On top of script
new SirenAttached[MAX_PLAYERS];

public OnPlayerConnect(playerid)
{
    SirenAttached[playerid] = 0;
}

if(strcmp(cmd, "/siren", true) == 0) 
    { 
        if(IsPlayerConnected(playerid)) 
        { 
            if(PlayerInfo[playerid][pMember] == 1 || PlayerInfo[playerid][pLeader] == 1 || PlayerInfo[playerid][pMember] == 2 || PlayerInfo[playerid][pLeader] == 2 || gTeam[playerid] == 2) 
            { 
                new VID = GetPlayerVehicleID(playerid);
                Siren[playerid] = CreateObject(19419, 10.0, 10.0, 10.0, 0, 0, 0);
                tmp = strtok(cmdtext, idx);
                if(!strlen(tmp)) 
                { 
                    SendClientMessage(playerid, COLOR_GREY, "USAGE: /siren [inside, roof, remove]"); 
                    SendClientMessage(playerid, COLOR_GREY, "[INFO]: 'remove' will remove the item from your vehicle!"); 
                    return 1; 
                } 
                strmid(Siren, tmp, 0, strlen(cmdtext), 255); 
                if(strcmp(Siren, "inside", true, strlen(Siren)) == 0) 
                { 
                    if(!IsValidObject(Siren[playerid])) 
                    {
                        if(SirenAttached[playerid] == 0)
                        {
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            SirenAttached[playerid] = 1; 
                            AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.75, 0.4, 0.0, 0.1, 0.0);
                            format(string, sizeof(string), "* %s puts the siren on the dashboard.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE); 
                        }
                        else if(SirenAttached[playerid] == 2)
                        {
                            return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                        }
                    } 
                    else
                    { 
                        return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                    } 
                } 
                else if(strcmp(Siren, "roof", true, strlen(Siren)) == 0) 
                { 
                    if(!IsValidObject(Siren[playerid])) 
                    { 
                        if(SirenAttached[playerid] == 0)
                        {
                            GetPlayerName(playerid, sendername, sizeof(sendername));
                            SirenAttached[playerid] = 2;
                            AttachObjectToVehicle(Siren[playerid], VID, 0.0, 0.0, 0.8, 0.0, 0.1, 0.0); // tak - Premier 
                            format(string, sizeof(string), "* %s puts the siren on the roof.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                        }
                        else if(SirenAttached[playerid] == 1)
                        {
                            return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                        }
                    }
                    else
                    {
                        return SendClientMessage(playerid, COLOR_GREY, "[ERROR] You already have a siren. First Remove it Then Add Next One!");
                    } 
                } 
                else if(strcmp(Siren, "remove", true, strlen(Siren)) == 0) 
                {
                    if(!IsValidObject(Siren[playerid])) 
                    {
                        if(SirenAttached[playerid] >= 1)
                        {                   
                            DestroyObject(Siren[playerid]);
                            SirenAttached[playerid] = 0;
                            GetPlayerName(playerid, sendername, sizeof(sendername)); 
                            format(string, sizeof(string), "* %s takes down the siren.", sendername); 
                            ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
                        }
                    }
                } 
            } else { SendClientMessage(playerid, COLOR_GREY, "[ERROR] You're not part of the team !"); } 
        } 
        return 1; 
    }
Try this if it works...
Ok this just shows up [ERROR] You already have a siren. First Remove it Then Add Next One! when i try to add a siren. But there is none there.
Find
Reply
Danyal
Huge Clucker
****
Posts: 332
Threads: 28
Joined: Sep 2011
Reputation: 0
#10

30.09.2012, 13:17
DO YOU HAVE TEAM VIEWER PM ME YOUR ID AND PASS SO I CAN HELP YOU OVER TV
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 5 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help