[FilterScript] Simple /accent release!
#1

My first release to the community .

Anyway, the only /accent FS here were either Dialog or in the following way : [Playername]:[Accent][Text]

Which causes bugs as when the game asks you if you're Male or Female and you have to type the answer, which would be like :
Player_Name:[Unknown Accent] Male -- Causing answer not to be accepted and losing new players.

And the dialog had only limited accents, and you have to access the .PWN to add another accent which is, rather well, boring and not every accent that each player wanted could be made as fast and as easy.

Version 2 needs ZCMD and SSCANF2 Includes!

So, my /accent is rather both, here's the difference :

1. Text is the following way :
[Accent][PlayerName]:Text -- Removing previous chat bugs.

2. Unlimited Possibilities, just type in /accent [accenthere] and voila!

PasteBin link -old- : http://pastebin.com/XYZQ9bEL
V2 http://pastebin.com/wRELJvaX


Picture :


Ignore the 'unknown command', it's just because I just added this command to the filterscript and in the server it's not yet defined as a command.
Reply
#2

pretty cool
Reply
#3

Glad I could offer something in my first day of registration!
Reply
#4

Nice
Reply
#5

nice , not bad
Reply
#6

Some constructive criticism.

Get rid of strtok. It's very inefficient and slow. No need for any command processor ether as you could just use cmdtext itself.
You don't need to see if a player is connected inside the command.
Why do you declare pAccent when you do not use it?

pawn Код:
if(strcmp(cmdtext, "/accent", true) == 0)
{
    if(strlen(cmdtext) < 9)
        return SendClientMessage(playerid, 0xFFFF00AA, "Syntax: /accent [accent]");
    new string[60];
    SetPVarString(playerid, "Accent", cmdtext[8]);
    format(string, 60, "You have set your accent to %s.", cmdtext[8]);
    SendClientMessage(playerid, 0x00FF00AA, string);
    return 1;
}
Reply
#7

/Accent ThisIsAVeryLongAccent!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!!!!!!!!!!!!!!

Forum added spaces to it but you get the idea..

You should limit the accent to at least 20 characters.
Reply
#8

Quote:
Originally Posted by Krx17
Посмотреть сообщение
Some constructive criticism.

Get rid of strtok. It's very inefficient and slow. No need for any command processor ether as you could just use cmdtext itself.
You don't need to see if a player is connected inside the command.
Why do you declare pAccent when you do not use it?

pawn Код:
if(strcmp(cmdtext, "/accent", true) == 0)
{
    if(strlen(cmdtext) < 9)
        return SendClientMessage(playerid, 0xFFFF00AA, "Syntax: /accent [accent]");
    new string[60];
    SetPVarString(playerid, "Accent", cmdtext[8]);
    format(string, 60, "You have set your accent to %s.", cmdtext[8]);
    SendClientMessage(playerid, 0x00FF00AA, string);
    return 1;
}
Nothing more I can say than thank you!
I really appreciate anyone criticizing me coz I'm still new and need every tip I get!
Thanks alot
And I'm glad everyone likes it and I will be editing it to make a lower and upper bound.
Reply
#9

Quote:
Originally Posted by On_Top_Non_Stop
Посмотреть сообщение
/Accent ThisIsAVeryLongAccent!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!!!!!!!!!!!!!!

Forum added spaces to it but you get the idea..

You should limit the accent to at least 20 characters.
Fixed that too, new version is released.
With lower bounds of 9 and upper bounds of 20
Reply
#10

V2 Link Fixed, just noticed it was dead -.-
Reply
#11

Euuh.........What's the point of this FS?? coz i think it's not usefull
Reply
#12

Quote:
Originally Posted by [WTF]Godfather
Посмотреть сообщение
Euuh.........What's the point of this FS?? coz i think it's not usefull
it is useful for beginners...plus it's his first FS give him a break >.>
Reply
#13

hmm i have seen this! before your ure you made this cuz we had another copiecat today:P

edit:
here i saw it but yours is different i guess:P click me now!!!!!!
Reply
#14

EDIT: for some reason this blocks out all of my commands...every time I do a command it says " you have changed your accent to ." any ideas?
Reply
#15

Quote:
Originally Posted by Master_Gangster
Посмотреть сообщение
EDIT: for some reason this blocks out all of my commands...every time I do a command it says " you have changed your accent to ." any ideas?
Edited V2, you need ZCMD and SSCANF2.
Reply
#16

Quote:
Originally Posted by maramizo
Посмотреть сообщение
Edited V2, you need ZCMD and SSCANF2.
how would I make this save when a player logs out then logs back in?
Reply
#17

Quote:
Originally Posted by Master_Gangster
Посмотреть сообщение
how would I make this save when a player logs out then logs back in?
Dini. You can add it up to your gamemode if you know how to script.
Plus this is just accent lol, takes 5 minutes to make it.
Reply
#18

Quote:
Originally Posted by Master_Gangster
Посмотреть сообщение
how would I make this save when a player logs out then logs back in?
So now it works?
Reply
#19

Quote:
Originally Posted by maramizo
Посмотреть сообщение
So now it works?
I'm actually starting to script again. sorry but I haven't figured out how to do it yet.
Reply
#20

Does anyone have an suggestions on any filterscripts to do next?
Reply


Forum Jump:


Users browsing this thread: 2 Guest(s)